Commit by JavaWoman :: r778 /branches/1.1.6.4/libs/Wakka.class.php: (link)

Aligning LogRefrrer() and LoadReferrers() with (just updated) version in trunk.

refs #562

Commit by JavaWoman :: r777 /trunk/libs/Wakka.class.php: (link)

merging NOTICE fix from 1.1.6.4 [776] back to trunk

Commit by JavaWoman :: r776 /branches/1.1.6.4/libs/Wakka.class.php: (link)

Fix for NOTICE in LogReferrer().

refs #562

Commit by JavaWoman :: r757 /branches/1.1.6.4/ (4 files in 4 dirs): (link)

Further changes to allow the installer to use existsPage() in the core.

refs #562

Commit by JavaWoman :: r756 /branches/1.1.6.4/handlers/page/edit.php: (link)

Important change:
 * fix for conversion of leading spaces to tabs (did not work at start of document); copied from online version

This change may need to be migrated to trunk; possibly some refinement possible, but at least this works.

Other changes:
 * fixes for notices
 * cleanup for coding guidelines
 * Unix line endings
 * updates in comments and docblock

Commit by JavaWoman :: r755 /branches/1.1.6.4/ (6 files in 4 dirs): (link)

'''Wakka.class.php'''

Changes to existsPage() Method:
 * made prefix an optional parameter so the function can also be used from the installer when the configuration has not been written yet
 * added an extra parameter so we can check either for any record with the give page name (original behavior), or for an active record only ('''new default''' behavior): in many cases where the function as used, checking for an active page only clearly as the intended behavior but this may cause subsequent errors if a page has been "removed" (or "hidden") while keeping page history.
 * cleanup: minor changes to Action() to avoid notices

'''install.php'''
 * now avoids adding extra (active) copies of  a page when the installer is re-run for a new install

'''backlinks, clone and showcode handlers; usersettings action'''
 * adapted to new existsPage() interface with (hopefully) the actual intended behavior - in most cases checking for an active page, not just any page record of the given name.
 * some minor cleanup & docblock updates here and there

'''Note:''' Most of these changes will have to be migrated to trunk as well (at least the non-installer changes; I'm not sure about the installer).

Commit by JavaWoman :: r754 /branches/1.1.6.4/ (.htaccess wikka.php): (link)

Changes for correct handling in installer:

'''.htaccess'''
 * rewriting changes so a correct URL is passed
'''wikka.php'''
 * Check for MySQL support in PHP before starting (prevents common problems especially with first-time installs)
 * based on .htaccess changes, base_url is now correctly derived, even when starting with a directory URL without trailing slash, or when given a page name but installer is triggered

Some other changes to wikka.php:
 * Utility functions placed at end of file so program flow is clearer
 * some general cleanup and more rational order of statements

Commit by JavaWoman :: r749 /branches/1.1.6.4/libs/Wakka.class.php: (link)

small fix to existsHandler() (paths are different in trunk and 1.1.6.4)

(again - it helps if you actually merge the changes...)

refs #562

Commit by JavaWoman :: r748 /branches/1.1.6.4/libs/Wakka.class.php: (link)

small fix to existsHandler() (paths are different in trunk and 1.1.6.4)

refs #562

Commit by JavaWoman :: r747 /branches/1.1.6.4/ (5 files in 2 dirs): (link)

minor update: name change ExistsPage -> existsPage (cf. [746])

refs #562

Commit by JavaWoman :: r746 /branches/1.1.6.4/libs/Wakka.class.php: (link)

'''New & updated functions'''
 * makeID (new)
 * FormOpen (advanced version)
 * existsPage (update: name change for consistency)
 * existsHandler (new)

Note: existsHandler and existsPage are moved to a new section for such "sanity checks".

refs #562

Commit by JavaWoman :: r739 /trunk/css/setup.css: (link)

replaced invalid 'xmp' element selector by 'samp' (there is no element 'xmp' in HTML)

Commit by JavaWoman :: r738 /trunk/handlers/ (21 files in 21 dirs): (link)

{{{Cleanup}}}
 * All line endings now UNIX (a lot were still Windows/DOS or even Mixed - no thanks to Eclipse)
 * (where I spotted it) removed double role of # EOL comment and  ticket number
 * (minor) whitespace

Commit by JavaWoman :: r737 /trunk/wikka.php: (link)

{{{Cleanup}}}
 * (where I spotted it) removed double role of # EOL comment and  ticket number
 * (minor) whitespace

Commit by JavaWoman :: r736 /trunk/actions/ (41 files in 41 dirs): (link)

{{{Cleanup}}}
 * All line endings now UNIX (a lot were still Windows/DOS or even Mixed - no thanks to Eclipse)
 * (where I spotted it) removed double role of # EOL comment and  ticket number
 * (minor) whitespace

Commit by JavaWoman :: r735 /trunk/ (libs/Wakka.class.php css/wikka.css): (link)

{{{Wakka.class.php}}}
 * Some changes in (advanced) FormOpen() to handle GET parameters when rewrite_mode is off (to be extended later)
 * minor cleanup

{{{wikka.css}}}
 * added rule for class="hidden" (primarily intended for a fieldset wrapper for hidden fields, but more generally usable)

Fixes #563

Commit by JavaWoman :: r726 /trunk/handlers/ (2 files in 2 dirs): (link)

 * fixes a number of notices that prevented a feed from being displayed directly in the browser, (or as an aggregated feed via the  {{rss}}  action)
 * some other small bugs fixed as well
 * added @todo and @@@ markers in the source for further issues to be resolved (see #552 a.o); see also remarks about usage of the $item->source attribute (currently used only in an RSS 1.0 feed as a dc:source element)
 * corrects @since tag in recentchanges.xml.php

refs #496,
refs #552

Commit by JavaWoman :: r722 /trunk/actions/feedback/feedback.php: (link)

small tweaks to feedback action:
 * improved splitting of admins list in config
 * retrieve admin email from DB rather than from config (DB is more likely to be current)
 * suppress "manual" addition of To: header since PHP (or MTA?) adds the envelope-to also to the headers and some mail servers don't filter duplicate mails to the same address

refs #547

Commit by JavaWoman :: r721 /trunk/libs/Wakka.class.php: (link)

fixes bug in splitting config admin users list.

refs #496

Commit by JavaWoman :: r720 /trunk/handlers/edit/edit.php: (link)

a little cleanup after changes for relocation.

refs #496