Commit by machiavelli on master :: ra1bedb2 / (11 files in 4 dirs): (link)

[s1540] Remove .hover command

You can use .cast 11010 and .unaura 11010 instead

Thanks to stfx for improving patch and porting it for us :)

Signed-off-by: Schmoozerd <schmoozerd at scriptdev2 dot com> - http://git.io/l6hJLA

Commit by machiavelli on master :: rc6b8ee7 / (11 files in 4 dirs): (link)

[11955] Remove .hover command

You can use .cast 11010 and .unaura 11010 instead

Thanks to stfx for improving patch and porting it for us :)

Signed-off-by: Schmoozerd <schmoozerd at scriptdev2 dot com> - http://git.io/wGjQFA

Commit by Machiavelli on master :: r4daafd0 / sql/updates/world/2012_04_12_05_world_command.sql : (link)

Forgot to stage SQL from my previous commit. (.hover command) - http://git.io/dRrZmA

Commit by Machiavelli on master :: r4daafd0 /sql/updates/world/2012_04_12_05_world_command.sql: (link)

 Forgot to stage SQL from my previous commit. (.hover command)
http://bit.ly/I4eTbp

Commit by Machiavelli on master :: r74b5b3b / (4 files in 3 dirs): (link)

Core/Commands: Remove recently defunct .hover command. All this spell did before hoverheight changes was .cast/.unaura spell 11010. And since we do not have .autoattack, .steadyshot, .heroicstrike, .shootwand etc. either, there's no place for this command in the core (there never was). - http://git.io/Flz5Ww

Commit by Machiavelli on master :: r74b5b3b /src/server/game/ (4 files in 3 dirs): (link)

 Core/Commands: Remove recently defunct .hover command. All this spell did before hoverheight changes was .cast/.unaura spell 11010. And since we do not have .autoattack, .steadyshot, .heroicstrike, .shootwand etc. either, there's no place for this command in the core (there never was).
http://bit.ly/I4eTb7

Commit by Machiavelli on master :: rc38820c / src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp : (link)

Scripts/Twin Valkyr: Fix a crash in spell_powering_up_SpellScript. Author: Vincent-Michael - http://git.io/Ho2ZTg

Commit by Machiavelli on master :: rc38820c /src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp: (link)

 Scripts/Twin Valkyr: Fix a crash in spell_powering_up_SpellScript. Author: Vincent-Michael
http://bit.ly/I6AaCJ

Commit by Machiavelli on master :: r9d6c8ad /src/server/ (2 files in 2 dirs): (link)

 Fix non-PCH build and GitExtensions screwup from last changeset
http://bit.ly/HACq3Y

Commit by Machiavelli on master :: rbc96df1 /src/server/ (33 files in 22 dirs): (link)

 Core/Shared: Move container functions to shared project under Trinity::Container namespace. Also implement RandomResizeList which takes a predicate function as parameter.

Core/ScriptedAI: Extend SummonList::DoAction to take a predicate function as parameter and allow specifying a maximum number of units to be selected.
http://bit.ly/HDak4I

Commit by Machiavelli on master :: re636531 /src/server/game/ (7 files in 5 dirs): (link)

 Core/Movement: Fix pushback issues and client freeze.
http://bit.ly/HACq3Q

Commit by Machiavelli on master :: re95d614 /src/server/worldserver/Master.cpp: (link)

 Core/Misc: Prevent calling ACE_Task_Base::wait() on an invalid handle. WorldSocketMgr::Wait is already called in WorldRunnable post-service hook
http://bit.ly/HDa1Xx

Commit by Machiavelli on master :: rcc0448a /src/server/game/Battlegrounds/Zones/BattlegroundSA.cpp: (link)

 Core/Battleground/SOTA: Initialize uninitialized variables.

Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0x12B542C: BattlegroundSA::FillInitialWorldStates(WorldPacket&) (BattlegroundSA.cpp:421)
==8111==    by 0xF93CD9: Player::SendInitWorldStates(unsigned int, unsigned int) (Player.cpp:9664)'

And similar.
http://bit.ly/HACalq

Commit by Machiavelli on master :: r91228d2 /src/server/game/Entities/Player/Player.cpp: (link)

 Core/Player: Similarly initialize m_SeasonalQuestChanged

Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7C42: Player::_SaveSeasonalQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19375)
==8111==    by 0xFB56BA: Player::SaveToDB(bool) (Player.cpp:18898)
http://bit.ly/HDa1Hb

Commit by Machiavelli on master :: rc3db19b /src/server/game/Entities/Player/Player.cpp: (link)

 Core/Player: Initialize m_WeeklyQuestChanged

Fixes:

==8111== Conditional jump or move depends on uninitialised value(s)
==8111==    at 0xFB7AD2: Player::_SaveWeeklyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19352)
http://bit.ly/HACa53

Commit by Machiavelli on master :: r1ee7196 /src/server/shared/Database/QueryResult.h: (link)

 Core/DB Layer: Fix helgrind errors on some concurrent access to resultset auto pointers.
Example:
==8753== Possible data race during read of size 8 at 0x2e803e60 by thread #8
==8753==    at 0xDD0FFC: PreparedResultSet::operator[](unsigned int) const (QueryResult.h:83)
==8753==    by 0x131D82D: WorldSession::HandleCharEnum(Trinity::AutoPtr<PreparedResultSet, ACE_Null_Mutex>) (CharacterHandler.cpp:217)
==8753==    by 0x118F8C3: WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1087)
{..}
==8753==  Address 0x2e803e60 is 0 bytes inside a block of size 16 alloc'd
==8753==    at 0x4C28B75: operator new(unsigned long) (vg_replace_malloc.c:261)
==8753==    by 0x137D515: __gnu_cxx::new_allocator<Field*>::allocate(unsigned long, void const*) (new_allocator.h:92)
==8753==    by 0x137D378: std::_Vector_base<Field*, std::allocator<Field*> >::_M_allocate(unsigned long) (in /home/aokromes/bin/bin/worldserver)
==8753==    by 0x137CEC6: std::vector<Field*, std::allocator<Field*> >::_M_fill_insert(__gnu_cxx::__normal_iterator<Field**, std::vector<Field*, std::allocator<Field*> > >, unsigned long, Field* const&) (vector.tcc:416)
==8753==    by 0x137CB27: std::vector<Field*, std::allocator<Field*> >::insert(__gnu_cxx::__normal_iterator<Field**, std::vector<Field*, std::allocator<Field*> > >, unsigned long, Field* const&) (stl_vector.h:944)
==8753==    by 0x137C964: std::vector<Field*, std::allocator<Field*> >::resize(unsigned long, Field*) (stl_vector.h:632)
==8753==    by 0x137BFCA: PreparedResultSet::PreparedResultSet(st_mysql_stmt*, st_mysql_res*, unsigned long, unsigned int) (QueryResult.cpp:98)
==8753==    by 0x137A12B: MySQLConnection::Query(PreparedStatement*) (MySQLConnection.cpp:493)
==8753==    by 0x137F663: PreparedStatementTask::Execute() (PreparedStatement.cpp:412)

Have a feeling this is a false positive, though. Nevertheless good to get rid of.
http://bit.ly/HAC8tY

Commit by Machiavelli on master :: r79a782f /src/server/game/World/ (World.cpp World.h): (link)

 Core/Misc: Make World::m_stopEvent thread-safe. Note that the 'virtual' keyword in C/C++ is pretty useless for multithreading
http://bit.ly/HDa064

Commit by Machiavelli on master :: r88d81d2 /src/server/shared/Database/ (DatabaseWorkerPool.h MySQLConnection.cpp): (link)

Core/DB Layer: - Fix "Thread #1 unlocked a not-locked lock at 0x6D56E90" helgrind error (thanks to Aokromes for logs). Cause was unlocking MySQL connection on shutdown, but concurrent access at this point is not required.

• Remove redundant locking in PingOperation. Since these are delayed to async threads with their own MySQL connection, no concurrent access here either.
• Codestyle cleanup
• Documentation refining http://bit.ly/HDa05W

Commit by Machiavelli on master :: rf18946a /sql/updates/world/2012_03_26_00_world_creature_template.sql: (link)

 DB/Creature Template: Some updates, mostly HoverHeight and InhabitType. Thanks to KingPin for re-parsing ~5GB of sniffs.
http://bit.ly/HD9WmO

Commit by Machiavelli on master :: re960016 /src/server/ (5 files in 3 dirs): (link)

 Partial revert of "Core/DB Layer: Fix a memory leak.", mysql library related stuff. Original memory leak fix is still in place.
http://bit.ly/HAC4Kx