Commit by andreasf on master :: r3a175eb / mplayer/CMakeLists.txt : (link)

Fix build error: spudec.c required libavutils, include path wasn't set. - http://git.io/ZC-gag

Commit by andreasf :: r39430 /haiku/trunk/src/system/boot/platform/openfirmware/arch/ppc/mmu.cpp:

boot_loader_openfirmware: Fix trace output

Update the variable name.

Commit by andreasf :: r38537 /haiku/trunk/src/system/boot/platform/openfirmware/devices.cpp:

boot_loader_openfirmware: Add iSCSI boot support

If no Haiku remote disk server is found, try an iSCSI discovery session on
the TFTP server, using the IP address from the boot command or OF options.
All available IPv4 targets are considered, Target Portal Groups are ignored.

RFC 4173 suggests a mechanism that avoids a discovery session by using DHCP;
that requires a compatibly configured DHCP server though and we wouldn't have
access to such data currently anyway. iSCSI is currently used as fallback,
and when it doesn't succeed it falls back to the menu as before.

Resolves ticket #5319.

Commit by andreasf :: r38536 /haiku/trunk/ (4 files in 3 dirs):

boot_net: Add iSCSI initiator support

Add support for both discovery and regular iSCSI sessions. Command and status
sequence numbers do differentiate between session and connection but only
one connection per session is currently supported.

Code is Big Endian for now, so compile it for ppc only.

Based on RFC 3720 ff. Tested against OpenSolaris 2009.06.

Resolves most of ticket #5319.

Commit by andreasf :: r38535 /haiku/trunk/src/system/boot/loader/net/TCP.cpp:

boot_net: Various TCP fixes

Don't enqueue a packet whose sequence number matches the first one in queue
or is between the next and the acknowledged on. This would lead to packet
duplication in the queue and leftovers after dequeuing.

Optimize calculation of acknowledgement number for out-of-order reception.
If a single missing packet arrived, this could have resulted in a timeout
depending on the window size.

In case the connection is closed, do dequeue remaining packets. This would
have caused a read error after a unidirectional FIN.

Prepare a dynamic window size calculation.

Do checksum calculation before attempting to trace packet contents. I have
seen a few and couldn't spot an error in the checksum calculation.

More fine-grained control over trace output.
Trace the Maximum Segment Size option if present; break after End of Options.

Commit by andreasf :: r38530 /haiku/trunk/ (2 files in 2 dirs):

boot_net: Prepare socket-specific TCP window size

Pass the desired window size from the socket to the service.

Commit by andreasf :: r38529 /haiku/trunk/src/system/boot/loader/net/ (TCP.cpp UDP.cpp):

boot_net: TCP and UDP style cleanup

Remove superfluous comments.
Adjust spacing and initializer indentation.
Make NULL pointer checks explicit.
Don't assign in if-clause.

Commit by andreasf :: r38528 /haiku/trunk/headers/private/drivers/iscsi_cmds.h:

iSCSI: Add header for protocol

Define structs for iSCSI messages, to be used by boot loader and kernel add-on.
For now it will refuse to compile for Little Endian systems (e.g., x86).

Commit by andreasf :: r38503 /haiku/trunk/src/system/boot/loader/net/TCP.cpp:

boot_net: Fix TCP memory leaks

In some error conditions the packet would have been leaked.

Commit by andreasf :: r38485 /haiku/trunk/src/system/boot/loader/net/ (Jamfile NetStack.cpp):

boot_net: Disable TCP for all archs but ppc

Unbreaks the build until a better solution is found.

Commit by andreasf :: r38483 /haiku/trunk/src/system/boot/loader/net/TCP.cpp:

boot_net: Mute some TCP debug output

Trace packet dequeing only when asked to.

Commit by andreasf :: r38482 /haiku/trunk/src/system/boot/loader/net/TCP.cpp:

boot_net: Use real_time_clock_usecs() for TCP

Initialize the PRNG seed for the sequence number with real_time_clock_usecs()
rather than system_time(). The remaining uses of system_time() for timeout
calculation match UDP.

Commit by andreasf :: r38481 /haiku/trunk/src/system/boot/platform/openfirmware/ (3 files):

boot_loader_openfirmware: Implement real_time_clock_usecs()

Partially revert r38465 and move the code from system_time() into a new
real_time_clock_usecs() function. The system_time() implementation was correct
in relying on of_milliseconds(), as pointed out by Axel. Add the correct
function for the desired functionality.

Commit by andreasf :: r38480 /haiku/trunk/src/system/boot/platform/openfirmware/real_time_clock.h:

boot_loader_openfirmware: Style cleanup

Fix coding style issues and bump copyright (although there's not much anyway).

No functional changes.

Commit by andreasf :: r38472 /haiku/trunk/ (7 files in 2 dirs):

boot_net: Add TCP support

Modelled after UDP, add limited TCP support to the boot net stack. The socket
works by queuing received packets as well as sent packets that have not yet
been ACK'ed. Some known issues are documented, especially there's only limited
congestion control. I.e., we send immediately and in unlimited quantity, thus
its use should be restricted to local networks, and due to a fixed window size
there is potential for our socket being overrun with data packets before they
are read. Some corner cases like wrapping sequence numbers may cause a timeout.

The TCP implementation is based on Andrew S. Tanenbaum's "Computer Networks",
4th ed., as well as lecture notes from Prof. W. Effelsberg, the relevant RFCs
and Wikipedia. The pseudo-random number Galois LFSR used for the sequence
number was suggested by Endre Varga.

Since the code is unlikely to get much smaller, better merge it now so that
subsequent changes get easier to review. No platform actively uses TCP sockets
yet, and the receiving code has been reviewed for endianness issues and should
terminate okay after verifying the checksum if no sockets are open.
Based on a version tested with custom code (#5240) as well as with iSCSI.
Compile-tested boot_loader_openfirmware, pxehaiku-loader with gcc4 and
haiku_loader with gcc2. Closes ticket #5240.

Changes from #5240 proposed patch:

• Various bug fixes related to queuing, some memory leaks fixed.
• Never bump the sequence number when dequeuing a packet. It's done afterwards.
• Don't bump the sequence number again when resending the queue or ACK'ing.
• Aggressively ACK while waiting for packets.
• Don't queue sent ACK-only packets.
• More trace output, esp. for queue inspection.
• Adapted use of TCP header flags to r38434.

Commit by andreasf :: r38465 /haiku/trunk/src/system/boot/platform/openfirmware/ (3 files):

boot_loader_openfirmware: Fix system_time()

system_time() was based on of_milliseconds(), which returns the number of
milliseconds since power-on. This would produce very similar or identical
results for subsequent boots due to limited clock resolution; therefore it
was unsuited as PRNG seed, e.g., for TCP ports.

Try to inquire the RTC device node with get-time to return an improved time
value, if possible.

Closes ticket #6061.

Changes from proposed patch:

• Obtain the RTC handle once and reuse it for each inquiry.

Commit by andreasf :: r38456 /haiku/trunk/headers/private/kernel/boot/net/NetDefs.h:

boot net: Style fixes

Fix style issue, pointed out by Axel.

No functional changes.

Commit by andreasf :: r38434 /haiku/trunk/headers/private/kernel/boot/net/NetDefs.h:

boot net: Preparations for TCP

Add protocol number and struct for TCP header.

First minuscule part of ticket #5240.
Checked that pxehaiku_loader still compiles, too.

Changes from proposed patch:

• Simplify struct by merging flags into one 8-bit field.

Commit by andreasf :: r38431 /haiku/trunk/headers/private/kernel/boot/net/NetDefs.h:

boot net: Style fixes

No functional changes yet.

Commit by andreasf :: r38425 /haiku/trunk/headers/private/drivers/scsi_cmds.h:

SCSI: Add struct for READ (16) and WRITE (16) commands

Based on a SCSI Command Reference Manual by Seagate and Wikipedia.

Tested against OpenSolaris iSCSI target on ppc. It choked on the READ (12) opcode.