Commit by aturner :: r847793 amarok/trunk/extragear/multimedia/amarok/src/playlist/PlaylistModel.cpp:

When tracks are dragged from the Collection Browser to the Playlist, ensure they are sorted before being added.

Commit by aturner :: r847668 amarok/trunk/extragear/multimedia/amarok/src/browsers/collectionbrowser/ (2 files):

Code duplication--

Commit by aturner :: r847641 amarok/trunk/extragear/multimedia/amarok/src/browsers/collectionbrowser/CollectionTreeView.cpp:

Fix bug introduced in r847552: dragging an album and a track from it from the Collection Browser to the central pane Append/Load icons no longer appends the album twice.

Commit by aturner :: r847552 amarok/trunk/extragear/multimedia/amarok/src/browsers/collectionbrowser/ (4 files):

Use AmarokMimeData to do the work when dropping items from the Collection Browser onto the Append or Load symbols in the central pane. This reduces code duplication and fixes a bug where if multiple items were selected and dropped, the tracks would not be sorted properly when added to the playlist.

Commit by aturner :: r845354 amarok/trunk/extragear/multimedia/amarok/src/ (3 files):

Pass parent as arguments to created menu items so that they get deleted eventually.

Commit by aturner :: r845349 amarok/trunk/extragear/multimedia/amarok/src/dialogs/ (ScriptManager.cpp ScriptManager.h):

Make the gui a member of the ScriptManager and delete it in the destructor (rather than leaking memory as before).

Commit by aturner :: r628891 amarok/trunk/extragear/multimedia/amarok/src/magnatunebrowser/magnatuneredownloadhandler.cpp:

Small grammar fix to one of the strings only i18n'd an hour ago. Again, many apologies.

CCMAIL: kde-i18n-doc at kde dot org

Commit by aturner :: r626709 amarok/trunk/extragear/multimedia/amarok/src/devicemanager.cpp:

Given we've just emitted a signal containing a pointer, let's be safe and let that signal
propogate before we delete the object pointed to.

Commit by aturner :: r626699 amarok/trunk/extragear/multimedia/amarok/src/devicemanager.cpp:

In mediumRemoved, we actually remove the Medium from the mediumMap. Before this happens, we ought to delete the Medium as nobody else will.

Commit by aturner :: r625936 amarok/trunk/extragear/multimedia/amarok/src/metadata/wav/wavproperties.cpp:

Potential fix for Stack Smashing Protection problems with WAV files.

Commit by aturner :: r625733 amarok/trunk/extragear/multimedia/amarok/src/devicemanager.cpp:

Some small tweaks to the DeviceManager:

• Fix the new destructor so it doesn't dereference what it's just removed
• Make sure that the pointers returned by getDevice are not invalidated unnecessarily (instead of deleting and then recreating the Medium, we just copy over it)
• Add a small warning if we ever get devices left in the m_mediumMap that should have been removed
• Removed tabs

Commit by aturner :: r625235 amarok/trunk/extragear/multimedia/amarok/src/ (2 files):

Make the caching of the selected item and top item in the viewport in the Collection Browser more rigorous by storing the names of the parents too, so as to fully identify the item in question.

Commit by aturner :: r625199 amarok/trunk/extragear/multimedia/amarok/src/collectiondb.cpp:

Ugliness--
SVN_SILENT

Commit by aturner :: r625197 amarok/trunk/extragear/multimedia/amarok/src/collectiondb.cpp:

Make sure we use the cache for directory cover images, if present (rather than regenerating the cached file every time).

Commit by aturner :: r622479 amarok/trunk/extragear/multimedia/amarok/src/collectionbrowser.cpp:

Expand more items when you search. I think this is nicer if you don't quite know what you
are looking for.

Commit by aturner :: r622351 amarok/trunk/extragear/multimedia/amarok/src/ (3 files):

More general form of the fix to stop non-renameable items in the Playlist Browser appearing to be renameable when clicking on them twice (slowly). Suggested by Seb.

Commit by aturner :: r622182 amarok/trunk/extragear/multimedia/amarok/src/playlistbrowser.cpp:

Remove the apparent ability to rename Cool Streams (and the folder) by clicking on them twice.

Commit by aturner :: r622151 amarok/trunk/extragear/multimedia/amarok/src/ (3 files):

Revert to the previous Collection Browser look of displaying covers in the given icon spaces, for albums only. This reverts the following commits: 616254 618301 619976 , of which two are by me and one by jefferai.

Commit by aturner :: r621806 amarok/trunk/extragear/multimedia/amarok/src/collectionbrowser.cpp:

If you search for a song in the Collection Browser and you find just one song, select it, rather than the whole album.

Commit by aturner :: r621691 amarok/trunk/extragear/multimedia/amarok/src/tracktooltip.cpp:

Limit score display in track tooltip (of tray icon) to 2 decimal places. It was using 6
for me. Even 2dp still seems a bit excessive.