Commit by benjamin.peterson on roundup :: #13193/packaging.tests.test_manifest and distutils.tests.test_filelist failures: (link)

Apply!

Commit by benjamin.peterson on roundup :: #13703/Hash collision security issue: (link)

So modulo my (small) review comments, David's patches are ready to go in.

Commit by benjamin.peterson on roundup :: #13970/frameobject should not have f_yieldfrom attribute: (link)

I agree, FWIW.

Commit by benjamin.peterson on roundup :: #13897/Move fields relevant to coroutine/generators out of frame into generator/threadstate: (link)

Extensions modules should really be using PyErr_Occurred/Fetch etc.

Commit by benjamin.peterson on roundup :: #13703/Hash collision security issue: (link)

I think we don't need to mess with tests in 2.6/3.1, but everything should pass under 2.7 and 3.2.

Commit by benjamin.peterson on roundup :: #13703/Hash collision security issue: (link)

For the record, Barry and I agreed on what we'll be doing for stable releases [1]. David says he should have a patch soon.

 [1] http://mail.pyth ...

Commit by benjamin.peterson on roundup :: #13885/CVE-2011-3389: _ssl module always disables the CBC IV attack countermeasure: (link)

Thank you for handling this, Antoine!

Commit by benjamin.peterson on roundup :: #13832/tokenization assuming ASCII whitespace; missing multiline case: (link)

$ ./python
 Python 3.3.0a0 (default:50a4af2ca654+, Jan 20 2012, 10:59:48)
 [GCC 4.5.3] on linux
 Type "help", "copyright", "credits" or "license ...

Commit by benjamin.peterson on roundup :: #13405/Add DTrace probes: (link)

As great as a tool it maybe, it's still only available on a minority platform. So I couldn't really try it.

Commit by benjamin.peterson on roundup :: #13405/Add DTrace probes: (link)

I'm -1 on this patch for essentially the same reasons as Charles-François. It introduces a lot of code (and hacks!) in critical pathways of the i ...

Commit by benjamin.peterson on roundup :: #13828/Further improve casefold documentation: (link)

It's a bit unfriendly to launch into discussion of "compatiblity caseless matching" when the new reader probably has no idea what "compatibility-e ...

Commit by benjamin.peterson on roundup :: #13832/tokenization assuming ASCII whitespace; missing multiline case: (link)

[closed] The tokenizer doesn't consider unicode spaces, either.

Commit by benjamin.peterson on roundup :: #13827/Unexecuted import changes namespace: (link)

[closed] Not a bug. Basically, import is an explicit assignment statement.

Commit by benjamin.peterson on roundup :: #13822/is(upper/lower/title) are not exactly correct: (link)

[new] The isupper() and islower() methods currently use the Lowercase and Uppercase derived properties. Technically, they should use the Changes_W ...

Commit by benjamin.peterson on roundup :: #13821/misleading return from isidentifier: (link)

2012/1/18 Jim Jewett <report at bugs dot python dot org>: > > Jim Jewett <jimjjewett at gmail dot com> added the comment: > > @Benjamin -- the catch is, if it isn't ...

Commit by benjamin.peterson on roundup :: #13821/misleading return from isidentifier: (link)

2012/1/18 Jim Jewett <report at bugs dot python dot org>: > > Jim Jewett <jimjjewett at gmail dot com> added the comment: > > My preference would be for non_NFKC.is ...

Commit by benjamin.peterson on roundup :: #13821/misleading return from isidentifier: (link)

I don't see why that's invalid. "str.isidentifier()" returning True means Python will accept it as an identifier.

Commit by benjamin.peterson on roundup :: #13793/hasattr, delattr, getattr fail with unnormalized names: (link)

Because it's (very) expensive and the method you propose would fail in the case that someone had put the normalized and unnormalized string in the ...

Commit by benjamin.peterson on roundup :: #13801/The Python 3 Docs don't highlight nonlocal: (link)

The problem was until very recently, pygments omitted the nonlocal keyword. We probably need to wait for another pygments release.

Commit by benjamin.peterson on roundup :: #12705/Make compile('1\n2\n', '', 'single') raise an exception instead of silently truncating?: (link)

I think an exception is fine, but it should only happen in 3.3.