Commit by benjamin.peterson on roundup :: #14133/improved PEP 409 implementation: (link)

2012/5/15 Georg Brandl <report at bugs dot python dot org>: > > Georg Brandl <georg at python dot org> added the comment: > > I hope you're not disappointed when th ...

Commit by benjamin.peterson on roundup :: #14133/improved PEP 409 implementation: (link)

[closed] Thanks for the review/dictating, Nick!

Commit by benjamin.peterson on roundup :: #13734/Add a generic directory walker method to avoid symlink attacks: (link)

2012/5/12 Charles-François Natali <report at bugs dot python dot org>: > > Charles-François Natali <neologix at free dot fr> added the comment: > >> It would be n ...

Commit by benjamin.peterson on roundup :: #12029/Catching virtual subclasses in except clauses: (link)

Basically, someone needs to produce a patch and we can go from there.

Commit by benjamin.peterson on roundup :: #12029/Catching virtual subclasses in except clauses: (link)

I think being able to catch exception with ABCs is esssentially useless. The originally stated "usecase" can be simply solved by putting classes i ...

Commit by benjamin.peterson on roundup :: #13734/Add a generic directory walker method to avoid symlink attacks: (link)

It would be nice if the documentation of fwalk() explained why you would want to use it over walk().

Commit by benjamin.peterson on roundup :: #14769/Add test to automatically detect missing format units in skipitem(): (link)

Can you see if you can write that test in Python? Perhaps simply providing a wrapper to cal PyArg_Parse with the arguments you want.

Commit by benjamin.peterson on roundup :: #14749/Add 'Z' to skipitem() in Python/getargs.c: (link)

No test?

Commit by benjamin.peterson on roundup :: #14705/Add 'bool' format character to PyArg_ParseTuple*: (link)

Since no one has produced a good example needing "P", I say drop it. At any rate, it can be almost trivially imitated with "O!".

Commit by benjamin.peterson on roundup :: #14718/In the generator's try/finally statement a runtime error occurs when the generator is not exhausted: (link)

[closed] It means in the body of the try statement.

Commit by benjamin.peterson on roundup :: #14656/Add a macro for unreachable code: (link)

It does not avoid any warning because we have the "assert(0); return X" pattern. I was just attempting to provide a standard way of marking unreac ...

Commit by benjamin.peterson on roundup :: #13959/Re-implement parts of imp in pure Python: (link)

Windows is currently failing test_imp:

 http://www.python.org/dev/buildbot/all/builders/x86%20XP-5%203.x/builds/214/steps/test/logs/stdio

Commit by benjamin.peterson on roundup :: #14656/Add a macro for unreachable code: (link)

Did you see the sample patch I posted?

Commit by benjamin.peterson on roundup :: #14682/Backport missing errnos to 2.7: (link)

I think it's okay to just backport ENOTSUP.

Commit by benjamin.peterson on roundup :: #14671/isinstance(obj, object) returns True for _old style_ class instances: (link)

2012/4/26 Q <report at bugs dot python dot org>: > issubclass(obj.__class__, object) > > to be the official way to distinguish between the new-style and the ...

Commit by benjamin.peterson on roundup :: #14621/Hash function is not randomized properly: (link)

We should see if more security can be gained without sacrificing speed.

Commit by benjamin.peterson on roundup :: #10142/Support for SEEK_HOLE/SEEK_DATA: (link)

You broke test_io

 www.python.org/dev/buildbot/all/builders/x86 Gentoo Non-Debug 3.x/builds/2143/steps/test/logs/stdio

Commit by benjamin.peterson on roundup :: #14671/isinstance(obj, object) returns True for _old style_ class instances: (link)

[closed] Yes, everything is a object. issubclass, though, works differently for old-style and new-style classes.

Commit by benjamin.peterson on roundup :: #14656/Add a macro for unreachable code: (link)

Let me explain what I meant with code.

Commit by benjamin.peterson on roundup :: #11603/Python crashes or hangs when rebinding __repr__ as __str__: (link)

I claim the correct behavior of this is actually to give an recursion provoked RuntimeError.