Commit by coates :: r1283239 killbots/trunk/KDE/ (83 files in 5 dirs): (link)

Update my email address.

It turns out several headers were using an incorrect, non-existent
address, so it's a good thing I decided to do this.

Commit by coates :: r1281294 kpat/trunk/KDE/kdegames/kpat/ (soundengine.cpp soundengine.h): (link)

Port from Phonon to KgSound.

Well, that was really easy.

Commit by coates :: r1281292 kpat/trunk/KDE/kdegames/kpat/libkcardgame/kcardscene.cpp: (link)

Add some checks for nonexistant source piles.

Commit by coates :: r1281293 libkdegames/trunk/KDE/kdegames/libkdegames/includes/ (KgAudioScene KgSound): (link)

Fix camelcase audio forwarding includes.

Commit by coates :: r1281291 kpat/trunk/KDE/kdegames/kpat/ (dealer.cpp dealer.h): (link)

Replace pointers to QTimers with QTimers within DealerScene.

Interestingly, this caused a compile error in startSolver() as that
method had been declared const. Why it was, I have no idea, but I'm
somewhat surprised that this was even compiling before.

Commit by coates :: r1281290 kpat/trunk/KDE/kdegames/kpat/ (dealer.cpp dealer.h): (link)

Get rid of DealerScenePrivate.

I don't know why DealerScene had a d-pointer, but it bugged me that it
was the only class in KPat that did. Getting rid of it just simplifies
the code that much further.

I also renamed a few variables when I moved them into DealerScene, just
to make their purposes a bit more obvious or to make them consistent
with changes in implementation of terminology.

Lastly, member variable initialisations have been moved into an
initialisation list.

Commit by coates :: r1281019 libkdegames/trunk/KDE/kdegames/libkdegames/ (CMakeLists.txt pics/): (link)

Remove the unused libkdegames/pics/star.png file.

We've been installing this file for a long, long time, but nobody uses
it anymore.

BUG:287544

Commit by coates :: r1281014 libkdegames/trunk/KDE/kdegames/libkdegames/carddecks/ (CMakeLists.txt decks/): (link)

Remove the libkdegames/carddecks/decks directory.

Separate card backsides are no longer used anywhere in KDEGames!

Commit by coates :: r1281012 lskat/trunk/KDE/kdegames/lskat/src/ (13 files in 2 dirs): (link)

Remove support for loading separate card backs from LSkat.

With this functionality gone from LSkat, we can now safely get rid of
the libkdegames/carddecks/decks directory.

Commit by coates :: r1281011 lskat/trunk/KDE/kdegames/lskat/src/fromlibkdegames/ (6 files): (link)

Remove support for PNG carddecks from LSkat.

We haven't had PNG decks for several releases, so we might as well get
rid of support for loading them.

Commit by coates :: r1280805 libkdegames/ (29 files in 5 dirs): (link)

Move KCardCache, KCardDeckInfo and KCardDialog into LSkat tree.

These classes are currently only used within LSkat and will be
deprecated by libkcardgame, so we can safely move them into the lskat
sources as part of the ongoing libkdegames API clean up.

Commit by coates :: r1280799 /trunk/playground/games/ (CMakeLists.txt kscoremanager/): (link)

Remove KScoreManager.

It can now be found at git at git dot kde dot org:scratch/coates/kscoremanager.git

Majewsky's KScore2 library is much more likely to be used in the near
future, so KScoreManager is likely a dead end project, but I thought
I'd keep the code around for reference's sake.

I also took this as an opportunity to play around with writing svn2git
conversion rules and setting up scratch git repos.

CCMAIL:matt at milliams dot com
CCMAIL:dimsuz at gmail dot com

Commit by coates :: r1280181 kpat/trunk/KDE/kdegames/kpat/mainwindow.cpp: (link)

Fix loading files via KIO.

I'm not sure how long this has been broken, but loading remote files now
works correctly.

Commit by coates :: r1280179 kpat/trunk/KDE/kdegames/kpat/ (5 files in 2 dirs): (link)

Rename things to make it clear that the old format is a legacy format.

Commit by coates :: r1280180 kpat/trunk/KDE/kdegames/kpat/mainwindow.cpp: (link)

Clean up MainWindow::saveGame().

Commit by coates :: r1280178 kpat/trunk/KDE/kdegames/kpat/dealer.cpp: (link)

Allow autodropping only when the redo stack is empty.

If there are states in the redo stack, there's a pretty good chance
that the user would like to keep them, but autodropping would replace
them with a trivial move. This isn't an issue in normal play, but can
come up when the user plays with autodrop disabled, misses some drops,
enables autodrop and then undoes back a few states.

Commit by coates :: r1280177 kpat/trunk/KDE/kdegames/kpat/ (3 files in 2 dirs): (link)

Swap the argument order in KCardPile::insert() to match QList::insert().

Commit by coates :: r1280176 kpat/trunk/KDE/kdegames/kpat/libkcardgame/kcardpile.cpp: (link)

Remove an overly strict assertion from KCardPile::insert().

Since QList::insert() properly prepends with negative indices and
properly appends with indices greater than size(), there's no need for
us to assert the index is within the range of "valid" indices.

Commit by coates :: r1280174 kpat/trunk/KDE/kdegames/kpat/dealer.cpp: (link)

Only write the game-specific-state attribute when if changes.

This just produces shorter, more readable saves.

Commit by coates :: r1280175 kpat/trunk/KDE/kdegames/kpat/mainwindow.cpp: (link)

Use new save format for "Remember State on Exit" functionality.

FEATURE:291959
FIXED-IN:SC4.9