Commit by trowbrds :: r2136 /wiki/Google_CodeIn_Ideas.wiki: (link)

Edited wiki page Google_CodeIn_Ideas through web user interface.

Commit by trowbrds :: r2135 /wiki/Google_CodeIn_Ideas.wiki: (link)

Created wiki page through web user interface.

Commit by davidtrowbridge :: r131 /trunk/libview/libview/fieldEntry.cc: (link)

Ignore tab characters in pasted text inside FieldEntry.

It's possible that users could copy a tab character at the beginning of the text
that they're trying to paste into our FieldEntry. Our code coped with tabs at
the end, but not at the beginning. This fixes it to just strip tab characters
out of the input, which should make things work pretty well no matter what.

Commit by trowbrds :: r2125 /wiki/Roadmap.wiki: (link)

Tweak maybe-features

Commit by trowbrds :: r2122 /wiki/Roadmap.wiki: (link)

Pull in more things from the issues list into the maybe features section

Commit by trowbrds :: r2121 /wiki/Roadmap.wiki: (link)

Django 1.1 didn't release in the future.

Commit by trowbrds :: r2120 /wiki/Eliminating_YUIExt.wiki: (link)

Deleting wiki page Eliminating_YUIExt.

Commit by trowbrds :: r2119 /wiki/Roadmap.wiki: (link)

Update everything for 1.1. We'll probably add more and tweak the dates, but this is a good start.

Commit by trowbrds :: r2105 /branches/reviewboard/1.0.x/accounts/backends.py: (link)

On-demand imports for crypt and nis in account backends.

Patch from Thilo-Alexander Ginkel. The crypt and nis modules are not available
under Windows, but were imported unconditionally, so that using custom backends
under Windows failed. This patch should fix this by performing the imports
only when needed.

Fixes bug 1244.
Reviewed at http://reviews.review-board.org/r/976/

Commit by trowbrds :: r2104 /trunk/reviewboard/accounts/backends.py: (link)

On-demand imports for crypt and nis in account backends.

Patch from Thilo-Alexander Ginkel. The crypt and nis modules are not available
under Windows, but were imported unconditionally, so that using custom backends
under Windows failed. This patch should fix this by performing the imports
only when needed.

Fixes bug 1244.
Reviewed at http://reviews.review-board.org/r/976/

Commit by trowbrds :: r2071 /trunk/reviewboard/AUTHORS: (link)

Add a couple more AUTHORS from my previous commits. This brings the total to 124.

Commit by trowbrds :: r2070 /trunk/rbtools/rbtools/postreview.py: (link)

A variety of hgsubversion improvements

Corrected hgsubversion support for more recent versions of hgsubversion and add
support for parent branch, guess summary, and guess description. Patch from
Augie Fackler.

Testing done:
Been using it for over a week, haven't seen any major issues.

Reviewed at http://reviews.review-board.org/r/842/

Commit by trowbrds :: r2068 /trunk/reviewboard/reviews/models.py: (link)

Don't clobber branch/testing done/bugs if changesets don't have them.

A few people are using perforce but don't have VMware's fancy changeset
descriptions, so their testing done and bugs fields were getting clobbered when
they updated the diff. This isn't really nice of us.

This change fixes update_obj_with_changenum to only clobber those fields if the
changeset has them present.

Fixes bug 777.

Commit by trowbrds :: r2067 /trunk/reviewboard/contrib/tools/post-commit: (link)

Allow post-commit to recognize reviewboard URLs without a trailing slash.

This is a trivial change for the post-commit hook that lets it still work if the
URL in the commit message lacks a trailing slash.  I came across this when some
of my users would put something like this in the commit message:

    Review: http://REVIEWBOARD_URL/r/123

instead of

    Review: http://REVIEWBOARD_URL/r/123/

Testing done:
This change has been in use on my install for a while and is working as
expected.

Patc

Commit by trowbrds :: r2066 /trunk/reviewboard/diffviewer/forms.py: (link)

Fix bug with Mercurial parent diffs when the parent diff includes a binary file

The output of the "hg diff" command is not very helpful when it comes to binary
files; in particular it reports a binary file as having been changed even if it
has actually been added.

Because of this, ReviewBoard will check for the existence of the new file in the
parent revision, and throw an exception because it can't find it.

This patch disables checking for file existence for binary files altogether in
the di

Commit by trowbrds :: r2065 /trunk/rbtools/rbtools/postreview.py: (link)

Perforce binary file diff corruption fix.

When a binary file differed, post-review would miss printing a newline after
"Binary Files differ", making the diff invalid for the subsequent file. This
would cause that file's diff to be lost silently when parsed by reviewboard on
the server side. Patch from Chris Trimble.

Reviewed at http://reviews.review-board.org/r/915/

Commit by trowbrds :: r2064 /trunk/reviewboard/ (3 files in 2 dirs): (link)

JSON api to update the change number of a review request

Add JSON api to allow updating the change number of a review request.
Server-side support for issue 294. Patch from Nathan Auch.

Reviewed at http://reviews.review-board.org/r/931/

Commit by trowbrds :: r2063 /trunk/reviewboard/scmtools/ (git.py mtn.py): (link)

Fix git and mtn executable checks.

Copy and paste error -- we were checking for cvs for both git and mtn. Patch
from Dan Savilonis.

Reviewed at http://reviews.review-board.org/r/934/diff/

Commit by trowbrds :: r2062 /trunk/reviewboard/reviews/forms.py: (link)

Make sure we don't delete a review request and then save it.

A couple of the error paths in NewReviewRequestForm.create would delete the
target review request and then immediately try to save it. These should have
instead raised an exception.

Fixes bug 781.

Commit by trowbrds :: r2061 /trunk/reviewboard/scmtools/forms.py: (link)

Add some help_text to the path in the Repository admin.

This is a pretty simple change to add some help_text to the Repository form in
the admin UI which explains what the path means. In particular, it points out
that for Git repositories, it should be the path to the .git directory on the
local disk.

This addresses bug 1160.