Commit by debian on piatti :: r244fd61 piuparts/ (debian/changelog piuparts.py):

 report leftover directories with trailing slash

This allows to visually distinguish files and dirs for better
bug reporting.

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: rc021416 piuparts/ (debian/changelog piuparts.py):

 report leftover symlinks with target

improve visual classification of the leftover files

  /path/to/foo -> ../bar  (not) owned (by: pkg)

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: rc39c32a piuparts/ (debian/changelog piuparts-analyze.py):

p-analyze: skip further bugs/versions if we found a match

• shortcut the evaluation of further bugs once we found a match
• check for a matching version before reporting older versions Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: rbc1e138 piuparts/piuparts-report.py:

 p-r: revert indenting change from c91096b

turn
  if condition:
    block
into
  if not condition:
    return
  block

(to avoid unrelated merge problems later on)

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r23012db piuparts/piuparts.py:

Remove obsolete functions shellquote, apt_get_knows and append_to_file

Commit by debian on piatti :: rab038a5 piuparts/ (6 files in 2 dirs):

 remove known_circular_depends from piuparts.conf

as well as circular-depends-*.txt that was used to generate them

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: re144d01 piuparts/ (3 files in 3 dirs):

 exclude obsolete states from report

we can't remove them completely as that would break the historical
data that is used to generate the plots

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: rab594a7 piuparts/ (5 files in 3 dirs):

 remove known_circular_depends from piuparts.conf handling

since circular dependencies are computed automatically,
we no longer need to handle them in the config file

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: rea8e262 piuparts/ (2 files in 2 dirs):

 compute and automatically break dependency cycles

stop relying on known_circular_depends which require regular manual updates

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r33f196d piuparts/piupartslib/packagesdb.py:

 add get_dependency_cycle method

PackagesDB._get_dependency_cycle(self, package)
returns the dependency cycles(s) that contain the given package,
including the package, or [] if the package is not on a cycle

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: raf49751 piuparts/piupartslib/packagesdb.py:

 factor out the list of 'good' states

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r7411ea7 piuparts/piupartslib/packagesdb.py:

 simplify deciding testability of circular deps

no need to handle dependencies in error state when checking
circular deps - already covered by error propagation

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: raff1d2c piuparts/piupartslib/packagesdb.py:

 cache package.dependencies()

do not recompute package.dependencies() for every loop

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r19eeda3 piuparts/piupartslib/packagesdb.py:

 propagate error and waiting states separately

propagate waiting states after handling circular dependencies
as in some corner cases this could result in cycles waiting for itself

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: rf686545 piuparts/piupartslib/packagesdb.py:

 fix waiting-to-be-tested for known circular deps

fix logic error (a package can have multiple deps that are circular deps,
in that case none of them may have failed or we can't test the package)
cleanup/simplify, don't abuse strings as booleans

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: reba4350 piuparts/piupartslib/packagesdb.py:

 cleanup computation of waiting-to-be-tested state

do not abuse strings as booleans

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: reefb6d8 piuparts/ (2 files in 2 dirs):

 drop circular-dependency state

we will compute and break the cycles ourselves so that we don't need to
maintain known_circular_depends manually any longer

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r8618279 piuparts/piupartslib/packagesdb.py:

 defer propagation of failures while resolving alternatives

do not inherit failures when resolving alternate dependencies,
this will be done later anyway

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r6c93448 piuparts/ (2 files in 2 dirs):

 always update preferred alternative

Update the preferred alternative even if we only select a package
in "waiting-*"/"unknown" state.
That way the subsequent checks may work on better (non-failed)
alternatives and circular dependencies involving virtual depends
and alternative depends can be resolved.
Keeping the 'unknown' state asks for a later revisit after some
of the unknown alternative deps may have been resolved.

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>

Commit by debian on piatti :: r09310ee piuparts/ (2 files in 2 dirs):

 remove 'unknown-preferred-alternative' state

Remove 'unknown-preferred-alternative' state as it interferes with
circular dependencies involving alternatives and virtual packages.
Setting 'unknown-preferred-alternative' usually happened on the
full circle and skipped the special handling of known circular
depends, so the package never got a change to be tested.
Now these packages will be just tracked as 'unknown'.

Signed-off-by: Andreas Beckmann <debian at abeckmann dot de>