CIA.vc
dhollowa@chromium.org
Real-time open source activity stats
Stats » Authors » dhollowa@chromium.org
informationsyndicateUTC clock
12:05 on Feb 13, 2012
event counters
The last message was received 8.35 months ago at 21:52 on Jun 07, 2011
0 messages so far today, 0 messages yesterday
0 messages so far this week, 0 messages last week
0 messages so far this month, 0 messages last month
385 messages since the first one, 2 years ago, for an average of 1.9 days between messages
recent messages
dateReversed sort columnprojectcontentlink
21:25 on Jun 07, 2011Chromium
Commit by dhollowa@chromium.org :: r88207 /trunk/src/chrome/renderer/autofill/ (2 files):
Heuristics for grabber-google.com.out

Changes Autofill inferred labels code to filter out <noscript> elements.

BUG=76302
TEST=FormStructureBrowserTest.DataDrivenHeuristics, FormManagerTest.LabelsInferredFromTableWithSpecialElements

Review URL: http://codereview.chromium.org/7044032
#
21:56 on May 25, 2011Chromium
Commit by dhollowa@chromium.org :: r86717 /trunk/src/chrome/browser/autofill/ (7 files):
Heuristics for grabber-continental.com.out (select-one)

Adds specific input types to the field_type.h bitfield to utilize the "select-one" signal in identifying the Country, State, and Credit Card date fields. Other fields should not classify now if the input type is "select-one".

This is Phase 1 of fixes for the grabber-continental.com.html. Phase 2 will add lookahead logic for the "BusinessPhone" and "Email Address" issues.

BUG=76299
TEST=FormStructureBrowserTest.DataDrivenHeuristics with test file grabber-continental.com.html

Review URL: http://codereview.chromium.org/7063031
#
23:42 on May 19, 2011Chromium
Commit by dhollowa@chromium.org :: r86016 /trunk/src/chrome/ (20 files in 2 dirs):
Autofill refactor form_field.h/cc.

1. Moves FormField methods into proper public/protected/private visibility.
2. Eliminates redundant "Parse" methods.
3. Introduces |MatchType| bit field to simplify variant matching.
4. Consolidates |Match| method.
5. Renames |Add| and |GetFieldInfo| to |AddClassification| and |ClassifyField| respectively.
6. Move ECML logic into separate file.

BUG=none
TEST=Unit tests in autofill/*_field_unittest.cc.

Review URL: http://codereview.chromium.org/7043027
#
15:52 on May 16, 2011Chromium
Commit by dhollowa@chromium.org :: r85489 /trunk/src/chrome/ (4 files in 3 dirs):
Autofill should reject aggregated profiles where email address is found in non-email fields

Adds code to reject import of profiles and credit cards that have email address data in non-email fields.

BUG=77113
TEST=AutofillMergeTest.DataDrivenMergeProfiles with email.in and email.out.

Review URL: http://codereview.chromium.org/7013016
#
18:54 on May 09, 2011Chromium
Commit by dhollowa@chromium.org :: r84654 /trunk/src/chrome/browser/autofill/autofill_resources.grd:
Change ZIP and last name heuristic pattern.

In ZIP heuristic patter, there is "cp". But it is too short and it matches first/last name fiels. So I change it to "^cp$".
"secondname" was a specified as last name. So I added.

BUG=76332,76331
TEST=1, put yahoo and super shuttle grabber input files. 2.run browser_tests --gtest_filter=*.DataDrivenHeuristics and see the inferred results.

Review URL: http://codereview.chromium.org/6954010
#
00:52 on May 07, 2011Chromium
Commit by dhollowa@chromium.org :: r84535 /trunk/src/tools/valgrind/memcheck/suppressions.txt:
Valgrind reports issues in icu::RegexMatcher

Adds suppression for icu RegexMatcher, triggered by Autofill unit test of new libphonenumber.

BUG=81753
TEST=PhoneNumberI18NTest.PhoneNumbersMatch
TBR=isherman at chromium dot org

Review URL: http://codereview.chromium.org/6952015
#
22:53 on May 06, 2011Chromium
Commit by dhollowa@chromium.org :: r84518 /trunk/src/chrome/ (10 files in 4 dirs):
Autofill DOMUI Prefs should work with i18n phone numbers

Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module.

BUG=80101
TEST=PhoneNumberI18NTest.PhoneNumbersMatch

Review URL: http://codereview.chromium.org/6935033
#
23:02 on May 05, 2011Chromium
Commit by dhollowa@chromium.org :: r84346 /trunk/src/chrome/ (10 files in 4 dirs):
Revert 84320 - Autofill DOMUI Prefs should work with i18n phone numbers

Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module.

BUG=80101
TEST=PhoneNumberI18NTest.PhoneNumbersMatch

Review URL: http://codereview.chromium.org/6930037

TBR=dhollowa at chromium dot org
Review URL: http://codereview.chromium.org/6930052
#
21:35 on May 05, 2011Chromium
Commit by dhollowa@chromium.org :: r84320 /trunk/src/chrome/ (10 files in 4 dirs):
Autofill DOMUI Prefs should work with i18n phone numbers

Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module.

BUG=80101
TEST=PhoneNumberI18NTest.PhoneNumbersMatch

Review URL: http://codereview.chromium.org/6930037
#
17:05 on Apr 28, 2011Chromium
Commit by dhollowa@chromium.org :: r83349 /branches/742/src/chrome/ (3 files in 3 dirs):
Merge 83280 - Aggregated profiles that contains same name but different casing are being merged.Modifies merging logic to treat profile values as case-insensitive for merging purposes.BUG=80618TEST=AutofillMergeTest.DataDrivenMergeProfiles:case.in/outReview URL: http://codereview.chromium.org/6883211
TBR=dhollowa at chromium dot org
Review URL: http://codereview.chromium.org/6902113
#
01:58 on Apr 28, 2011Chromium
Commit by dhollowa@chromium.org :: r83280 /trunk/src/chrome/ (3 files in 3 dirs):
Aggregated profiles that contains same name but different casing are being merged.

Modifies merging logic to treat profile values as case-insensitive for merging purposes.

BUG=80618
TEST=AutofillMergeTest.DataDrivenMergeProfiles:case.in/out

Review URL: http://codereview.chromium.org/6883211
#
01:22 on Apr 28, 2011Chromium
Commit by dhollowa@chromium.org :: r83270 /trunk/src/chrome/browser/autofill/ (5 files):
Autofill Multi-Value: Additional profiles with same name and address not added to DOM UI

Separates out the merging from |PersonalDataManager::AddProfile| so that merging only happens on form submission, and not when the user edits profiles manually via preferences.

BUG=80341
TEST=PersonalDataManagerTest.AddProfile

Review URL: http://codereview.chromium.org/6903091
#
20:58 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82355 /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt:
Leak in NSButtonCell decoder on Mac

Adds suppression for button decoding on Mac. Note this is very similar to suppression for bug_73036b, but I'm adding this separately in case it is fixable separately.

BUG=80050, 73036
TEST=Valgrind bot on Mac goes green.
TBR=sail at chromium dot org

Review URL: http://codereview.chromium.org/6873125
#
20:41 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82353 /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt:
Leak in FSMoveObjectToTrashSync on Mac

Expand leak in FSMoveObjectToTrashSync on Mac to account for TaskClosureAdapter changes in r82300.

BUG=77063
TEST=Valgrind bots on Mac go green.
TBR=ajwong at chromium dot org

Review URL: http://codereview.chromium.org/6883093
#
20:21 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82349 /trunk/src/tools/valgrind/memcheck/suppressions.txt:
Leak in webkit_fileapi_file_system_url_request_job_unittest.cc setup

Generalizes the suppressions further on Mac.

BUG=80002
TEST=Mac memory bots go green.
TBR=zelidrag at chromium dot org

Review URL: http://codereview.chromium.org/6873121
#
18:59 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82342 /trunk/src/tools/valgrind/memcheck/suppressions_mac.txt:
Leak in ResourceBundle::LoadCommonResources on Mac

Adds suppression for ResourceBundle::LoadCommonResources on Mac.

BUG=80036
TEST=Mac Valgrind bot goes green.
TBR=sail at chromium dot org

Review URL: http://codereview.chromium.org/6881087
#
18:36 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82340 /trunk/src/tools/valgrind/memcheck/suppressions.txt:
Leak in webkit_fileapi_file_system_url_request_job_unittest.cc setup

Suppresses leak in webkit_fileapi_file_system_url_request_job_unittest.cc, introduced in r82266.
Generalizes the suppressions to include Mac.

BUG=80002
TEST=Mac memory bots go green.
TBR=zelidrag at chromium dot org

Review URL: http://codereview.chromium.org/6883090
#
18:08 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82338 /trunk/src/tools/valgrind/memcheck/suppressions.txt:
Leak in BrowserRenderProcessHost::Init

Suppresses leak in BrowserRenderProcessHost::Init

BUG=80026
TEST=ChromeOS memory bot goes green.
TBR=sergeyu at chromium dot org

Review URL: http://codereview.chromium.org/6873118
#
17:49 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82330 /trunk/src/tools/valgrind/memcheck/suppressions.txt:
Leak in SSLConnectJob::OnIOComplete

Suppresses leak in SSLConnectJob::OnIOComplete.

BUG=80022
TEST=ChromeOS memory bot goes green.
TBR=sergeyu at chromium dot org

Review URL: http://codereview.chromium.org/6880069
#
17:20 on Apr 20, 2011Chromium
Commit by dhollowa@chromium.org :: r82320 /trunk/src/tools/valgrind/memcheck/suppressions.txt:
Revert 82319 - Leak in TestURLRequestContextSuppresses leak in TestURLRequestContext.BUG=80018TEST=ChromeOS Valgrind bot goes green.TBR=mattm at chromium dot orgReview URL: http://codereview.chromium.org/6881084
TBR=dhollowa at chromium dot org
Review URL: http://codereview.chromium.org/6879080
#