http://cia.vc/stats/author/dhollowa%40chromium.org3851307481926Built-in Subversion repository interface1.0Chromium88207dhollowa@chromium.orgHeuristics for grabber-google.com.out Changes Autofill inferred labels code to filter out <noscript> elements. BUG=76302 TEST=FormStructureBrowserTest.DataDrivenHeuristics, FormManagerTest.LabelsInferredFromTableWithSpecialElements Review URL: http://codereview.chromium.org/7044032trunk/src/chrome/renderer/autofill/form_manager_browsertest.cctrunk/src/chrome/renderer/autofill/form_manager.cc1306360571Built-in Subversion repository interface1.0Chromium86717dhollowa@chromium.orgHeuristics for grabber-continental.com.out (select-one) Adds specific input types to the field_type.h bitfield to utilize the "select-one" signal in identifying the Country, State, and Credit Card date fields. Other fields should not classify now if the input type is "select-one". This is Phase 1 of fixes for the grabber-continental.com.html. Phase 2 will add lookahead logic for the "BusinessPhone" and "Email Address" issues. BUG=76299 TEST=FormStructureBrowserTest.DataDrivenHeuristics with test file grabber-continental.com.html Review URL: http://codereview.chromium.org/7063031trunk/src/chrome/browser/autofill/credit_card_field.cctrunk/src/chrome/browser/autofill/form_field.cctrunk/src/chrome/browser/autofill/address_field.cctrunk/src/chrome/browser/autofill/form_field.htrunk/src/chrome/browser/autofill/email_field.cctrunk/src/chrome/browser/autofill/phone_field.cctrunk/src/chrome/browser/autofill/autofill_resources.grd1305848566Built-in Subversion repository interface1.0Chromium86016dhollowa@chromium.orgAutofill refactor form_field.h/cc. 1. Moves FormField methods into proper public/protected/private visibility. 2. Eliminates redundant "Parse" methods. 3. Introduces |MatchType| bit field to simplify variant matching. 4. Consolidates |Match| method. 5. Renames |Add| and |GetFieldInfo| to |AddClassification| and |ClassifyField| respectively. 6. Move ECML logic into separate file. BUG=none TEST=Unit tests in autofill/*_field_unittest.cc. Review URL: http://codereview.chromium.org/7043027trunk/src/chrome/browser/autofill/credit_card_field_unittest.cctrunk/src/chrome/browser/autofill/form_field_unittest.cctrunk/src/chrome/browser/autofill/credit_card_field.cctrunk/src/chrome/browser/autofill/form_field.cctrunk/src/chrome/browser/autofill/credit_card_field.htrunk/src/chrome/browser/autofill/form_field.htrunk/src/chrome/browser/autofill/phone_field_unittest.cctrunk/src/chrome/browser/autofill/phone_field.cctrunk/src/chrome/browser/autofill/phone_field.htrunk/src/chrome/browser/autofill/autofill_ecml.cctrunk/src/chrome/browser/autofill/autofill_ecml.htrunk/src/chrome/browser/autofill/name_field_unittest.cctrunk/src/chrome/browser/autofill/name_field.cctrunk/src/chrome/browser/autofill/name_field.htrunk/src/chrome/browser/autofill/address_field_unittest.cctrunk/src/chrome/browser/autofill/address_field.cctrunk/src/chrome/browser/autofill/email_field.cctrunk/src/chrome/browser/autofill/address_field.htrunk/src/chrome/browser/autofill/email_field.htrunk/src/chrome/chrome_browser.gypi1305561143Built-in Subversion repository interface1.0Chromium85489dhollowa@chromium.orgAutofill should reject aggregated profiles where email address is found in non-email fields Adds code to reject import of profiles and credit cards that have email address data in non-email fields. BUG=77113 TEST=AutofillMergeTest.DataDrivenMergeProfiles with email.in and email.out. Review URL: http://codereview.chromium.org/7013016trunk/src/chrome/browser/autofill/personal_data_manager.cctrunk/src/chrome/browser/autofill/personal_data_manager.htrunk/src/chrome/test/data/autofill/merge/input/email.intrunk/src/chrome/test/data/autofill/merge/output/email.out1304967298Built-in Subversion repository interface1.0Chromium84654dhollowa@chromium.orgChange ZIP and last name heuristic pattern. In ZIP heuristic patter, there is "cp". But it is too short and it matches first/last name fiels. So I change it to "^cp$". "secondname" was a specified as last name. So I added. BUG=76332,76331 TEST=1, put yahoo and super shuttle grabber input files. 2.run browser_tests --gtest_filter=*.DataDrivenHeuristics and see the inferred results. Review URL: http://codereview.chromium.org/6954010trunk/src/chrome/browser/autofill/autofill_resources.grd1304729557Built-in Subversion repository interface1.0Chromium84535dhollowa@chromium.orgValgrind reports issues in icu::RegexMatcher Adds suppression for icu RegexMatcher, triggered by Autofill unit test of new libphonenumber. BUG=81753 TEST=PhoneNumberI18NTest.PhoneNumbersMatch TBR=isherman@chromium.org Review URL: http://codereview.chromium.org/6952015trunk/src/tools/valgrind/memcheck/suppressions.txt1304722414Built-in Subversion repository interface1.0Chromium84518dhollowa@chromium.orgAutofill DOMUI Prefs should work with i18n phone numbers Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module. BUG=80101 TEST=PhoneNumberI18NTest.PhoneNumbersMatch Review URL: http://codereview.chromium.org/6935033trunk/src/chrome/browser/autofill/DEPStrunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.jstrunk/src/chrome/browser/ui/webui/options/autofill_options_handler.cctrunk/src/chrome/browser/ui/webui/options/autofill_options_handler.htrunk/src/chrome/browser/autofill/phone_number_i18n_unittest.cctrunk/src/chrome/browser/autofill/phone_number_i18n.cctrunk/src/chrome/chrome_tests.gypitrunk/src/chrome/chrome_browser.gypitrunk/src/chrome/browser/autofill/phone_number_i18n.htrunk/src/chrome/browser/resources/options/autofill_options_list.js1304636525Built-in Subversion repository interface1.0Chromium84346dhollowa@chromium.orgRevert 84320 - Autofill DOMUI Prefs should work with i18n phone numbers Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module. BUG=80101 TEST=PhoneNumberI18NTest.PhoneNumbersMatch Review URL: http://codereview.chromium.org/6930037 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6930052trunk/src/chrome/browser/autofill/DEPStrunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.jstrunk/src/chrome/browser/ui/webui/options/autofill_options_handler.cctrunk/src/chrome/browser/ui/webui/options/autofill_options_handler.htrunk/src/chrome/browser/autofill/phone_number_i18n_unittest.cctrunk/src/chrome/browser/autofill/phone_number_i18n.cctrunk/src/chrome/chrome_tests.gypitrunk/src/chrome/chrome_browser.gypitrunk/src/chrome/browser/autofill/phone_number_i18n.htrunk/src/chrome/browser/resources/options/autofill_options_list.js1304631339Built-in Subversion repository interface1.0Chromium84320dhollowa@chromium.orgAutofill DOMUI Prefs should work with i18n phone numbers Adds validation to the phone and fax lists in WebUI based prefs for Autofill. Also adds the start of phone_number_i18n.cc/h module. BUG=80101 TEST=PhoneNumberI18NTest.PhoneNumbersMatch Review URL: http://codereview.chromium.org/6930037trunk/src/chrome/browser/autofill/DEPStrunk/src/chrome/browser/resources/options/autofill_edit_address_overlay.jstrunk/src/chrome/browser/ui/webui/options/autofill_options_handler.cctrunk/src/chrome/browser/ui/webui/options/autofill_options_handler.htrunk/src/chrome/browser/autofill/phone_number_i18n_unittest.cctrunk/src/chrome/browser/autofill/phone_number_i18n.cctrunk/src/chrome/chrome_tests.gypitrunk/src/chrome/chrome_browser.gypitrunk/src/chrome/browser/autofill/phone_number_i18n.htrunk/src/chrome/browser/resources/options/autofill_options_list.js1304010345Built-in Subversion repository interface1.0Chromium83349dhollowa@chromium.orgMerge 83280 - Aggregated profiles that contains same name but different casing are being merged.Modifies merging logic to treat profile values as case-insensitive for merging purposes.BUG=80618TEST=AutofillMergeTest.DataDrivenMergeProfiles:case.in/outReview URL: http://codereview.chromium.org/6883211 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6902113branches/742/src/chrome/browser/autofill/form_group.ccbranches/742/src/chrome/test/data/autofill/merge/input/case.inbranches/742/src/chrome/test/data/autofill/merge/output/case.out1303955939Built-in Subversion repository interface1.0Chromium83280dhollowa@chromium.orgAggregated profiles that contains same name but different casing are being merged. Modifies merging logic to treat profile values as case-insensitive for merging purposes. BUG=80618 TEST=AutofillMergeTest.DataDrivenMergeProfiles:case.in/out Review URL: http://codereview.chromium.org/6883211trunk/src/chrome/browser/autofill/form_group.cctrunk/src/chrome/test/data/autofill/merge/input/case.intrunk/src/chrome/test/data/autofill/merge/output/case.out1303953722Built-in Subversion repository interface1.0Chromium83270dhollowa@chromium.orgAutofill Multi-Value: Additional profiles with same name and address not added to DOM UI Separates out the merging from |PersonalDataManager::AddProfile| so that merging only happens on form submission, and not when the user edits profiles manually via preferences. BUG=80341 TEST=PersonalDataManagerTest.AddProfile Review URL: http://codereview.chromium.org/6903091trunk/src/chrome/browser/autofill/credit_card.cctrunk/src/chrome/browser/autofill/credit_card.htrunk/src/chrome/browser/autofill/personal_data_manager_unittest.cctrunk/src/chrome/browser/autofill/personal_data_manager.cctrunk/src/chrome/browser/autofill/autofill-inl.h1303333082Built-in Subversion repository interface1.0Chromium82355dhollowa@chromium.orgLeak in NSButtonCell decoder on Mac Adds suppression for button decoding on Mac. Note this is very similar to suppression for bug_73036b, but I'm adding this separately in case it is fixable separately. BUG=80050, 73036 TEST=Valgrind bot on Mac goes green. TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6873125trunk/src/tools/valgrind/memcheck/suppressions_mac.txt1303332113Built-in Subversion repository interface1.0Chromium82353dhollowa@chromium.orgLeak in FSMoveObjectToTrashSync on Mac Expand leak in FSMoveObjectToTrashSync on Mac to account for TaskClosureAdapter changes in r82300. BUG=77063 TEST=Valgrind bots on Mac go green. TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/6883093trunk/src/tools/valgrind/memcheck/suppressions_mac.txt1303330904Built-in Subversion repository interface1.0Chromium82349dhollowa@chromium.orgLeak in webkit_fileapi_file_system_url_request_job_unittest.cc setup Generalizes the suppressions further on Mac. BUG=80002 TEST=Mac memory bots go green. TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/6873121trunk/src/tools/valgrind/memcheck/suppressions.txt1303325976Built-in Subversion repository interface1.0Chromium82342dhollowa@chromium.orgLeak in ResourceBundle::LoadCommonResources on Mac Adds suppression for ResourceBundle::LoadCommonResources on Mac. BUG=80036 TEST=Mac Valgrind bot goes green. TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6881087trunk/src/tools/valgrind/memcheck/suppressions_mac.txt1303324597Built-in Subversion repository interface1.0Chromium82340dhollowa@chromium.orgLeak in webkit_fileapi_file_system_url_request_job_unittest.cc setup Suppresses leak in webkit_fileapi_file_system_url_request_job_unittest.cc, introduced in r82266. Generalizes the suppressions to include Mac. BUG=80002 TEST=Mac memory bots go green. TBR=zelidrag@chromium.org Review URL: http://codereview.chromium.org/6883090trunk/src/tools/valgrind/memcheck/suppressions.txt1303322890Built-in Subversion repository interface1.0Chromium82338dhollowa@chromium.orgLeak in BrowserRenderProcessHost::Init Suppresses leak in BrowserRenderProcessHost::Init BUG=80026 TEST=ChromeOS memory bot goes green. TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/6873118trunk/src/tools/valgrind/memcheck/suppressions.txt1303321777Built-in Subversion repository interface1.0Chromium82330dhollowa@chromium.orgLeak in SSLConnectJob::OnIOComplete Suppresses leak in SSLConnectJob::OnIOComplete. BUG=80022 TEST=ChromeOS memory bot goes green. TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/6880069trunk/src/tools/valgrind/memcheck/suppressions.txt1303320035Built-in Subversion repository interface1.0Chromium82320dhollowa@chromium.orgRevert 82319 - Leak in TestURLRequestContextSuppresses leak in TestURLRequestContext.BUG=80018TEST=ChromeOS Valgrind bot goes green.TBR=mattm@chromium.orgReview URL: http://codereview.chromium.org/6881084 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6879080trunk/src/tools/valgrind/memcheck/suppressions.txt