http://cia.vc/stats/author/dkazakov323Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id D85E91D83BD
for <cia@cia.navi.cx>; Sun, 21 Nov 2010 14:05:14 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 3D952AC8A2; Sun, 21 Nov 2010 23:05:04 +0100 (CET)sysadmin@kde.org<20101121220504.3D952AC8A2@svn.kde.org>Sun, 21 Nov 2010 23:05:04 +0100 (CET)KDEkrita1199447dkazakovtrunk/koffice/krita/image/kis_async_merger.htrunk/koffice/krita/image/kis_base_rects_walker.htrunk/koffice/krita/image/kis_full_refresh_walker.htrunk/koffice/krita/image/kis_node.htrunk/koffice/krita/image/tests/kis_async_merger_test.cpptrunk/koffice/krita/image/tests/kis_async_merger_test.hFixed a full refresh for Clone layers
Now the Async Merger knows about one more type of layer position:
N_EXTRA. Such layer will be counted in a need rect chain and will be
updated (original+projection), but it will not be merged into the
final projection of the image. This is done for preliminary updates of
the sources of Clone layers.
Btw, i would suggest everyone to perform 'make clean' in
./krita/image/ folder, because many parts of walkers are
inlined. There is no need to do a full clean, just in ./image/
directory.
CCMAIL:kimageshop@kde.org
BUG:257532233http://websvn.kde.org/?view=revision&revision=11994471290377115Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id BB43D1D83BD
for <cia@cia.navi.cx>; Sun, 21 Nov 2010 09:15:58 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 1AC20AC8A2; Sun, 21 Nov 2010 18:15:48 +0100 (CET)sysadmin@kde.org<20101121171548.1AC20AC8A2@svn.kde.org>Sun, 21 Nov 2010 18:15:48 +0100 (CET)KDEkrita1199348dkazakovtrunk/koffice/krita/ui/flake/kis_shape_layer.cctrunk/koffice/krita/ui/flake/kis_shape_layer.htrunk/koffice/krita/ui/kra/kis_kra_load_visitor.cppRemoved deprecated stuff
- repaintOriginal() was deprecated by the beginning of February
- steDirty()'s are useless because the image is locked while loading130http://websvn.kde.org/?view=revision&revision=11993481290359759Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id E01FE1D83AA
for <cia@cia.navi.cx>; Sun, 21 Nov 2010 01:50:34 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 3C0B8AC8A2; Sun, 21 Nov 2010 10:50:24 +0100 (CET)sysadmin@kde.org<20101121095024.3C0B8AC8A2@svn.kde.org>Sun, 21 Nov 2010 10:50:24 +0100 (CET)KDEkrita1199261dkazakovtrunk/koffice/krita/image/kis_transformation_mask.cppMake proper default values for KisTransformationMask
KisKraSaverTest uses default constructed value of the mask for the
testing so change the default scale to a sane value. Nevertheless we
don't use these masks anywhere yet.16http://websvn.kde.org/?view=revision&revision=11992611290333035Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 9EED81D83AA
for <cia@cia.navi.cx>; Sun, 21 Nov 2010 00:46:45 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id E8F80AC8A2; Sun, 21 Nov 2010 09:46:34 +0100 (CET)sysadmin@kde.org<20101121084634.E8F80AC8A2@svn.kde.org>Sun, 21 Nov 2010 09:46:34 +0100 (CET)KDEkrita1199240dkazakovtrunk/koffice/krita/image/kis_clone_layer.cpptrunk/koffice/krita/image/kis_clone_layer.htrunk/koffice/krita/ui/kra/kis_kra_load_visitor.cpptrunk/koffice/krita/ui/kra/kis_kra_load_visitor.hFix Clone Layer loading
The link to the source layer should be initialized.96http://websvn.kde.org/?view=revision&revision=11992401290329206Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 7F11A1D83C7
for <cia@cia.navi.cx>; Sat, 20 Nov 2010 00:18:24 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id D26B9AC8A2; Sat, 20 Nov 2010 09:18:13 +0100 (CET)sysadmin@kde.org<20101120081813.D26B9AC8A2@svn.kde.org>Sat, 20 Nov 2010 09:18:13 +0100 (CET)KDEkrita1198898dkazakovtrunk/koffice/krita/ui/kis_doc2.cctrunk/koffice/krita/ui/kis_view2.cppThe full image refresh should be done on document loading only
BUG:25726436http://websvn.kde.org/?view=revision&revision=11988981290241104Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id DCD051D83C7
for <cia@cia.navi.cx>; Fri, 19 Nov 2010 12:05:45 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id F2046AC8A2; Fri, 19 Nov 2010 21:05:33 +0100 (CET)sysadmin@kde.org<20101119200533.F2046AC8A2@svn.kde.org>Fri, 19 Nov 2010 21:05:33 +0100 (CET)KDEkrita1198799dkazakovtrunk/koffice/krita/ui/canvas/kis_perspective_grid_manager.cpptrunk/koffice/krita/ui/canvas/kis_perspective_grid_manager.hMade KisToolPerspectiveGrid work in interactive mode
There was a bug that lead to an infinite loop. It happened due to a
(NaN,NaN) intersection points those appeared after calculation of
intersection of null-length lines %). Now we just check for the length
of the line.129http://websvn.kde.org/?view=revision&revision=11987991290197183Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 18E051D83C7
for <cia@cia.navi.cx>; Wed, 17 Nov 2010 13:07:37 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 5A6ECAC8A1; Wed, 17 Nov 2010 22:07:26 +0100 (CET)sysadmin@kde.org<20101117210726.5A6ECAC8A1@svn.kde.org>Wed, 17 Nov 2010 22:07:26 +0100 (CET)KDEkrita1198207dkazakovtrunk/koffice/krita/ui/canvas/kis_perspective_grid_manager.cpptrunk/koffice/krita/ui/canvas/kis_perspective_grid_manager.hFixed several bugs in KisPerspectiveGridManager
What is done:
1) Now the manager doesn't even try to paint the lines inside the
polygon that is not convex. It used to lead to a really weird
picture of a hedgehog on a user's screen :P
2) Fixed an "infinity"-bug. Eigen::Hyperplane::intersection() returns
a random point in case the lines are parallel. Now an additional
check returns a point somewhere around infinity to workaround this
behavior.
3) Changed the algorithm that chooses a line to chop up into
"subdivisions". Now the farthest line from the focus is used for
the division.
Still to be done:
- Make KisPerspectiveGridTool interactive. It will be a really short
fix. I just need to overcome a small infinite loop somewhere ;)
BUG:251731287http://websvn.kde.org/?view=revision&revision=11982071290028058Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 5DC631D82B1
for <cia@cia.navi.cx>; Sun, 14 Nov 2010 04:46:07 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id B46B4AC8A3; Sun, 14 Nov 2010 13:45:56 +0100 (CET)sysadmin@kde.org<20101114124556.B46B4AC8A3@svn.kde.org>Sun, 14 Nov 2010 13:45:56 +0100 (CET)KDEkrita1196934dkazakovtrunk/koffice/krita/ui/canvas/kis_grid_painter_configuration.cppFix usual Grid Tool
The pen should be cosmetic to be painted nicely.
CCBUG:25173120http://websvn.kde.org/?view=revision&revision=11969341289738767Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id DB2F51D82B1
for <cia@cia.navi.cx>; Sun, 14 Nov 2010 04:16:29 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id C6C52AC8A1; Sun, 14 Nov 2010 13:16:17 +0100 (CET)sysadmin@kde.org<20101114121617.C6C52AC8A1@svn.kde.org>Sun, 14 Nov 2010 13:16:17 +0100 (CET)KDEkrita1196930dkazakovtrunk/koffice/krita/ui/tool/kis_tool_freehand.ccKisToolFreehand should accept all the events in painting mode
BUG:25641523http://websvn.kde.org/?view=revision&revision=11969301289736990Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 24EB51D82B1
for <cia@cia.navi.cx>; Sun, 14 Nov 2010 01:22:41 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 59A26AC8A0; Sun, 14 Nov 2010 10:22:30 +0100 (CET)sysadmin@kde.org<20101114092230.59A26AC8A0@svn.kde.org>Sun, 14 Nov 2010 10:22:30 +0100 (CET)KDEkrita1196807dkazakovtrunk/koffice/krita/image/kis_convolution_painter.cctrunk/koffice/krita/image/tests/kis_convolution_painter_test.cpptrunk/koffice/krita/image/tests/kis_convolution_painter_test.hAdded a benchmark for KisConvolutionPainter
Adjusted the workers as well. Now the type of the worker depends not
the available engine only, but on the size of the kernel as well. Even
from theoretical perspective, KisConvolutionWorker is faster when the
size of the kernel is less than 5x5px.
Some conclusions from benchmarking the FFTW convolution worker:
1) FFT and IFFT of the image take 30% of the time each.
2) FFT of the kernel (even though the kernel has the same size as the
image, but it is very sparse) takes 7.5% only.
3) Creation of a plan for FFT and IFFT take 4% each.
4) There is a possibility to make the worker faster. That is to use
the "wisdom" (FFTW_MEASURE flag) recomended by FFTW3
documentation. In case of activation of this flag the convolution
becomes about 20% faster. But the use of this flag will make us
change our system a bit: we will have to use descrete sizes of
the convolution areas and we will need to save these "words of
wisdom" somewhere.
CCMAIL:kimageshop@kde.org226http://websvn.kde.org/?view=revision&revision=11968071289726561Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 29C6C1D82B1
for <cia@cia.navi.cx>; Sat, 13 Nov 2010 13:45:08 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 3C00BAC8A0; Sat, 13 Nov 2010 22:44:57 +0100 (CET)sysadmin@kde.org<20101113214457.3C00BAC8A0@svn.kde.org>Sat, 13 Nov 2010 22:44:57 +0100 (CET)KDEkrita1196674dkazakovtrunk/koffice/krita/image/kis_painter.ccFixed KisPainter::setAlphaLocked() not to break setChannelFlags()68http://websvn.kde.org/?view=revision&revision=11966741289684708Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 905C11D82B1
for <cia@cia.navi.cx>; Sat, 13 Nov 2010 08:21:22 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id D8E52AC8A0; Sat, 13 Nov 2010 17:21:11 +0100 (CET)sysadmin@kde.org<20101113162111.D8E52AC8A0@svn.kde.org>Sat, 13 Nov 2010 17:21:11 +0100 (CET)KDEkrita1196595dkazakovtrunk/koffice/krita/image/kis_convolution_worker_fft.htrunk/koffice/krita/image/kis_convolution_worker_spatial.htrunk/koffice/krita/image/tests/kis_convolution_painter_test.cppMade KisConvolutionWorkerSpatial do convolution instead of correlation86http://websvn.kde.org/?view=revision&revision=11965951289665282Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id A09C11D82B1
for <cia@cia.navi.cx>; Sat, 13 Nov 2010 01:32:25 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id B7CABAC8A0; Sat, 13 Nov 2010 10:32:14 +0100 (CET)sysadmin@kde.org<20101113093214.B7CABAC8A0@svn.kde.org>Sat, 13 Nov 2010 10:32:14 +0100 (CET)KDEkrita1196381dkazakovtrunk/koffice/krita/image/tests/data/mask_conv.pngtrunk/koffice/krita/image/tests/data/mask_conv_channelflags.pngtrunk/koffice/krita/image/tests/data/mask_conv_red.pngtrunk/koffice/krita/image/tests/kis_convolution_painter_test.cpptrunk/koffice/krita/image/tests/kis_convolution_painter_test.hMade new tests for convolution painter
They are not relative now. They check absolute values.389http://websvn.kde.org/?view=revision&revision=11963811289640747Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id AFA8B1D83AA
for <cia@cia.navi.cx>; Tue, 9 Nov 2010 11:49:14 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 98AE1AC89E; Tue, 9 Nov 2010 20:49:03 +0100 (CET)sysadmin@kde.org<20101109194903.98AE1AC89E@svn.kde.org>Tue, 9 Nov 2010 20:49:03 +0100 (CET)KDEkrita1194751dkazakovtrunk/koffice/krita/image/kis_convolution_worker_fft.htrunk/koffice/krita/image/kis_math_toolbox.cpptrunk/koffice/krita/image/tests/kis_convolution_painter_test.cppFix spatial convolution filter
Rounding for integers should have been done on a level of
KisMathToolbox.71http://websvn.kde.org/?view=revision&revision=11947511289332155Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id A13831D82B1
for <cia@cia.navi.cx>; Tue, 9 Nov 2010 02:42:13 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id B97BBAC8A0; Tue, 9 Nov 2010 11:42:02 +0100 (CET)sysadmin@kde.org<20101109104202.B97BBAC8A0@svn.kde.org>Tue, 9 Nov 2010 11:42:02 +0100 (CET)KDEkrita1194562dkazakovtrunk/koffice/krita/image/tests/kis_convolution_painter_test.cpptrunk/koffice/krita/image/tests/kis_convolution_painter_test.hAdded a real unittest for KisConvolutionPainter
This test checks the correctness of the convolution algorithm by its
(convolution) definition.
Results:
KisConvolutionWorkerFFT works fine
KisConvolutionWorkerSpatial does not work fine =)173http://websvn.kde.org/?view=revision&revision=11945621289299334Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 65AFE1D82B1
for <cia@cia.navi.cx>; Tue, 9 Nov 2010 00:02:07 -0800 (PST)by svn.kde.org (Postfix, from userid 50438)
id 9E82BAC89E; Tue, 9 Nov 2010 09:01:56 +0100 (CET)sysadmin@kde.org<20101109080156.9E82BAC89E@svn.kde.org>Tue, 9 Nov 2010 09:01:56 +0100 (CET)KDEkrita1194510dkazakovtrunk/koffice/krita/image/tests/kis_layer_test.cppMake a test in KisLayerTest faster
90s for a single test is too much for regular unit-testing. When
something happens you can always test this case more thoroughtly.14http://websvn.kde.org/?view=revision&revision=11945101289289727Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 5FD861D83C0
for <cia@cia.navi.cx>; Sun, 7 Nov 2010 01:40:48 -0700 (PDT)by svn.kde.org (Postfix, from userid 50438)
id 2A451AC89E; Sun, 7 Nov 2010 09:40:37 +0100 (CET)sysadmin@kde.org<20101107084037.2A451AC89E@svn.kde.org>Sun, 7 Nov 2010 09:40:37 +0100 (CET)KDEkrita1193814dkazakovtrunk/koffice/krita/image/kis_image.hDeprecate KisImage::mergedImage() function
It is intended to do a very strange thing (it doesn't guarantee
anything, because it can't even lock the image) and its functionality is
fully covered by other methods of KisImage. See a comment in the
header to get more info.31http://websvn.kde.org/?view=revision&revision=11938141289119248Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 849581D82B1
for <cia@cia.navi.cx>; Sun, 7 Nov 2010 00:24:32 -0700 (PDT)by svn.kde.org (Postfix, from userid 50438)
id D85F5AC8A0; Sun, 7 Nov 2010 08:24:21 +0100 (CET)sysadmin@kde.org<20101107072421.D85F5AC8A0@svn.kde.org>Sun, 7 Nov 2010 08:24:21 +0100 (CET)KDEkrita1193812dkazakovtrunk/koffice/krita/ui/CMakeLists.txttrunk/koffice/krita/ui/opengl/kis_opengl_canvas2.cpptrunk/koffice/krita/ui/opengl/kis_opengl_image_textures.cpptrunk/koffice/krita/ui/opengl/kis_opengl_image_textures.htrunk/koffice/krita/ui/opengl/kis_texture_tile.cpptrunk/koffice/krita/ui/opengl/kis_texture_tile.htrunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.hFix the border effects in OpenGL canvas
This patch makes the textures representing the image overlap. The size
of the textures is still 256x256 pixels, But effectively they carry
254x254 pixels of information. The overlapping 1px border makes linear
interpolation algorithm happy, so scaling is done in the right way.
The patch fixes "image->bounds()" border effect as well. How does it
solve it? It just repeats the first and the last pixels of every row
and column. So the interpolation runs successfully.
BUG:251113597http://websvn.kde.org/?view=revision&revision=11938121289114672Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id 301E01D82B1
for <cia@cia.navi.cx>; Sun, 7 Nov 2010 00:24:04 -0700 (PDT)by svn.kde.org (Postfix, from userid 50438)
id 4D04BAC89E; Sun, 7 Nov 2010 08:23:53 +0100 (CET)sysadmin@kde.org<20101107072353.4D04BAC89E@svn.kde.org>Sun, 7 Nov 2010 08:23:53 +0100 (CET)KDEkrita1193811dkazakovtrunk/koffice/krita/ui/opengl/kis_opengl_canvas2.cpptrunk/koffice/krita/ui/opengl/kis_opengl_image_textures.cpptrunk/koffice/krita/ui/opengl/kis_opengl_image_textures.htrunk/koffice/krita/ui/opengl/kis_texture_tile.htrunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.hA major clean-up for KisOpenGLImageTextures
o Encapsulated all the texture tiles into a separate objects
(KisTextureTile). This will allow us to add borders to the tiles.
o Removed deprecated/unused methods.917http://websvn.kde.org/?view=revision&revision=11938111289114644Subversion CIA Bot client shell script1.0from svn.kde.org (svn.kde.org [195.135.221.69])
by cia.vc (Postfix) with ESMTP id E9D631D82B1
for <cia@cia.navi.cx>; Fri, 5 Nov 2010 03:19:37 -0700 (PDT)by svn.kde.org (Postfix, from userid 50438)
id 480BBAC89E; Fri, 5 Nov 2010 11:19:26 +0100 (CET)sysadmin@kde.org<20101105101926.480BBAC89E@svn.kde.org>Fri, 5 Nov 2010 11:19:26 +0100 (CET)KDEkrita1193259dkazakovtrunk/koffice/krita/ui/flake/kis_shape_controller.cpptrunk/koffice/krita/ui/flake/kis_shape_layer.cctrunk/koffice/krita/ui/flake/kis_shape_layer_paste.htrunk/koffice/libs/flake/KoShapePaste.cppA proper fix for bug 255682
The problem was in KoShapePaste, because it performed setParent() and
controller->addShape() calls separately. There is no need to change
Krita's part of shape layers for that (that is why this patch reverts
commit 1192386).
The change to KoShapePaste was approved by Thomas on a mailing list
yesterday.
CCBUG:25568274http://websvn.kde.org/?view=revision&revision=11932591288952378