Commit by ereslibre :: r1212530 solid/trunk/KDE/kdelibs/solid/solid/devicemanager.cpp: (link)

Revert as requested by Kevin.

CCMAIL: ervin at kde dot org
CCMAIL: aseigo at kde dot org

Commit by ereslibre :: r1212447 solid/trunk/KDE/kdelibs/solid/solid/devicemanager.cpp: (link)

Remove this assertion since if createBackendObject returns 0 (no backend could be found by iterating) it makes solid crash on debug mode because it will not assert.

CCMAIL: aseigo at kde dot org

Commit by ereslibre :: r1207380 workspace/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationstack.cpp: (link)

Only resize height. This way if we have a notification stack snapped to the right margin, it will always keep snapped

Commit by ereslibre :: r1207358 workspace/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp: (link)

Replace \n with <br/> before it gets elided (in case it gets elided), and place the elide at the end of the string, instead of the middle (which is more handy for filesystem paths)

Commit by ereslibre :: r1207298 workspace/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp: (link)

Fix animation on the icon. Forcing height and width to SizeLarge so there is less space wasted on the icon part

Commit by ereslibre :: r1207277 workspace/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/stackdialog.cpp: (link)

In my laptop notifications on the right lower corner were being snapped really away from the corner. Approximately 280px away. This allows users to be able to have notifications not snapped to the corner, but still close, being of course able to snap it easily.

Commit by ereslibre :: r1207268 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevaudiointerface_p.cpp: (link)

Already set on top of the ctor. If we reach here, is because m_driver has not been set, so it keeps being Solid::AudioInterface::UnknownAudioDriver

Commit by ereslibre :: r1206203 workspace/trunk/KDE/kdebase/workspace/plasma/generic/applets/notifications/ui/notificationwidget.cpp: (link)

Notifications graphical changes:

• The body layout sets a 0 spacing, so there is a small amount of space between icon, message and buttons.
• The preferred width of the message label is 0, so it can still grow to a reasonable size and still be usable.
• The bigIconRect() was uniting the two rects (small icon and big icon), thus making long titles to overlap with the big icon itself. Big icon now is in its place.

Commit by ereslibre :: r1204525 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp: (link)

Add detailed output, that is disabled by default. It will help when giving support to other types of devices, showing up all the information that UDev has about the device.

Commit by ereslibre :: r1197487 solid/trunk/KDE/kdelibs/solid/solid/backends/hal/halprocessor.cpp: (link)

Remove cpuFeatures() declaration, that I forgot there

Commit by ereslibre :: r1197485 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.cpp: (link)

Get the max speed from /proc/cpuinfo. First, this is not completely correct. Second, this is a hack. So, we have to find a better way of getting this information.

Commit by ereslibre :: r1197484 solid/trunk/KDE/kdelibs/solid/solid/ (5 files in 4 dirs): (link)

Share cpufeatures so both hal and udev processor backends can access to this information.

CCMAIL: ervin at kde dot org

Commit by ereslibre :: r1194901 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp: (link)

Same thing than with icon() method, calling to queryDeviceInterface in order to get a description, and we can tweak this description depending on subclasses of device type, like an iPod.

BUG: 253670

Commit by ereslibre :: r1194875 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevdevice.cpp: (link)

Return the icon depending on what kind of device we have. I am not completely sure if calling queryDeviceInterface is an accepted strategy here, but seemed to me like a clean solution instead of repeating the same condition for each type of device. Still needs to be polished for special devices like iPods that have their own icons.

CCMAIL: ervin at kde dot org
BUG: 253668

Commit by ereslibre :: r1194873 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp: (link)

I think this icon is much better for the root node

Commit by ereslibre :: r1194868 solid/trunk/KDE/kdelibs/solid/solid/ (4 files in 2 dirs): (link)

Add UDevPortableMediaPlayer. Not too much for now since I can't test this one:

• I need to find out what determines a PortableMediaPlayer (UDevDevice)
• Report its properties (UDevPortableMediaPlayer)

Commit by ereslibre :: r1194867 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevmanager.cpp: (link)

Remove QDebug from here

Commit by ereslibre :: r1194859 solid/trunk/KDE/kdelibs/solid/solid/backends/udev/udevprocessor.h: (link)

Nitpick. Style.

Commit by ereslibre :: r1194858 solid/trunk/KDE/kdelibs/solid/solid/backends/hal/halportablemediaplayer.cpp: (link)

Spotted this one nitpick. No need to provide so many namespace information

Commit by ereslibre :: r1194856 solid/trunk/KDE/kdelibs/solid/solid/ (4 files in 2 dirs): (link)

Provide UDevProcessor. Right now it only provides the number of the processor, since maxSpeed, canChangeFrequency and instructionSets is information that is not provided by UDev. We have to do some kind of workaround here: black magic allowed.