Commit by jjustincc :: r7fd38788b4a6 /OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs:

minor: code formatting from 0b72f773

Commit by jjustincc :: r3ac3be99ae73 /CONTRIBUTORS.txt:

Add Blake/Techplex to CONTRIBUTORS. Thanks!

Commit by jjustincc :: r43a6f286209e /OpenSim/Region/Framework/Scenes/Scene.cs:

 If restating a region, clean up the physics scene after the main scene has been closed not before.

If this is done before then on ODE agent update calls still incoming can fail as they try to use a raycastmanager that has been disposed.
Bullet plugin does nothing on Dispose()
However, I wouldn't be at all surprised if individual region restarting was buggy in lots of other areas.

Commit by jjustincc :: rd6476b627752 /OpenSim/Region/ScriptEngine/Shared/Api/Implementation/LSL_Api.cs:

 Use GetInventoryItem() in LSL_Api.InventoryKey(string name, int type).

Also removes small bug where calling this method would add 1 to LPS, evne though all callers already did this.

Commit by jjustincc :: rff53add54dbc /OpenSim/Region/ (3 files in 3 dirs):

 refactor: replace LSL_Api.InventoryKey(string) largely with SceneObjectPartInventory.GetInventoryItem(string)

Also gets llStopAnimation() to call KeyOrName rather than duplicating logic.

Commit by jjustincc :: rf2a5fad18f30 /OpenSim/Region/ScriptEngine/Shared/Api/Implementation/OSSL_Api.cs:

Use SceneObjectPartInventory.GetInventoryItem() in OSSL.AvatarStopAnimation instead of searching the task inventory manually.

Commit by jjustincc :: r67ebe80dd95f /OpenSim/Region/CoreModules/ (9 files in 7 dirs):

Resolve some mono compiler warnings.

Commit by jjustincc :: r888210ea4af0 /OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs:

refactor: make ETM.CrossAgentToNewRegionAsync neighbourRegion == null check return earlier to simplify method

Commit by jjustincc :: rab59c0a658c2 /OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs:

on agent cross, remove from physics scene after its been placed in transit, not before.

Commit by jjustincc :: r96cde407ab0d /OpenSim/ (2 files in 2 dirs):

Fix bug where a failed QueryAccess to a remove region would always have the reason "Communications failure" no matter what the destination region actually returned

Commit by jjustincc :: r9f1fc7ea8816 /OpenSim/Region/Framework/Scenes/SceneObjectPartInventory.cs:

Remove a call stack debugging line accidentally left in from a few days ago at SceneObjectPartInventory.ApplyNextOwnerPermissions().

Commit by jjustincc :: r7cceab12956d /OpenSim/ (2 files in 2 dirs):

 In remote QueryAccess, also receive the actual status (true|false) instead of always true no matter what the callee actually returned.

This was due to two things
1) SimulationServiceConnector.QueryAccess was always looking to the outer result["success"].
But if a "_Result" map is returned (which is certainly the case right now), then the true success is _Result["success"], result["success"] is always true no matter what
2) If QueryAccess was false at the destination, then AgentHandlers.DoQueryAccess() was never putting this in the result.
The default action of SerializeJsonString() is not to put false booleans in the JSON!!!, so this has to be explicitly set.

Commit by jjustincc :: r40c78b06246d /OpenSim/Region/ (3 files in 3 dirs):

 Stop it being possible for an agent to teleport back to its source region before the source region has finished cleaning up old agent data and structures.

If this is allowed, then the client usually gets forcibly logged out and data structures might be put into bad states.
To prevent this, the binary state machine of EMT.m_agentsInTransit is replaced with a 4 state machine (Preparing, Transferring, ReceivedAtDestination, CleaningUp).
This is necessary because the source region needs to know when the destination region has received the user but a teleport back cannot happen until the source region has cleaned up.
Tested on standalone, grid and with v1 and v3 clients.

Commit by jjustincc :: rcc53d91d2f53 /OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs:

On inter-region teleport, only stand the avatar up if the QueryAccess call to the destination scene actually succeeds.

Commit by jjustincc :: r93ff27053a2d /OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs:

 Don't actually proceed on a within-region teleport if another is already taking place, rather than just (falsely) logging that we're not going to proceed.

An oversight from recent commit 9ab0c81

Commit by jjustincc :: r5c9086ade688 /OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs:

 Fix issue where a dns resolution failure on the final destination might leave the user unable to teleport since the transit flag was not being reset.

This moves the 'already in transit' check further up and resets the flag if dns resolution fails and in the new required places.

Commit by jjustincc :: rcd225215b128 /OpenSim/Region/CoreModules/Framework/EntityTransfer/EntityTransferModule.cs:

Now that the EntityTransferModule is per-region, fetch the event queue module once rather than repeatedly via scene presences

Commit by jjustincc :: r38ce9d45a523 /OpenSim/ (6 files in 4 dirs):

Make ISimulationScene.GetScene() used the more efficient region id for lookup rather than the region handle.

Commit by jjustincc :: rf4cd4c8e284c /OpenSim/Region/CoreModules/World/Archiver/ArchiveWriteRequestPreparation.cs:

Comment out accidentally left in log line that was printing out the control file on OAR save

Commit by jjustincc :: r459c7635afdb /OpenSim/Region/ (6 files in 5 dirs):

 If an agent is still registered as 'in transit' by the source region, don't allow an immediate teleport back.

This is to help relieve a race condition when an agent teleports then immediately attempts to teleport back before the source region has properly cleaned up/demoted the old ScenePresence.
This is rare in viewers but much more possible via scripting or region module.
However, more needs to be done since virtually all clean up happens after the transit flag is cleared .
Possibly need to add a 'cleaning up' state to in transit.
This change required making the EntityTransferModule and HGEntityTransferModule per-region rather than shared, in order to allow separate transit lists.
Changes were also required in LocalSimulationConnector.
Tested in standalone, grid and with local and remote region crossings with attachments.