Commit by jsimon :: r1194297 plugins/trunk/koffice/plugins/chartshape/PlotArea.cpp: (link)

Follow-up to boud's warning fixes

Commit by jsimon :: r1193999 step/trunk/KDE/kdeedu/step/step/worldscene.cc: (link)

Backport fix from 5.3 branch: Do not crash when creating an item

Commit by jsimon :: r1193995 step/branches/KDE/4.5/kdeedu/step/step/worldscene.cc: (link)

Do not crash when creating an item

Commit by jsimon :: r1193921 plugins/trunk/koffice/plugins/chartshape/Axis.cpp: (link)

Properly fall back to a bar chart when an unsupported chart type is loaded so that we do not crash

Commit by jsimon :: r1189711 plugins/trunk/koffice/plugins/chartshape/DataSet.cpp: (link)

Use numDimensions() from kchart_global.h

Commit by jsimon :: r1188310 plugins/trunk/koffice/plugins/chartshape/kdchart/src/KDChartModelDataCache_p.h: (link)

This check can't be used for columns/rowsRemoved() because it is called after the column/row was removed from the model, thus asking the model if the row being removed is valid doesn't work.

Sebastian, I saw you made the change. Please verify the fix. Although I like the additional asserts, I don't see why we should silently ignore any inconsistency (lines 213 and 302). Is there a certain case that requires tolerating them?

See r1187158.

CCMAIL: sebastian dot sauer at kdab dot com

Commit by jsimon :: r1188309 plugins/trunk/koffice/plugins/chartshape/KDChartModel.cpp: (link)

Split this up into beginResetModel() and endResetModel()

Commit by jsimon :: r1188308 plugins/trunk/koffice/plugins/chartshape/Axis.cpp: (link)

This is automatically done in the diagram's destructor

Commit by jsimon :: r1188232 plugins/trunk/koffice/plugins/chartshape/Axis.cpp: (link)

This is done in the destructor of KDChart::AbstractDiagram now

Commit by jsimon :: r1188231 plugins/trunk/koffice/plugins/chartshape/kdchart/src/KDChartAbstractDiagram.cpp: (link)

Remove diagram from plane in destructor to avoid a dangling (invalid) pointer to this diagram

Commit by jsimon :: r1188230 plugins/trunk/koffice/plugins/chartshape/Axis.cpp: (link)

This has been replaced by code in DataSet::dataValueAttributes()

Commit by jsimon :: r1188174 plugins/trunk/koffice/plugins/chartshape/kdchart/src/KDChartAbstractCoordinatePlane.cpp: (link)

Fix crash in KD Chart that happened if we remove a diagram from a coordinate plane and immediately deleted the diagram, which is legal, but KD Chart didn't expect apparently.

Commit by jsimon :: r1188152 plugins/trunk/koffice/plugins/chartshape/PlotArea.cpp: (link)

Use setGlobalGridAttributes() when possible instead of setting the grid attributes per axis

Commit by jsimon :: r1188151 plugins/trunk/koffice/plugins/chartshape/ (Axis.cpp PlotArea.cpp): (link)

Make sure only the axes that really belong to a chart type are added to the PlotArea's KDChart::Chart instance at a time

Commit by jsimon :: r1188122 plugins/trunk/koffice/plugins/chartshape/kdchart/src/ (4 files): (link)

The abscissa or ordinate orientation isn't fixed in fact, it depends on the diagram type. A lying bar diagram has the axes swapped, in any other case the abscissa is the horizontal axis and the ordinate the vertical.

Commit by jsimon :: r1188120 plugins/trunk/koffice/plugins/chartshape/kdchart/src/KDChartNormalLineDiagram_p.cpp: (link)

Correctly calculate data boundaries (min/max x/y values) in line diagram with missing values

Commit by jsimon :: r1188119 plugins/trunk/koffice/plugins/chartshape/Axis.cpp: (link)

Do not show data points in line diagrams for which there's no value (aka NAN) in the model

Commit by jsimon :: r1187629 plugins/trunk/koffice/plugins/chartshape/Axis.cpp: (link)

Use new KD Chart API and paint axis line (otherwise we couldn't apply the axis stroke style to it)

Commit by jsimon :: r1187628 plugins/trunk/koffice/plugins/chartshape/PlotArea.cpp: (link)

Use either cartesian planes or polar planes, but never both at the same time. Otherwise the attributes of the other type will be visible even though they shouldn't (e.g. frame of so-called wall in a pie chart, which doesn't make sense)

Commit by jsimon :: r1187627 plugins/trunk/koffice/plugins/chartshape/ (9 files): (link)

Get this style stack thing right and use it consistenly, always using clear() before using it as really only the style of the element being loaded is of interest, not any other styles. So, there's no problem with using the style stack from the odf loading context, we just need to clear it before using it.

CCMAIL: bjoern dot breitmeyer at kdab dot com