Commit by jstubbs :: r883081 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp:

The window needs to be cleared as well as sending the expose event for qt3,
gtk and other "normal" systray implementations to repaint properly. It turns
out that Qt4 paints the entire window.

Commit by jstubbs :: r881960 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpp:

Forgot to disconnect after monitoring is no longer required (which also
prevents the signal from being connected multiple times).

Commit by jstubbs :: r881959 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/ (x11embedpainter.cpp x11embedpainter.h):

It's possible that a container that is scheduled to get a new background
gets deleted before the update happens. This makes sure there's no
dangling pointers!

Commit by jstubbs :: r881876 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/ (2 files):

Consolidated the timer checks into the painter and increased the limit from
10 times to 20 times per second as painting is not so heavy now. Had also
forgotten to clear the "to-be-updated" list after updating.

Commit by jstubbs :: r881871 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpp:

I didn't use a QRegion originally because united(const QRect&) was added in
4.4. It turns out that there is also a united(const QRegion&) that was added
in 4.2. So, going with QRegion as it may mean less painting.

Commit by jstubbs :: r881870 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ (5 files in 2 dirs):

Paints usually originate somewhere up the parent chain making all icons
repaint at the same time. Prior to this commit, each icon called render on
the parent meaning that, for example, the panel was being painted to an
offscreen pixmap as many times as there are icons. This commit consolidates
those offscreen paints into one, meaning that with 10 icons there is a 10x
speedup. :)

After this, I'll move the paint compression/timer stuff over as well to
cut down on the timers.

Commit by jstubbs :: r881857 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp:

Ensure that there are no more than 10 paints per second of tray icons as it
can be quite CPU intensive.

Commit by jstubbs :: r881504 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp:

Set the recursive-paint-prevention flag on the first paint event to ensure
multiple (redundant) signals aren't queued on the timer.

Commit by jstubbs :: r881499 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp:

SVN_SILENT: disentangling branches

Commit by jstubbs :: r881492 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/ (applet.cpp compactlayout.cpp):

Seeing as the background is always being drawn, always attempt to place icons
within the appropriate area. This actually brings the behaviour back in line
with 4.1 with regard to when two or more rows are shown and gives a more
visually pleasing experience.

Icon minimum sizes are also now taken into account, which essentially causes
icons to be centered rather than top(left)-aligned when the panel becomes too
small to fit a whole icon.

Commit by jstubbs :: r874855 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp:

SVN_SILENT: Typo

Commit by jstubbs :: r874854 workspace/trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/ (2 files):

SVN_SILENT: Cosmetic changes...

Commit by jstubbs :: r868746 plasma/trunk/playground/base/plasma/applets/systray-refactor/TODO:

Updated the TODO...

Commit by jstubbs :: r868523 plasma/trunk/playground/base/plasma/applets/systray-refactor/TODO:

More TODOs before kdereview ;)

Commit by jstubbs :: r868523 /trunk/playground/base/plasma/applets/systray-refactor/TODO:

More TODOs before kdereview ;)

Commit by jstubbs :: r868140 plasma/trunk/playground/base/plasma/applets/systray-refactor/ (TODO ui/applet.h):

Overriding the default hoverEnterEvent and hoverLeaveEvent handlers as they
call update(), which is not required.

There is still a pointless update when the mouse cursor enters the panel,
though. It appears to be coming from Plasma::Containment and is causing
everything to repaint. There's an unexplained FIXME that's related to
Qt-4.4 that needs to be checked in order to fix this issue.

CCMAIL: plasma-devel at kde dot org

Commit by jstubbs :: r868140 /trunk/playground/base/plasma/applets/systray-refactor/ (TODO ui/applet.h):

Overriding the default hoverEnterEvent and hoverLeaveEvent handlers as they
call update(), which is not required.

There is still a pointless update when the mouse cursor enters the panel,
though. It appears to be coming from Plasma::Containment and is causing
everything to repaint. There's an unexplained FIXME that's related to
Qt-4.4 that needs to be checked in order to fix this issue.

CCMAIL: plasma-devel at kde dot org

Commit by jstubbs :: r867991 plasma/trunk/playground/base/plasma/applets/systray-refactor/ui/ (applet.cpp applet.h):

Got rid of the applet layout altogether. Manual Layouting in the panel when
there's a background is now correct (again). Also fixed initial layouting
when on the desktop.

Commit by jstubbs :: r867991 /trunk/playground/base/plasma/applets/systray-refactor/ui/ (applet.cpp applet.h):

Got rid of the applet layout altogether. Manual Layouting in the panel when
there's a background is now correct (again). Also fixed initial layouting
when on the desktop.

Commit by jstubbs :: r867976 /trunk/playground/base/plasma/applets/systray-refactor/ui/ (2 files):

Clear icon as well as the actions when detached such that detached
non-interactive notifications don't change appearance between plasma
restarts.