http://cia.vc/stats/author/jstubbs801 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 883F31D800D for <cia@cia.navi.cx>; Tue, 11 Nov 2008 20:00:13 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id F2F6C122 for <cia@cia.navi.cx>; Wed, 12 Nov 2008 05:00:02 +0100 (CET)
(nullmailer pid 2117 invoked by uid 50745); Wed, 12 Nov 2008 04:00:02 -0000
sysadmin@kde.org
Wed, 12 Nov 2008 04:00:02 +0000
<1226462402.962735.2116.nullmailer@svn.kde.org>
 KDE workspace 883081 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp The window needs to be cleared as well as sending the expose event for qt3, gtk and other "normal" systray implementations to repaint properly. It turns out that Qt4 paints the entire window. 26 1226462413 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 459FD1D8217 for <cia@cia.navi.cx>; Sun, 9 Nov 2008 04:50:53 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 315C3AC for <cia@cia.navi.cx>; Sun, 9 Nov 2008 13:50:40 +0100 (CET)
(nullmailer pid 29965 invoked by uid 50745); Sun, 09 Nov 2008 12:50:40 -0000
sysadmin@kde.org
Sun, 09 Nov 2008 12:50:40 +0000
<1226235040.163193.29964.nullmailer@svn.kde.org>
 KDE workspace 881960 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpp Forgot to disconnect after monitoring is no longer required (which also prevents the signal from being connected multiple times). 14 1226235083 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 7EE7B1D8210 for <cia@cia.navi.cx>; Sun, 9 Nov 2008 04:47:41 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id AD13AAC for <cia@cia.navi.cx>; Sun, 9 Nov 2008 13:47:30 +0100 (CET)
(nullmailer pid 29890 invoked by uid 50745); Sun, 09 Nov 2008 12:47:30 -0000
sysadmin@kde.org
Sun, 09 Nov 2008 12:47:30 +0000
<1226234850.677073.29889.nullmailer@svn.kde.org>
 KDE workspace 881959 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpptrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.h It's possible that a container that is scheduled to get a new background gets deleted before the update happens. This makes sure there's no dangling pointers! 47 1226234886 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 720F11D8210 for <cia@cia.navi.cx>; Sun, 9 Nov 2008 00:42:20 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id D1544AC for <cia@cia.navi.cx>; Sun, 9 Nov 2008 09:42:09 +0100 (CET)
(nullmailer pid 18993 invoked by uid 50745); Sun, 09 Nov 2008 08:42:09 -0000
sysadmin@kde.org
Sun, 09 Nov 2008 08:42:09 +0000
<1226220129.822413.18992.nullmailer@svn.kde.org>
 KDE workspace 881876 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpptrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpp Consolidated the timer checks into the painter and increased the limit from 10 times to 20 times per second as painting is not so heavy now. Had also forgotten to clear the "to-be-updated" list after updating. 141 1226220140 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 07D911D8210 for <cia@cia.navi.cx>; Sun, 9 Nov 2008 00:24:06 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 613CAAC for <cia@cia.navi.cx>; Sun, 9 Nov 2008 09:23:55 +0100 (CET)
(nullmailer pid 18542 invoked by uid 50745); Sun, 09 Nov 2008 08:23:55 -0000
sysadmin@kde.org
Sun, 09 Nov 2008 08:23:55 +0000
<1226219035.366232.18541.nullmailer@svn.kde.org>
 KDE workspace 881871 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpp I didn't use a QRegion originally because united(const QRect&) was added in 4.4. It turns out that there is also a united(const QRegion&) that was added in 4.2. So, going with QRegion as it may mean less painting. 27 1226219046 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 6671B1D8210 for <cia@cia.navi.cx>; Sun, 9 Nov 2008 00:14:51 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 45D10AC for <cia@cia.navi.cx>; Sun, 9 Nov 2008 09:14:40 +0100 (CET)
(nullmailer pid 18335 invoked by uid 50745); Sun, 09 Nov 2008 08:14:40 -0000
sysadmin@kde.org
Sun, 09 Nov 2008 08:14:40 +0000
<1226218480.254293.18334.nullmailer@svn.kde.org>
 KDE workspace 881870 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/CMakeLists.txttrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpptrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.htrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.cpptrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedpainter.h Paints usually originate somewhere up the parent chain making all icons repaint at the same time. Prior to this commit, each icon called render on the parent meaning that, for example, the panel was being painted to an offscreen pixmap as many times as there are icons. This commit consolidates those offscreen paints into one, meaning that with 10 icons there is a 10x speedup. :) After this, I'll move the paint compression/timer stuff over as well to cut down on the timers. 382 1226218491 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 608E51D8210 for <cia@cia.navi.cx>; Sat, 8 Nov 2008 21:23:37 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 75803AC for <cia@cia.navi.cx>; Sun, 9 Nov 2008 06:23:26 +0100 (CET)
(nullmailer pid 13123 invoked by uid 50745); Sun, 09 Nov 2008 05:23:26 -0000
sysadmin@kde.org
Sun, 09 Nov 2008 05:23:26 +0000
<1226208206.448353.13122.nullmailer@svn.kde.org>
 KDE workspace 881857 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp Ensure that there are no more than 10 paints per second of tray icons as it can be quite CPU intensive. 67 1226208218 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 691331D8215 for <cia@cia.navi.cx>; Sat, 8 Nov 2008 03:29:39 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id DB9F5AC for <cia@cia.navi.cx>; Sat, 8 Nov 2008 12:29:28 +0100 (CET)
(nullmailer pid 32678 invoked by uid 50745); Sat, 08 Nov 2008 11:29:28 -0000
sysadmin@kde.org
Sat, 08 Nov 2008 11:29:28 +0000
<1226143768.857576.32677.nullmailer@svn.kde.org>
 KDE workspace 881504 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp Set the recursive-paint-prevention flag on the first paint event to ensure multiple (redundant) signals aren't queued on the timer. 21 1226143780 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 6B4AA1D8216 for <cia@cia.navi.cx>; Sat, 8 Nov 2008 03:23:25 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 87FD2173 for <cia@cia.navi.cx>; Sat, 8 Nov 2008 12:23:14 +0100 (CET)
(nullmailer pid 32135 invoked by uid 50745); Sat, 08 Nov 2008 11:23:14 -0000
sysadmin@kde.org
Sat, 08 Nov 2008 11:23:14 +0000
<1226143394.525562.32134.nullmailer@svn.kde.org>
 KDE workspace 881499 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp SVN_SILENT: disentangling branches 21 1226143408 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id EB2561D8215 for <cia@cia.navi.cx>; Sat, 8 Nov 2008 03:16:49 -0800 (PST)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 61625AC for <cia@cia.navi.cx>; Sat, 8 Nov 2008 12:16:39 +0100 (CET)
(nullmailer pid 31624 invoked by uid 50745); Sat, 08 Nov 2008 11:16:39 -0000
sysadmin@kde.org
Sat, 08 Nov 2008 11:16:39 +0000
<1226142999.366412.31623.nullmailer@svn.kde.org>
 KDE workspace 881492 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpptrunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/compactlayout.cpp Seeing as the background is always being drawn, always attempt to place icons within the appropriate area. This actually brings the behaviour back in line with 4.1 with regard to when two or more rows are shown and gives a more visually pleasing experience. Icon minimum sizes are also now taken into account, which essentially causes icons to be centered rather than top(left)-aligned when the panel becomes too small to fit a whole icon. 117 1226143011 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id AC3561D81C2 for <cia@cia.navi.cx>; Wed, 22 Oct 2008 08:07:03 -0700 (PDT)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 25AB994 for <cia@cia.navi.cx>; Wed, 22 Oct 2008 17:06:53 +0200 (CEST)
(nullmailer pid 28701 invoked by uid 50745); Wed, 22 Oct 2008 15:06:53 -0000
sysadmin@kde.org
Wed, 22 Oct 2008 15:06:53 +0000
<1224688013.123894.28700.nullmailer@svn.kde.org>
 KDE workspace 874855 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp SVN_SILENT: Typo 14 1224747411 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id F15A51D81D3 for <cia@cia.navi.cx>; Wed, 22 Oct 2008 08:06:04 -0700 (PDT)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 60B9190 for <cia@cia.navi.cx>; Wed, 22 Oct 2008 17:05:54 +0200 (CEST)
(nullmailer pid 28631 invoked by uid 50745); Wed, 22 Oct 2008 15:05:54 -0000
sysadmin@kde.org
Wed, 22 Oct 2008 15:05:54 +0000
<1224687954.363869.28630.nullmailer@svn.kde.org>
 KDE workspace 874854 jstubbs trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/fdographicswidget.cpptrunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/fdo/x11embedcontainer.cpp SVN_SILENT: Cosmetic changes... 33 1224747407 Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id C1DA41D8145 for <cia@cia.navi.cx>; Mon, 6 Oct 2008 17:49:45 -0700 (PDT)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 9F55718D for <cia@cia.navi.cx>; Tue, 7 Oct 2008 02:49:34 +0200 (CEST)
(nullmailer pid 1979 invoked by uid 50745); Tue, 07 Oct 2008 00:49:34 -0000
sysadmin@kde.org
Tue, 07 Oct 2008 00:49:34 +0000
<1223340574.617133.1978.nullmailer@svn.kde.org>
 KDE plasma 868746 jstubbs trunk/playground/base/plasma/applets/systray-refactor/TODO Updated the TODO... 15 12233405861223299257Built-in Subversion repository interface1.0KDE-India868523jstubbsMore TODOs before kdereview ;) trunk/playground/base/plasma/applets/systray-refactor/TODO Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 73B4A1D80B9 for <cia@cia.navi.cx>; Mon, 6 Oct 2008 06:21:15 -0700 (PDT)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id E6CF3188 for <cia@cia.navi.cx>; Mon, 6 Oct 2008 15:20:57 +0200 (CEST)
(nullmailer pid 5568 invoked by uid 50745); Mon, 06 Oct 2008 13:20:57 -0000
sysadmin@kde.org
Mon, 06 Oct 2008 13:20:57 +0000
<1223299257.913558.5567.nullmailer@svn.kde.org>
 KDE plasma 868523 jstubbs trunk/playground/base/plasma/applets/systray-refactor/TODO More TODOs before kdereview ;) 21 12232992991223219311Built-in Subversion repository interface1.0KDE-India868140jstubbsOverriding the default hoverEnterEvent and hoverLeaveEvent handlers as they call update(), which is not required. There is still a pointless update when the mouse cursor enters the panel, though. It appears to be coming from Plasma::Containment and is causing everything to repaint. There's an unexplained FIXME that's related to Qt-4.4 that needs to be checked in order to fix this issue. CCMAIL: plasma-devel@kde.org trunk/playground/base/plasma/applets/systray-refactor/TODOtrunk/playground/base/plasma/applets/systray-refactor/ui/applet.h Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id C85631D80B9 for <cia@cia.navi.cx>; Sun, 5 Oct 2008 08:08:44 -0700 (PDT)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 3B6F818E for <cia@cia.navi.cx>; Sun, 5 Oct 2008 17:08:32 +0200 (CEST)
(nullmailer pid 8472 invoked by uid 50745); Sun, 05 Oct 2008 15:08:32 -0000
sysadmin@kde.org
Sun, 05 Oct 2008 15:08:32 +0000
<1223219312.212380.8470.nullmailer@svn.kde.org>
 KDE plasma 868140 jstubbs trunk/playground/base/plasma/applets/systray-refactor/TODOtrunk/playground/base/plasma/applets/systray-refactor/ui/applet.h Overriding the default hoverEnterEvent and hoverLeaveEvent handlers as they call update(), which is not required. There is still a pointless update when the mouse cursor enters the panel, though. It appears to be coming from Plasma::Containment and is causing everything to repaint. There's an unexplained FIXME that's related to Qt-4.4 that needs to be checked in order to fix this issue. CCMAIL: plasma-devel@kde.org 31 12232196241223190316Built-in Subversion repository interface1.0KDE-India867991jstubbsGot rid of the applet layout altogether. Manual Layouting in the panel when there's a background is now correct (again). Also fixed initial layouting when on the desktop. trunk/playground/base/plasma/applets/systray-refactor/ui/applet.cpptrunk/playground/base/plasma/applets/systray-refactor/ui/applet.h Subversion CIA Bot client shell script 1.0
from office.kde.org (kde.suse.de [195.135.221.67]) by cia.vc (Postfix) with ESMTP id 44D7C1D80E1 for <cia@cia.navi.cx>; Sun, 5 Oct 2008 00:07:18 -0700 (PDT)
from svn.kde.org (localhost [127.0.0.1]) by office.kde.org (Postfix) with SMTP id 73D14186 for <cia@cia.navi.cx>; Sun, 5 Oct 2008 09:05:17 +0200 (CEST)
(nullmailer pid 17813 invoked by uid 50745); Sun, 05 Oct 2008 07:05:17 -0000
sysadmin@kde.org
Sun, 05 Oct 2008 07:05:17 +0000
<1223190317.442356.17812.nullmailer@svn.kde.org>
 KDE plasma 867991 jstubbs trunk/playground/base/plasma/applets/systray-refactor/ui/applet.cpptrunk/playground/base/plasma/applets/systray-refactor/ui/applet.h Got rid of the applet layout altogether. Manual Layouting in the panel when there's a background is now correct (again). Also fixed initial layouting when on the desktop. 163 12231904431223185503Built-in Subversion repository interface1.0KDE-India867976jstubbsClear icon as well as the actions when detached such that detached non-interactive notifications don't change appearance between plasma restarts. trunk/playground/base/plasma/applets/systray-refactor/ui/notificationwidget.htrunk/playground/base/plasma/applets/systray-refactor/ui/notificationwidget.cpp