Commit by majewsky :: r1278817 kblackbox/trunk/KDE/kdegames/kblackbox/ (2 files): (link)

KBlackBox: Remove KGameLCD dependency (replace with QLCDNumber).

This removes the highlight() calls, which are not present in QLCDNumber,
but it's not a big loss since highlighting is broken anyway.

Commit by majewsky :: r1278816 libkdegames/trunk/KDE/kdegames/libkdegames/configure.in.in: (link)

remove configure.in.in

It's about time we can live without that file.

Commit by majewsky :: r1271918 palapeli/branches/KDE/4.8/kdegames/palapeli/src/file-io/puzzle.cpp: (link)

Backport revision 1271914 from trunk.

CCBUG: 288285

Commit by majewsky :: r1271914 palapeli/trunk/KDE/kdegames/palapeli/src/file-io/puzzle.cpp: (link)

Secure Palapeli::Puzzle::m_allFutures with a mutex.

BUG: 288285

Thanks for the reminder, Christoph. This got off my radar somehow.

Commit by majewsky :: r1260225 kolf/trunk/KDE/kdegames/kolf/ (graphics/default_theme.svgz newgame.cpp): (link)

Adjust ball styling and player colors.

The ball is semi-transparent now so the player color (which is already
drawn as an ellipse below the ball) becomes visible.

The default colors for the first two players are now blue and red; these
are easily visible and distinguishable as ball colors.

Commit by majewsky :: r1257774 kapman/branches/KDE/4.7/kdegames/ (4 files in 3 dirs): (link)

On X11, choose raster graphicssystem automatically in libkdegames apps.

Backport of revision 1257773 from trunk.

The QApplication::setGraphicsSystem calls in Kapman and Palapeli are
removed, as libkdegames does now care about this.

CCBUG: 277590

Commit by majewsky :: r1257773 kapman/trunk/KDE/kdegames/ (4 files in 3 dirs): (link)

On X11, choose raster graphicssystem automatically in libkdegames apps.

The QApplication::setGraphicsSystem calls in Kapman and Palapeli are
removed, as libkdegames does now care about this.

DIGEST: This quite improves the rendering performance on Qt <= 4.7.

BUG: 277590
FIXED-IN: 4.7.3

Commit by majewsky :: r1257156 kbounce/branches/KDE/4.7/kdegames/kbounce/gamewidget.cpp: (link)

Fix text rendering with raster graphicssystem.

Backport of revision 1257154 from trunk.

Commit by majewsky :: r1257154 kbounce/trunk/KDE/kdegames/kbounce/gamewidget.cpp: (link)

Fix text rendering with raster graphicssystem.

Commit by majewsky :: r1257072 kolf/trunk/KDE/kdegames/kolf/ (5 files): (link)

Fix some more Z-ordering bugs with static struts and b2ContactListener.

As described in bug 280943, the problem is that the old b2ContactFilter
implementation detected wall-ball collisions too early (when the AABBs
of the participating objects touched for the first time). Especially for
diagonal walls, the ball has not yet been strutted when ShouldCollide()
is called.

This problem is solved by switching from b2ContactFilter to
b2ContactListener, which kicks in only when a collision has really been
detected. (The contact is then disabled if appropriate, as recommended
by the Box2D manual.)

This solution unfortunately introduces a new problem: Walls around
RectangleItems are now invisible for balls coming from inside the
RectangleItem (e.g. bridges and windmills). Actually I have no idea why
this problem didn't appear previously. I solve this by introducing the
notion of "static struts": The rectangle item is the static strut for
its walls and raises them all, even if they are not colliding with the
rectangle item (WindmillGuard, you're an a**hole).

BUG: 280943
FIXED-IN: 4.8

Commit by majewsky :: r1256966 kolf/trunk/KDE/kdegames/kolf/canvasitem.cpp: (link)

Keep objects with FixedZValue magically changing its Z value.

I discovered this inexplicable behavior while debugging bug 280943: The
wall in question has a Z value of 100, although the Z behavior for walls
is configured as (FixedZValue, 5). 100 is the Z value for struts. What's
going on there?
CCBUG: 280943

Commit by majewsky :: r1253668 konquest/trunk/KDE/kdegames/konquest/ (5 files in 4 dirs): (link)

krazy

pinaraf, please add the missing licenses in the players/ directory.

Commit by majewsky :: r1243946 kdiamond/trunk/KDE/kdegames/ (5 files in 3 dirs): (link)

Replace reinterpret_cast by safer casts.

It's mostly qobject_cast now, except when that cannot be used, e.g.
while handling a QObject::destroyed signal. But then, I make it clear
now why it cannot be used.

Commit by majewsky :: r1243945 libkdegames/trunk/KDE/kdegames/libkdegames/kgamerenderer.cpp: (link)

KGameRenderer: more memleak fixes, this time in theme switching

Commit by majewsky :: r1243122 libkdegames/trunk/KDE/kdegames/libkdegames/kgamerenderer.cpp: (link)

KGameRenderer: fix a memleak

Found via Valgrind. Only affects synchronously fetched pixmaps.

Commit by majewsky :: r1240604 bovo/trunk/KDE/kdegames/ (6 files in 6 dirs): (link)

consistency: remove borders around game canvases

Most games already have a game canvas without margins and frames. This
commit removes these borders everywhere. The main motivation is
consistency, but I also think that no borders have other advantages:

1. They look much better with borderless window decorations.
2. Frames induce an additional rendering cost which can be avoided.
3. Frames are usually used for visual grouping, but this is not
   necessary for a game canvas with its intense themed appearance.
4. QGraphicsView has problems with establishing a 1:1 relation between
   scene and view coordinates when it has a frame.
5. Also 4px horizontal and vertical space saved!!!! ;-)

If you are the maintainer of one of the affected games and object to
this change, please let me know.
CCMAIL: kde-games-devel at kde dot org

Commit by majewsky :: r1240603 kreversi/trunk/KDE/kdegames/kreversi/ (mainwindow.cpp mainwindow.h): (link)

KReversi: replace layout in centralWidget by dock widget

This also fixes the ugly 1px margin around the game canvas.

Commit by majewsky :: r1234271 knetwalk/trunk/KDE/kdegames/knetwalk/src/fielditem.cpp: (link)

Don't show the score dialog twice if the game ends with two simultaneously running animations.

BUG: 259558
FIXED-IN: 4.7

Commit by majewsky :: r1234269 palapeli/trunk/KDE/kdegames/palapeli/src/file-io/puzzle.cpp: (link)

fix a 3AM-grade line of code (i.e. the quality which one writes at 3AM)

Commit by majewsky :: r1234265 kolf/trunk/KDE/kdegames/kolf/newgame.cpp: (link)

Fix a crash in Kolf NewGame::courseSelected.

BUG: 274418
FIXED-IN: 4.7

I do not see why this bug should ever be triggered with QAbstractItemView::SingleSelection, but meh...