Commit by mgiuca on roundup :: #3565/array documentation, method names not 3.x-compliant: (link)

There are still some inconsistencies in the documentation (in particular, incorrectly using the word "string" to refer to a bytes object, which ma ...

Commit by mgiuca on roundup :: #8821/Range check on unicode repr: (link)

> I think that we have good reasons to not remove the NUL character.

 Please note: Nobody is suggesting that we remove the NUL character. I was  ...

Commit by mgiuca on roundup :: #8821/Range check on unicode repr: (link)

OK, I finally had time to review this issue again.

 Firstly, granted the original fix broke a test case, shouldn't we figure out why it broke an ...

Commit by mgiuca on roundup :: #1712522/urllib.quote throws exception on Unicode URL: (link)

If you're going the way of option 2, I would strongly advise against relying on the KeyError. The fact that a KeyError is raised by urllib.quote i ...

Commit by mgiuca on roundup :: #1712522/urllib.quote throws exception on Unicode URL: (link)

OK sure, there are some other things broken, but they are mostly not dealing with string data, but binary data (for example, zlib expects a sequen ...

Commit by mgiuca on roundup :: #1712522/urllib.quote throws exception on Unicode URL: (link)

> I think everyone assumed that the parameter should be a "str" object
 > and nothing else. Apparently some people used it accidentally with
 > so ...

Commit by mgiuca on roundup :: #1712522/urllib.quote throws exception on Unicode URL: (link)

> Well, isn't it a new feature you're adding?

 You had a function which raised a confusing and unintentional KeyError when given non-ASCII Unico ...

Commit by mgiuca on roundup :: #1712522/urllib.quote throws exception on Unicode URL: (link)

From http://mail.python.org/pipermail/python-checkins/2010-July/095350.html:
 > Looking at the issue (which in itself was quite old), you could as ...

Commit by mgiuca on roundup :: #1712522/urllib.quote throws exception on Unicode URL: (link)

Thanks for doing that, Senthil.

Commit by mgiuca on roundup :: #8987/Distutils doesn't quote Windows command lines properly: (link)

[new] I discovered this investigating a bug report that python-cjson doesn't compile properly on Windows (http://pypi.python.org/pypi/python-cjson ...

Commit by mgiuca on roundup :: #8821/Range check on unicode repr: (link)

[new] In unicodeobject.c's unicodeescape_string, in UCS2 builds, if the last character of the string is the start of a UTF-16 surrogate pair (betw ...

Commit by mgiuca on roundup :: #8143/urlparse has a duplicate of urllib.unquote: (link)

What about the alternative (newmodule) patch? That doesn't have threading issues, or break backwards compatibility.

Commit by mgiuca on roundup :: #8135/urllib.unquote doesn't decode mixed-case percent escapes: (link)

Thanks very much. Importantly, note that unquote is currently duplicated between urllib and urlparse. I have a bug on it (#8143) but in the meanti ...

Commit by mgiuca on roundup :: #8143/urlparse has a duplicate of urllib.unquote: (link)

If this patch is rejected, then at the very least, the urllib.unquote function needs a comment at the top explaining that it is duplicated in urlp ...

Commit by mgiuca on roundup :: #8135/urllib.unquote doesn't decode mixed-case percent escapes: (link)

Tiny fix to patch2 -- replaced list comprehension with generator expression in dictionary construction.

Commit by mgiuca on roundup :: #8135/urllib.unquote doesn't decode mixed-case percent escapes: (link)

I thought more about it, and wrote a different patch which doesn't remove the dictionary. I just replaced the dictionary creation code -- now it i ...

Commit by mgiuca on roundup :: #8136/urllib.unquote decodes percent-escapes with Latin-1: (link)

Oh, I just discovered that urlparse contains a copy of unquote, which will also need to be patched. I've submitted a patch to remove the duplicate ...

Commit by mgiuca on roundup :: #8135/urllib.unquote doesn't decode mixed-case percent escapes: (link)

Oh, I just discovered that urlparse contains a copy of unquote, which will also need to be patched. I've submitted a patch to remove the duplicate ...

Commit by mgiuca on roundup :: #8143/urlparse has a duplicate of urllib.unquote: (link)

[new] urlparse contains a complete copy of the urllib.unquote function. This is extremely nasty code duplication -- I have two patches pending on ...

Commit by mgiuca on roundup :: #8135/urllib.unquote doesn't decode mixed-case percent escapes: (link)

> Note: I've also backported the remainder of the 'unquote' test cases
 > from Python 3 but I found another bug, so I will report that separately, ...