http://cia.vc/stats/author/mgiuca97Roundup Reactor for CIA69784Python#3565roundupmgiucaarray documentation, method names not 3.x-compliantThere are still some inconsistencies in the documentation (in particular, incorrectly using the word "string" to refer to a bytes object, which ma ...http://bugs.python.org/issue35651310534540Roundup Reactor for CIA69784Python#8821roundupmgiucaRange check on unicode repr> I think that we have good reasons to not remove the NUL character.
Please note: Nobody is suggesting that we remove the NUL character. I was ...http://bugs.python.org/issue88211293676641Roundup Reactor for CIA69784Python#8821roundupmgiucaRange check on unicode reprOK, I finally had time to review this issue again.
Firstly, granted the original fix broke a test case, shouldn't we figure out why it broke an ...http://bugs.python.org/issue88211280755026Roundup Reactor for CIA69784Python#1712522roundupmgiucaurllib.quote throws exception on Unicode URLIf you're going the way of option 2, I would strongly advise against relying on the KeyError. The fact that a KeyError is raised by urllib.quote i ...http://bugs.python.org/issue17125221279765135Roundup Reactor for CIA69784Python#1712522roundupmgiucaurllib.quote throws exception on Unicode URLOK sure, there are some other things broken, but they are mostly not dealing with string data, but binary data (for example, zlib expects a sequen ...http://bugs.python.org/issue17125221279549592Roundup Reactor for CIA69784Python#1712522roundupmgiucaurllib.quote throws exception on Unicode URL> I think everyone assumed that the parameter should be a "str" object
> and nothing else. Apparently some people used it accidentally with
> so ...http://bugs.python.org/issue17125221279544006Roundup Reactor for CIA69784Python#1712522roundupmgiucaurllib.quote throws exception on Unicode URL> Well, isn't it a new feature you're adding?
You had a function which raised a confusing and unintentional KeyError when given non-ASCII Unico ...http://bugs.python.org/issue17125221279538495Roundup Reactor for CIA69784Python#1712522roundupmgiucaurllib.quote throws exception on Unicode URLFrom http://mail.python.org/pipermail/python-checkins/2010-July/095350.html:
> Looking at the issue (which in itself was quite old), you could as ...http://bugs.python.org/issue17125221279538284Roundup Reactor for CIA69784Python#1712522roundupmgiucaurllib.quote throws exception on Unicode URLThanks for doing that, Senthil.http://bugs.python.org/issue17125221279502462Roundup Reactor for CIA69784Python#8987roundupmgiucaDistutils doesn't quote Windows command lines properly[new] I discovered this investigating a bug report that python-cjson doesn't compile properly on Windows (http://pypi.python.org/pypi/python-cjson ...http://bugs.python.org/issue89871276406572Roundup Reactor for CIA69784Python#8821roundupmgiucaRange check on unicode repr[new] In unicodeobject.c's unicodeescape_string, in UCS2 builds, if the last character of the string is the start of a UTF-16 surrogate pair (betw ...http://bugs.python.org/issue88211274847112Roundup Reactor for CIA69784Python#8143roundupmgiucaurlparse has a duplicate of urllib.unquoteWhat about the alternative (newmodule) patch? That doesn't have threading issues, or break backwards compatibility.http://bugs.python.org/issue81431268706916Roundup Reactor for CIA69784Python#8135roundupmgiucaurllib.unquote doesn't decode mixed-case percent escapesThanks very much. Importantly, note that unquote is currently duplicated between urllib and urlparse. I have a bug on it (#8143) but in the meanti ...http://bugs.python.org/issue81351268644016Roundup Reactor for CIA69784Python#8143roundupmgiucaurlparse has a duplicate of urllib.unquoteIf this patch is rejected, then at the very least, the urllib.unquote function needs a comment at the top explaining that it is duplicated in urlp ...http://bugs.python.org/issue81431268621767Roundup Reactor for CIA69784Python#8135roundupmgiucaurllib.unquote doesn't decode mixed-case percent escapesTiny fix to patch2 -- replaced list comprehension with generator expression in dictionary construction.http://bugs.python.org/issue81351268618308Roundup Reactor for CIA69784Python#8135roundupmgiucaurllib.unquote doesn't decode mixed-case percent escapesI thought more about it, and wrote a different patch which doesn't remove the dictionary. I just replaced the dictionary creation code -- now it i ...http://bugs.python.org/issue81351268618047Roundup Reactor for CIA69784Python#8136roundupmgiucaurllib.unquote decodes percent-escapes with Latin-1Oh, I just discovered that urlparse contains a copy of unquote, which will also need to be patched. I've submitted a patch to remove the duplicate ...http://bugs.python.org/issue81361268615373Roundup Reactor for CIA69784Python#8135roundupmgiucaurllib.unquote doesn't decode mixed-case percent escapesOh, I just discovered that urlparse contains a copy of unquote, which will also need to be patched. I've submitted a patch to remove the duplicate ...http://bugs.python.org/issue81351268615310Roundup Reactor for CIA69784Python#8143roundupmgiucaurlparse has a duplicate of urllib.unquote[new] urlparse contains a complete copy of the urllib.unquote function. This is extremely nasty code duplication -- I have two patches pending on ...http://bugs.python.org/issue81431268615208Roundup Reactor for CIA69784Python#8135roundupmgiucaurllib.unquote doesn't decode mixed-case percent escapes> Note: I've also backported the remainder of the 'unquote' test cases
> from Python 3 but I found another bug, so I will report that separately, ...http://bugs.python.org/issue81351268570299