Commit by michael.foord on roundup :: #14770/Minor documentation fixes: (link)

[new] A bunch of minor fixes for the documentation suggested by Kurt Robinson to the webmaster email address:


 Below, you will find 15 snippet ...

Commit by michael.foord on roundup :: #14558/Documentation for unittest.main does not describe some keyword arguments.: (link)

A good change - thanks Ezio.

Commit by michael.foord on roundup :: #14664/Skipping a test mixin gives metaclass error: (link)

Thanks Antoine - much appreciated.

Commit by michael.foord on roundup :: #14664/Skipping a test mixin gives metaclass error: (link)

This could go into 2.7 too.

Commit by michael.foord on roundup :: #14664/Skipping a test mixin gives metaclass error: (link)

Patch looks good - thanks.

Commit by michael.foord on roundup :: #14634/Mock cannot autospec functions with keyword-only arguments.: (link)

Hmmm... looks like formatargspec does support these features but they aren't documented. If it works out I'll update the docs for inspect.formatar ...

Commit by michael.foord on roundup :: #14634/Mock cannot autospec functions with keyword-only arguments.: (link)

This is non-trivial to fix. Although inspect.getfullargspec can be used, which does support keyword only arguments, inspect.formatargspec *doesn't ...

Commit by michael.foord on roundup :: #7559/TestLoader.loadTestsFromName swallows import errors: (link)

My favoured fix is to catch the exception and generate a failing test that re-raises the *original exception* (with traceback) when run. That way ...

Commit by michael.foord on roundup :: #14636/Mock could check for exceptions in side effect list: (link)

Seems like a good change.

Commit by michael.foord on roundup :: #14613/time.time can return None or NaN: (link)

So NaN is a possible result from time.time()? Perhaps that should be mentioned in the docs. Is returning NaN preferable to failing with an exception?

Commit by michael.foord on roundup :: #14613/time.time can return None or NaN: (link)

[new] time.time() can return None, or sometimes NaN. If it can't get a "proper" value from the OS then I would expect it to throw an exception. Th ...

Commit by michael.foord on roundup :: #14577/pickling uses __class__ so you can't pickle proxy/mock objects that pretend to be other objects: (link)

Nick - in general proxy objects have a *reference* to their target (weakref being somewhat of a special case), and pickle can already handle multi ...

Commit by michael.foord on roundup :: #14577/pickling uses __class__ so you can't pickle proxy/mock objects that pretend to be other objects: (link)

test_pickle still passes with only copyreg.py modified.

 With one additional change in pickle.py (line 405 to use type(obj) instead of obj.__cl ...

Commit by michael.foord on roundup :: #14577/pickling uses __class__ so you can't pickle proxy/mock objects that pretend to be other objects: (link)

So, changing copyreg.py to use type(self) instead of self.__class__ isn't sufficient. _pickle accesses __class__ as well it seems. However I'm run ...

Commit by michael.foord on roundup :: #14577/pickling uses __class__ so you can't pickle proxy/mock objects that pretend to be other objects: (link)

[new] Pickling uses __class__ instead of type(obj) to determine the type to pickle. This means that objects which pretend to be other objects (lik ...

Commit by michael.foord on roundup :: #11218/pattern=None when following documentation for load_tests and unittest.main(): (link)

Also the patch to allow the pattern to be None (and revert to the default pattern in this case) looks good.

Commit by michael.foord on roundup :: #11218/pattern=None when following documentation for load_tests and unittest.main(): (link)

So the logic of the "pattern" argument to "load_tests" is that it should not be None when test discovery is loading the __init__.py module of a te ...

Commit by michael.foord on roundup :: #14534/Add method to mark unittest.TestCases as "do not run".: (link)

Here are my objections to the standard (but not widely used outside our own tests) mixin pattern for base testcases (copied and pasted from issue ...

Commit by michael.foord on roundup :: #14534/Add method to mark unittest.TestCases as "do not run".: (link)

So the technique I suggested is that the TestLoader checks classes for the "testbase" (or whatever we call it) *in the class dict*. So inheritance ...

Commit by michael.foord on roundup :: #14533/Modify regrtest to make test_main optional: (link)

Looks good to me. Note that if module level setup and teardown is needed for running tests then it should be possible to do this with setUpModule ...