Commit by mklingens :: r637557 kopete/branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/tests/ (2 files):

Make 'make check' work again.

Note that none of the dates in the output were as expected by the test
program.

Since I don't know what is "correct" I blindly adjusted the test to
match reality. If reality is broken, please tell me :)

Michael, can you forward port again?

CCMAIL: Micha?\195?\171l Larouche <larouche at kde dot org>

Commit by mklingens :: r637222 kopete/branches/KDE/3.5/kdenetwork/kopete/libkopete/kopetemessage.cpp:

Make Kopete::Message::unescape a whopping 4 times as fast by eliminating
QRegExp.

Of the remaining cycles, about 2/3rd goes to QString::fromLatin1() and
~QString(), but that can't be optimized in KDE 3.5. (Moving it out of
the loop had actually a negative effect because not all strings are
created as much.) When porting to KDE 4, consider static QLatinStrings
to avoid the creation of those objects altogether.

The other 1/3rd of time goes to the block of QString::replace() calls at
the bottom. Can be optimized relatively trivial by using a similar loop
as the new code for elements, but that is *much* less readable, so I
hope that won't be needed for acceptable speed. Another 75% on code that
just got 50% faster is not bad anyway ;)

Commit by mklingens :: r637208 kopete/branches/KDE/3.5/kdenetwork/kopete/libkopete/tests/kopetemessage_test.cpp:

Add more testcases, otherwise <img> isn't tested and it's special code

Commit by mklingens :: r636734 kopete/branches/KDE/3.5/kdenetwork/kopete/ (3 files in 2 dirs):

Major optimization of the code used by formatStyleKeywords().

In practice this makes the following cases a LOT faster:

• Opening a chat with large amounts of 'old' messages from history
• Browsing history in the chat window with alt-left/right
• Updating the chat window someone changes avatar
• Updating the chat window when switching style Performance improvement initially is about 30% due to optimized Kopete::Message::plainBody() code for determining whether the message is left-to-right or not. Each subsequent call on the same messages will be even about 60% faster because the LTR value is cached. In practice the code is unfortunately still quite slow, but the massive improvement is already quite noticable. Reviewed and approved by Will, also tested against the unit tests.

Commit by mklingens :: r636731 kopete/branches/KDE/3.5/kdenetwork/kopete/libkopete/tests/kopetemessage_test.cpp:

Add several more testcases, fix existing ones

Commit by mklingens :: r634872 kopete/branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/chatmessagepart.cpp:

About 10-20% performance improvement for formatStyleKeywords.

This is important when lots of messages are added to the chat at the
same time, like when browsing history with alt-left/right, or when the
style changes, e.g. when someone is changing display picture.

Especially the latter is unfortunately a fairly common thing, and Kopete
freezes horribly if you have chats open with a person changing pic.

Approved by Michael.

Commit by mklingens :: r628865 kopete/branches/KDE/3.5/kdenetwork/kopete/ (6 files in 4 dirs):

Refactor the emoticon handling to return *all* emoticons including
"alternatives".

Besides being more correct semantically this makes it possible to
"export" all emoticons as custom emoticons via e.g. MSN.

(Note that the latter doesn't work all that reliable though, but that is
the MSN P2P protocol, at least the underlying code is now able to figure
out that something has to be sent in the first place)

Commit by mklingens :: r627923 kopete/branches/KDE/3.5/kdenetwork/kopete/plugins/history/historyviewer.ui:

Use normal margins and don't double them at some places

Commit by mklingens :: r627746 kopete/branches/KDE/3.5/kdenetwork/kopete/protocols/msn/msnsocket.cpp:

Don't dump binary data to kdDebug

Michel, if this also applies to the new MSN lib in KDE 4, please forward
port, I have no KDE 4 checkout here

CCMAIL: Michel Hermier <michel dot hermier at gmail dot com>

Commit by mklingens :: r627734 kopete/branches/KDE/3.5/kdenetwork/kopete/libkopete/ui/kopetelistview.cpp:

SVN_SILENT reorder initializers to avoid a compiler warning

Commit by mklingens :: r455051 /trunk/playground/sysadmin/kextprocess/lib/ (5 files):

Don't use explicit sharing and revert to being purely value based.
Thanks to Simon for the suggestion when he glanced at my code during one
of the talks :)

Commit by mklingens :: r454340 /trunk/playground/sysadmin/kextprocess/lib/profilepropertieswidget.cpp:

enable the buttons properly when changing profile

the gui of the profile editor can use a bit of usability loving, but it
looks like aseigo is still MIA after yesterday's social event, so
that'll have to wait until later :/

Commit by mklingens :: r454324 /trunk/playground/sysadmin/kextprocess/lib/sshprocess.cpp:

Fix SSH: assume 'localhost' if hostname is empty

Commit by mklingens :: r453915 /trunk/playground/sysadmin/kextprocess/lib/profilepropertieswidget.cpp:

Cleanup the enabling/disabling of buttons, in the process fixing a
couple of bugs too

Commit by mklingens :: kdelibs/kresources/README.design:

Help the next person who reads this file to find the referenced
source files :)

Commit by mklingens :: kdeplayground-admin/kextprocess/TODO:

Update the roadmap beyond 0.4, add some ideas that I need to think about

Commit by mklingens :: kdeplayground-admin/kextprocess/lib/ (4 files):

Implement moving steps up and down the list

Commit by mklingens :: kdeplayground-admin/kextprocess/ (4 files in 3 dirs):

Complete the implementation of NullProcess: add isNull() and use it in the
demo app

Commit by mklingens :: kdeplayground-admin/kextprocess/lib/ (3 files):

Add the GUI for loading and saving profiles. There's no logic behind it yet,
apart from the Edit >> button to expand and shrink the window. Took me more
than enough time of its own to get reasonably right, many thanks to geiseri
for the adjustSize() suggestion...
There's one quirk remaining that I can't really think of a solution for: the
combobox is part of a grid layout, but in the small version of the dialog
the second row is hidden, and it's the second row that determines the layout's
column widths. Hints on how to fix that are welcome...

Commit by mklingens :: kdeplayground-admin/kextprocess/lib/profilepropertieswidget_base.ui:

Aseigo was right, that splitter is useless