Commit by mkossick :: r987338 amarok/trunk/extragear/multimedia/amarok/src/collection/ (4 files in 3 dirs):

invert logic for moving files: only delete source file if the destination declares that to be fine instead of assuming that the transfer worked, and only keep source files for which we were informed about a transfer error.
assuming that KIO::FileCopyJob correctly reports an error if a file could not be moved or copied this should fix the issues with vanishing files that people have reported.

This fix even works for collections were any error handling was forgotten (i'm looking at you, mp3tunes and mediadevice)

Commit by mkossick :: r987303 amarok/trunk/extragear/multimedia/amarok/src/collection/sqlcollection/SqlCollectionLocation.cpp:

do not delete the source file if the target directory does not exist and we cannot create it.
incomplete fix: this probably does not take care of all corner cases (this requires a change to CollectionLocation so that the target location has to explicitly say "i've copied the file, go ahead and remove it". hm, let's hope that moving a file with KIO does not delete the source file on error)

this fix does not work for moving multiple files yet btw. all files but the first will still vanish. see above for a proper way to fix that

Commit by mkossick :: r981967 amarok/trunk/extragear/multimedia/amarok/src/collection/support/ (4 files):

moved remaining sorting code out of MemoryQueryMaker

Commit by mkossick :: r981966 amarok/trunk/extragear/multimedia/amarok/src/collection/sqlcollection/device/massstorage/MassStorageDeviceHandler.cpp:

make compile

Commit by mkossick :: r981368 amarok/trunk/extragear/multimedia/amarok/src/collection/support/MemoryQueryMakerHelper.cpp:

might fix linking issue by instantiating the function templates in the cpp file.

Commit by mkossick :: r981294 amarok/trunk/extragear/multimedia/amarok/src/collection/support/ (3 files):

move ordering of Meta::Years into the helper namespace to facilitate reuse

Commit by mkossick :: r981290 amarok/trunk/extragear/multimedia/amarok/src/ (5 files in 2 dirs):

refactoring so I can reuse soe of the MemoryQueryMaker code in proxy collection

Commit by mkossick :: r981221 amarok/trunk/extragear/multimedia/amarok/src/meta/file/ (File.cpp File_p.h):

store statistics for Meta::File tracks in the database

Commit by mkossick :: r981220 amarok/trunk/extragear/multimedia/amarok/src/meta/ (2 files):

added missing setters to StatisticsProvider

Commit by mkossick :: r981219 amarok/trunk/extragear/multimedia/amarok/src/ (4 files in 3 dirs):

groundwork for enabling statistics in all services.

Commit by mkossick :: r981218 amarok/trunk/extragear/multimedia/amarok/src/services/lastfm/meta/ (3 files):

provide statistics for last.fm streams

Commit by mkossick :: r981217 amarok/trunk/extragear/multimedia/amarok/src/collection/sqlcollection/ScanResultProcessor.cpp:

debug output to track down the reason for duplicate tracks in the collection after a rescan

Commit by mkossick :: r981216 amarok/trunk/extragear/multimedia/amarok/src/ (4 files in 3 dirs):

fixed sql

Commit by mkossick :: r981215 amarok/trunk/extragear/multimedia/amarok/src/ (3 files in 3 dirs):

show statistics for tracks that are not in a collection too

Commit by mkossick :: r981214 amarok/trunk/extragear/multimedia/amarok/src/dbus/ (5 files):

changes to collection dbus interface so it does not suck quite as much.
still not working though

Commit by mkossick :: r981213 amarok/trunk/extragear/multimedia/amarok/src/collection/sqlcollection/ (DatabaseUpdater.cpp DatabaseUpdater.h):

create new tables for storing statistics
TODO: implement an update mechanism that does not suck quite as much

Commit by mkossick :: r981212 amarok/trunk/extragear/multimedia/amarok/src/ (8 files in 3 dirs):

two strategies that make it easier to store statistics for any track:
one uses the tracks permanentUrl to store the statistics, the other uses the tracks metadata (track name, artist and album) to store metadata (yay, statistics for streams!)

Commit by mkossick :: r972964 amarok/trunk/extragear/multimedia/amarok/src/collection/sqlcollection/DatabaseUpdater.cpp:

exit if a too new database version was detected.
this change was not supposed to be aprt of the last commit

Commit by mkossick :: r972963 amarok/trunk/extragear/multimedia/amarok/src/ (6 files in 2 dirs):

improved database debugging

this commit makes it possible to dump the contents of Amarok's database to CSV files
and dump tables related to the collection scanning before and after the scan.

the whole database can be dumped by calling Amarok.Collection.dumpDatabaseContent() in the script console.
Warning: it will try to delete a file in the home directory that has the same name as the CSV that it is about to write. Check DatabaseUpdater.cpp/SqlCollection.cpp for the file names that it will try to write.

Additionally, one can enable automatic dumping of relevant SqlCollection tables before and after a collection scan.
Add the following section to amarokrc:
[SqlCollection]
DebugDatabaseContent=true

This requires a restart

Commit by mkossick :: r966250 amarok/trunk/extragear/multimedia/amarok/src/collection/sqlcollection/SqlQueryMaker.cpp:

redo commit, this time with the correct join