Commit by mkruisselbrink :: r1204473 interoperability/trunk/tests/kofficetests/interoperability/kspread/MSExcel2003/me03_webpage_copied.xls: (link)

Add one more file

Commit by mkruisselbrink :: r1202778 /branches/work/koffice-essen/kspread/CMakeLists.txt: (link)

link to threadweaver, and optionally define KSPREAD_MT to enable all the multithreaded stuff

Commit by mkruisselbrink :: r1202776 /branches/work/koffice-essen/kspread/ui/ (SheetView.cpp SheetView.h): (link)

protect cache with a mutex, and don't return cellviews by reference, as the references can cease to be valid at any point due to the nature of QCache

Commit by mkruisselbrink :: r1202777 /branches/work/koffice-essen/kspread/ui/ (2 files): (link)

and add the real background painting logic to PixmapCachingSheetView; no proper cleaning up yet, and I do probably want to rewrite it to use QFuture/QtConcurrent instead of threadweaver, but at least it seems to work quite well already

Commit by mkruisselbrink :: r1202775 /branches/work/koffice-essen/kspread/ui/ (SheetView.cpp SheetView.h): (link)

make visibleRect a parameter of the paint methods, to support multiple parallel paints with different visible rects

Commit by mkruisselbrink :: r1202774 /branches/work/koffice-essen/kspread/ui/CellView.cpp: (link)

sort of try to handle QTextDocument in a thread-safe manner; while it works correctly, it is impossible to use QTextDocument in any non-trivial multi-threaded manner without qWarnings getting printed all the time, because you can't do anything to a QTextDocument in a thread that is different from the one it is created in/associated to. And this also includes cloning it (cloning a document creates some internal QObjects with the original document as parent, which gives warnings because threads associated to the objects and their parents don't match).
The only way to use QTextDocuments in multiple threads is by cloning them in the GUI thread, and then moveToThread them to the thread where they will be used, but that can never work here because we have know way of knowing which ThreadWeaver (or QtConcurrent) worker thread will need access to which QTextDocument, so conclusion: QTextDocument is broken by design.

Commit by mkruisselbrink :: r1202773 /branches/work/koffice-essen/kspread/StyleStorage.cpp: (link)

also protect style-storage cache with a mutex

Commit by mkruisselbrink :: r1202772 /branches/work/koffice-essen/kspread/RectStorage.h: (link)

protect rect-storage internal cache with a mutex; for the other thread safety the protection inside CellStorage should be enough

Commit by mkruisselbrink :: r1202771 /branches/work/koffice-essen/kspread/CellStorage.cpp: (link)

first step towards a more multi-threaded kspread: protect access through the CellStorage (and thus Cell) interfaces with one big read/write lock per sheet

Commit by mkruisselbrink :: r1200992 /branches/work/koffice-essen/kspread/ui/SheetView.cpp: (link)

now CellView has an explicitly shared data pointer, there is no reason anymore to keep references here (and in fact references can cause crashes because the CellView might get deleted at any point)

Commit by mkruisselbrink :: r1200934 /branches/work/koffice-essen/kspread/ui/CellView.cpp: (link)

another nice catch by thorsten: this check never actually causes a return, as SheetView already takes care to never call this for cells that are not visible

Commit by mkruisselbrink :: r1200932 /branches/work/koffice-essen/kspread/ui/ (CellView.cpp CellView.h): (link)

seems I also need assignment operator...

Commit by mkruisselbrink :: r1200931 /branches/work/koffice-essen/kspread/ (5 files in 2 dirs): (link)

don't do double pixmap caching; with the caching in the sheetview we can get rid of the caching in the cellview

Commit by mkruisselbrink :: r1200930 /branches/work/koffice-essen/kspread/ui/ (CellView.cpp CellView.h SheetView.cpp): (link)

cache some of the calculations in SheetView::paintCells
patch by Thorsten Zachmann

Commit by mkruisselbrink :: r1200929 /branches/work/koffice-essen/kspread/ui/ (CellView.cpp CellView.h): (link)

make CellView explicitly shared instead of implicitly, so it is possible to pass it around by value, yet still have the caching done inside it work correctly

Commit by mkruisselbrink :: r1200921 filters/trunk/koffice/filters/kspread/excel/sidewinder/excel.cpp: (link)

don't crash when unexpected data is found in the CompObj stream (and whatever would be read there was ignored anyway).
BUG: 257938

Commit by mkruisselbrink :: r1200199 /branches/work/koffice-essen/filters/kspread/excel/sidewinder/worksheetsubstreamhandler.cpp: (link)

fix handling of notes/comments. The existing assert was not only incorrect, but also should not have been there as invalid user-input should never trigger assertions. Also actually making use of the NoteObject object makes it work more correct.

Commit by mkruisselbrink :: r1199997 /branches/work/koffice-essen/kspread/ui/PixmapCachingSheetView.cpp: (link)

debug--

Commit by mkruisselbrink :: r1199992 /branches/work/koffice-essen/kspread/ui/PixmapCachingSheetView.cpp: (link)

fix the sheetview pixmap caching to also work when rotations exist in the transformation matrix

Commit by mkruisselbrink :: r1199748 /branches/work/koffice-essen/kspread/CMakeLists.txt: (link)

install a bunch of kspread headers to make it somewhat possible to write a document viewer based on kspread outside the koffice source tree