Commit by onurf :: r740817 scripts/trunk/KDE/kdesdk/scripts/relicensecheck.pl:

I agree to a relicense

Commit by onurf :: r710475 kmail/trunk/KDE/kdepim/ (3 files in 2 dirs):

Fix Nepomuk support.

CC: sebastian at trueg dot de

Commit by onurf :: r710474 kmail/trunk/KDE/kdepim/ (. kmail/kmheaders.cpp):

No log message

Commit by onurf :: r706348 kmail/trunk/KDE/kdepim/ (. kmail/kmheaders.cpp):

SVN_SILENT: Remove tabs

Sorry about that, Thomas.

CC: thomas dot mcguire at gmx dot net

Commit by onurf :: r706166 kmail/trunk/KDE/kdepim/ (5 files in 2 dirs):

r10155@Onur-t61: kde4 | 2007-08-29 08:31:24 -0700
Add very basic Nepomuk support for tagging. The Nepomuk part is currently optional.

It is furthermore disabled since it crashes on my computer when I try to tag an email. Please try uncommenting

//#cmakedefine Nepomuk_FOUND

in kmail/config-kmail.h.cmake to see whether it is the case with you as well.

CC: sebastian at trueg dot de

Commit by onurf :: r692089 kmail/trunk/KDE/kdepim/kmail/ (24 files):

Finally, port the tagging feature to KDE4. It is in a slightly worse state than what I had for KDE 3.5,
but since the difficult part is over, I hope I will improve it over time.

Currently it has the following features:

• Ability to tag emails (with possibly more than one tag)
• Changing the appearance of message headers (font and text color) according to the message's tags.
• Configuration of tags through a new tab called "Message Tags" on the "Configure KMail->Appearance" configuration page.
• You can add toolbar buttons for easy tagging.
• You can assign shortcuts to tags.
• Tagging through the right-click menu.
• Quick filtering using the combobox for "status" filtering. See the screenshot. Some short-term todos:
• Incorporate Nepomuk
• A column for tags in the header view
• Incorporate Ellen's usability comments Some long-term todos:
• Filter action for automatic tagging
• Searching based on tags ( which enables having 'tag folders' through use of search folders ) I'm sorry that I didn't have enough time to test my current commit completely. In the last two days, I have been constantly compiling kdelibs, kdepimlibs, kdebase to keep up with very frequent changes. I finally was able to compile all at once:) BUGS: 50409 CCBUG: 15391, 122977

Commit by onurf :: r656743 kmail/trunk/KDE/kdepim/ (. kmail/kmmsgbase.cpp):

Convert to lowercase so the check in next line works.

Commit by onurf :: r656451 ktimetracker/trunk/KDE/kdepim/ (3 files in 2 dirs):

Oops, why did these raise from the dead?:)

Commit by onurf :: r656443 kmail/trunk/KDE/kdepim/ (12 files in 3 dirs):

KConfig -> KConfigGroup

Fixes reading of folder settings.

KConfig -> KConfigGroup

Commit by onurf :: r593217 akonadi/trunk/KDE/kdepim/ (. akonadi/clients/kagenda/main.cpp):

r16883@monur-tecra: kde4devel | 2006-10-07 00:19:50 -0700
Fix parsing of command-line arguments

Commit by onurf :: r541381 kmail/branches/KDE/3.5/kdepim/ (6 files in 3 dirs):

Backport the following coverity fixes:

541203: fix crash (CID 2111)
539126: looks like a clear bug, but my guess KDE never calls that function (CID 1539)
538899: catch invalid data (CID 1371)
538897: avoid crash (CID 1373)
538545: it can return 0
538539: don't crash (CID 1340)

Commit by onurf :: r537923 kmail/branches/KDE/3.5/kdepim/ (11 files in 3 dirs):

Backward port following coverity fixes:

537313: boring copy&paste bugs (CID 1287)

536478: init errorstate

535122: avoid null dereference (CID 1310)

534855: fix crash

534628: fix crash (CID 1319)

534581: fix crash (CID 1309)

534567: fix crash (CID 1317)

534557: fix crash

534391: fix crash

534390: fix crash (CID 1304)

534358: fix double free / error handling on malloc failure (dozens of CIDs)

534287: fix the order of NULL check and access

Commit by onurf :: r532941 kmail/trunk/KDE/kdepim/kmail/ (4 files):

Forward port commits:

518656:
-----------
Fixes the following crash, by adding check for null-pointers:

A message part that is not an email by itself is "view"ed. When reply or forward actions are triggered, KMail crashes.

It also hides the main toolbar and menu for non-message viewers.

CCBUG: 123316

527761:
-----------
The reply/forward phrases shouldn't have defaults, since it leads to
a mixup when the system locale is different from the KMail option for them.
For details, see bug 109533.

The problem is still not fully solved though, since the changes in the
configuration dialog are not immediately 'read' back.

CCBUG: 109533

Commit by onurf :: r532935 kmail/branches/KDE/3.5/kdepim/kmail/kmfoldertree.cpp:

Better way of checking for 'null'ity of fti, related to the bugfix in commit 530074.

Commit by onurf :: r532932 kmail/trunk/KDE/kdepim/kmail/ (9 files):

Forward port commits 530060, 530074, 530119:

530060:
--------------
Fix the following problems as indicated by Christoph Bartoschek in kde-pim:

• kmail/imapjob.cpp:240
• kmail/imapjob.cpp:262 (similar) If account is NULL as indicated by line 226, then line 240 crashes.
• kmail/imapjob.cpp:104 If msg_parent is NULL as indicated by line 90, then line 104 crashes. 530074: -------------- Second batch of fixes related to Christoph Bartoschek's report in kde-pim:
• kmail/kmfoldercachedimap.cpp:1749 If the if conditions in line 1741 and 1745 are both false, then line 1749 crashes.
• kmail/kmfoldertree.cpp:1480 If fti is NULL as indicated by line 1475, then line 1480 crashes.
• kmail/kmfoldertree.cpp:164 If mFolder is NULL as indicated by line 154, then line 154, 160 crash.
• kmail/kmfoldertree.cpp:143 If mFolder is NULL as indicated by line 136, then line 143 crashes.
• kmail/kmfoldertree.cpp:1549 If folder is NULL as indicated by line 1537, then line 1549 crashes. The last bug is only partially fixed, the whole KMFolderTree::slotUpdateCounts(KMFolder * folder) function could use a rewrite. 530119: ------------ Third batch of fixes related to Christoph Bartoschek's email in kde-pim:
• kmail/imapaccountbase.cpp:1102 If line 1092 gets executed and also 1102, then the second crashes.
• kmail/kmmsgdict.cpp:248 If folder is NULL as indicated by line 244, then line 248 crashes.
• kmail/kmmsgdict.cpp:214 If folder is NULL as indicated by line 208, then line 214,225, crashes.
• kmail/renamejob.cpp:64 If storage is NULL as indicated by line 57, then line 62 crashes. Lines where the operator preference between & and == leads to an error.
• kmail/kmmsgbase.cpp:873
• kmail/kmfolderimap.cpp:876 If f is NULL as indicated by line 869, then line 876 crashes.
• kmail/kmsender.cpp:362 If sentFolder is NULL as indicated by line 340, then line 362, 367 crashes. Thanks to Christoph for working on this.

Commit by onurf :: r532918 kmail/trunk/KDE/kdepim/kmail/kmmainwidget.cpp:

Forward port 532913:

Fix crash when trying to view source while the Message Preview Pane is hidden.

CCBUG: 85175

Commit by onurf :: r532913 kmail/branches/KDE/3.5/kdepim/kmail/kmmainwidget.cpp:

Fix crash when trying to view source while the Message Preview Pane is hidden.

BUG: 85175

Commit by onurf :: r530804 akregator/trunk/KDE/kdepim/akregator/src/akregator_part.rc:

Forward port 530803:

Make the order of the items in aKregator settings menu comply with rest of Kontact.
Namely "Configure Akregator..." should come right before "Configure Kontact...", not earlier.

Commit by onurf :: r530803 akregator/branches/KDE/3.5/kdepim/akregator/src/akregator_part.rc:

Make the order of the items in aKregator settings menu comply with rest of Kontact.
Namely "Configure Akregator..." should come right before "Configure Kontact...", not earlier.

Commit by onurf :: r530119 kmail/branches/KDE/3.5/kdepim/kmail/ (6 files):

Third batch of fixes related to Christoph Bartoschek's email in kde-pim:

• kmail/imapaccountbase.cpp:1102 If line 1092 gets executed and also 1102, then the second crashes.
• kmail/kmmsgdict.cpp:248 If folder is NULL as indicated by line 244, then line 248 crashes.
• kmail/kmmsgdict.cpp:214 If folder is NULL as indicated by line 208, then line 214,225, crashes.
• kmail/renamejob.cpp:64 If storage is NULL as indicated by line 57, then line 62 crashes. Lines where the operator preference between & and == leads to an error.
• kmail/kmmsgbase.cpp:873
• kmail/kmfolderimap.cpp:876 If f is NULL as indicated by line 869, then line 876 crashes.
• kmail/kmsender.cpp:362 If sentFolder is NULL as indicated by line 340, then line 362, 367 crashes. Thanks to Christoph for working on this.