Commit by sstjames :: r1043045 konq-plugins/trunk/extragear/base/konq-plugins/fsview/ (6 files):

Borrow some code from Dolphin to make FSView file management operations (Move To Trash, Delete, etc) work in KDE4.
Deselect All on pressing ESC.
Minor redrawing bugfix to TreeMapWidget::clearSelection(...).

CCMAIL:peter dot penz at gmx dot at
BUG:180579

Commit by sstjames :: r1030302 apps/trunk/KDE/kdebase/apps/keditbookmarks/ (bookmarklistview.cpp bookmarkmodel.cpp):

Check for invalid index in bookmarkForIndex(...) (prevents another crash).
Prevent non-folder items being drop targets (courtesy of dfaure).
Deal better with inserting before/ after items in both folder and normal views.

CCBUG:160679

Commit by sstjames :: r1016872 kio/trunk/KDE/kdelibs/kio/bookmarks/kbookmark.cc:

Only non-cloneNode()'d QDomElements are notified when their containing QDomDocument is destroyed, so taking cloneNode()'d elements that will outlive their QDomDocument leads to dangling pointers! Don't do this :)

This appears to fix at least one of the crashes in 160679 but I'm sure unrelated ones remain.

CCBUG:160679

Commit by sstjames :: r968441 workspace/trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp:

There seems to be some difficulty with specifying KConfig::Global when we are already using kdeglobals, in that it never writes out the settings, so do what the icons kcm does and use KGlobal::config() - as dfaure points out, this has the advantage of being more efficient, anyway. This is related to the following bugs (iconText and iconSize have much the same root causes), which I am also currently trying to fix:

CCBUG:168480
CCBUG:169067

Commit by sstjames :: r919951 apps/branches/KDE/4.2/kdebase/apps/dolphin/src/folderexpander.cpp:

Backport r919950: Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.

CCBUG:182618

Commit by sstjames :: r919950 apps/trunk/KDE/kdebase/apps/dolphin/src/folderexpander.cpp:

Hovering over blank space in a view while dragging would trigger the FolderExpander on the folder represented by the view, which we don't want. Detect and prevent it.

BUG:182618

Shipped! ;)

Commit by sstjames :: r917389 apps/trunk/KDE/kdebase/apps/dolphin/src/ (5 files in 2 dirs):

Initial import of Matthias's draft patch for adding video and audio previewing (similar to the file dialog) to Dolphin's metadata panel. Since Phonon is currently in-process only with the memory/ stability issues that come with this, this might have to be disabled by default - we'll see how it goes. Thanks, Matthias!

CCMAIL:kretz at kde dot org
CCMAIL:peter dot penz at gmx dot at

Commit by sstjames :: r916701 apps/trunk/KDE/kdebase/apps/dolphin/src/ (10 files):

Refactor the folder expansion system. Main effect: instead of having a list of m_expandedViews which cannot yet be deleted, we more accurately identify the current source of the drag operation if any and store only this for later deletion.

This also fixes folder-expansion not working in Column view.

Commit by sstjames :: r915785 apps/branches/KDE/4.2/kdebase/apps/dolphin/src/dolphindetailsview.cpp:

Backport r915781: In rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.

Commit by sstjames :: r915781 apps/trunk/KDE/kdebase/apps/dolphin/src/dolphindetailsview.cpp:

In rare circumstances (a very narrow viewport is a necessary, but not sufficient, condition) DolphinDetailsView::resizeColumns() is called with an empty model so that sizeHintForColumn(...) returns -1 and so the name column ultimately has width -1. Detect and prevent this.

Commit by sstjames :: r914799 apps/trunk/KDE/kdebase/apps/dolphin/src/dolphinview.cpp:

Two KFilePreviewGenerator's operating on the same KDirModel can lead to infinite loops of preview generation. If view is not delete'd (e.g. as a result of a FolderExpander), then m_previewGenerator won't be either: delete it manually to prevent having two active at once.

Commit by sstjames :: r913720 apps/branches/KDE/4.2/kdebase/apps/dolphin/src/dolphinpart.cpp:

Backport of r913713: Update the KPart host's status bar info when selection changes.

Commit by sstjames :: r913713 apps/trunk/KDE/kdebase/apps/dolphin/src/dolphinpart.cpp:

Update the KPart host's status bar info when selection changes.

Commit by sstjames :: r907250 kio/trunk/KDE/kdelibs/kio/kio/ (kdirwatch.cpp kdirwatch_p.h):

Make proper use of inotify's implicit "WatchFiles" ability. Immediate effect: Dolphin etc should now report changes to file attributes, rather than just creations and deletions, when KDirWatch uses inotify as its backend. Secondary effect: Assuming no bugs, we should consume at most the same number of inotify watches as before (and often much less).

Approved by Flavio Castelli.

CCMAIL:154676

Commit by sstjames :: r904995 apps/trunk/KDE/kdebase/apps/dolphin/src/ (2 files):

contentsPos turned out to be a little broken - it would always return (0,0), except in a very unusual set of circumstances where it returned ... "different" values, causing very odd behaviour with the elastic band :) Remove it.

Commit by sstjames :: r902827 workspace/trunk/KDE/kdebase/workspace/plasma/applets/ (3 files in 3 dirs):

Respond to r902778 to unbreak kdebase for anyone doing a fresh checkout.

Commit by sstjames :: r902594 apps/trunk/KDE/kdebase/apps/keditbookmarks/bookmarkinfo.cpp:

Update the text in the Location KLineEdit only when the actual URL it represents conflicts with that of the current bookmark, not when the textual representations of the URLs differ.

BUG:172647

Commit by sstjames :: r895536 kio/trunk/KDE/kdelibs/kio/kfile/kicondialog.cpp:

Magic numbers--, pad icons to respect uniformItemSizes, choose appropriate size to reduce need for padding and ensure SVGs are scaled to a matching size, add delegate so that more space is allocated for text, increase grid (thus, text) size and initial dialog size.

BUG:172746

Commit by sstjames :: r894855 plasma/trunk/playground/base/plasma/wallpapers/marble/marble.cpp:

If the globe is non-rotating, no updates are performed - even if we are tracking the night/ day shadow. Fix this. [First Plasma Patch!]

Commit by sstjames :: r880585 apps/trunk/KDE/kdebase/apps/dolphin/src/dolphindetailsview.cpp:

If the elastic band ventures beyond the logical top-left of the view (NOTE: not the viewport), then startIndex will likely be invalid, resulting in broken selection behaviour. Prevent this.

CCMAIL: peter dot penz at gmx dot at