Commit by stharward :: r987771 amarok/trunk/extragear/ (26 files in 12 dirs):

Acoustic similarity subsystem

Adds support to Amarok for the GTACFeat[0] audio similarity library.
GTACFeat is not required, so if you don't have it, Amarok should
compile and function normally without it.

If you want to be able to use the acoustic similarity features, as of
right now you should install GTACFeat from the SVN sources; hopefully by
the time Amarok 2.2 is ready for release, a beta version of GTACFeat
will be available. Also, all this code is just back-end stuff. There
isn't anything yet available in the GUI that takes advantage of acoustic
similarity, though there will be in the very near future.

[0] http://sourceforge.net/projects/gtacfeat

CCMAIL: amarok at kde dot org

Commit by stharward :: r959630 amarok/trunk/extragear/multimedia/amarok/src/scriptengine/ (2 files):

Replace the CountChanged signal in PlaylistScript

CountChanged was a relic of the old playlist code, which got rewritten
last year. This connection in the scripting subsystem broke during the
rewrite, and hasn't been fixed until now. The CountChanged has now been
replaced with the more useful "trackInserted" and "trackRemoved"
signals. They aren't as fully featured as I think some script authors
would like, but at least they're correct.

BUG: 180128

Commit by stharward :: r959629 amarok/trunk/extragear/multimedia/amarok/src/playlist/GroupingProxy.cpp:

SVN_SILENT: shouldn't have header redefinition check in code file

Commit by stharward :: r959628 amarok/trunk/extragear/multimedia/amarok/src/playlist/PlaylistController.cpp:

SVN_SILENT: Spelling fixes

Commit by stharward :: r875200 amarok/trunk/extragear/multimedia/amarok/src/collection/ (2 files in 2 dirs):

Make compile: include proper StatusBar header

Commit by stharward :: r875198 amarok/trunk/extragear/multimedia/amarok/src/playlist/ (2 files in 2 dirs):

Made PlaylistModel emit list of removed ID's

I guess I forgot to have the removal code fill in the list of ID's, so
it was emitting the signal, but with an empty list. This was causing
problems with the navigators; RepeatAlbumNavigator in particular would
crash.

BUG: 173363

Commit by stharward :: r875197 amarok/trunk/extragear/multimedia/amarok/src/playlist/ (PlaylistActions.cpp PlaylistModel.cpp):

PlaylistActions follows track changes better now

It was clearing out m_nextTrackCandidate too soon (or not setting it at
all), so the EngineObserver part was getting confused when the user
changed the track manually, or if the playlist had more than one copy of
the same track in it.

BUG: 173355

Commit by stharward :: r875026 amarok/trunk/extragear/multimedia/amarok/src/playlist/ (PlaylistItem.cpp PlaylistItem.h):

Fix incorrect function signature in Playlist::Item

The ID is stored internally as a quint64, but the id() function was
returning a qint64. For some really odd reason, GCC never picked up on
this.

Commit by stharward :: r875022 amarok/trunk/extragear/multimedia/amarok/src/playlist/view/listview/PrettyItemDelegate.cpp:

PrettyItemDelegate: subtle rendering tweaks

• Add a little more horizontal space between the artist and album labels
• Fixed font metric handling -- using static metrics prevents the delegate from responding properly if the user changes the default font size

Commit by stharward :: r875021 amarok/trunk/extragear/multimedia/amarok/src/playlist/navigators/ (3 files):

Removed potential crash in Navigators

Previously, there was the possibility of a dangling pointer when tracks
got deleted from the playlist. This eliminated the possibility.

Commit by stharward :: r874575 amarok/trunk/extragear/multimedia/amarok/src/playlist/navigators/ (2 files):

Safety checks so that Random navigators don't crash if playlist is empty

BUG: 173211

Commit by stharward :: r873054 amarok/trunk/extragear/multimedia/amarok/src/playlist/GroupingProxy.cpp:

Revert changes to GroupingProxy made in r872993

Equivalency of album title is not the same as equivalency of album. I
have six cases in my collection where two different artists have albums
with the same title, and Wikipedia lists hundreds of examples more. And
we can't just test Album and Artist because this will screw up Various
Artist albums. If testing equivalency of AlbumPtr in the GroupingProxy
fails to match tracks from the same album, then the fix needs to happen
in whatever code is creating the AlbumPtr and associating it with the
track.

CCMAIL: nhnfreespirit at gmail dot com

Commit by stharward :: r871785 amarok/trunk/extragear/multimedia/amarok/src/ (13 files in 10 dirs):

Load Service-associated tracks properly on startup

If the playlist is saved with tracks from a Service in it (eg, tracks
from Magnatune) when Amarok is closed, we want those tracks to be
properly reloaded when Amarok restarts. This means that the
ServicePluginManager has to be loaded before PlaylistModel reloads the
tracks, so that ServicePluginManager can register as a TrackProvider for
service-related tracks. This patch forces ServicePluginManager to be
loaded before tracks are restored into the playlist.

When the tracks are loaded into the playlist, their associated service
is initialized in the plugin manager so that the track can be loaded
properly into the playlist. However, MainWindow also needs to
initialize any remaining enabled services so that all enabled services
can show up in the servicebrowser. This patch also adds a check so that
when the MainWindow tells ServicePluginManager to initialize all the
services, it will skip the services that have already been initialized.

CCMAIL: unnamedrambler at gmail dot com
CCMAIL: nhnfreespirit at gmail dot com

Commit by stharward :: r871784 amarok/trunk/extragear/multimedia/amarok/src/statusbar_ng/StatusBar.cpp:

Fixed mistyped signal

Commit by stharward :: r871785 /trunk/extragear/multimedia/amarok/src/ (13 files in 10 dirs):

Load Service-associated tracks properly on startup

If the playlist is saved with tracks from a Service in it (eg, tracks
from Magnatune) when Amarok is closed, we want those tracks to be
properly reloaded when Amarok restarts. This means that the
ServicePluginManager has to be loaded before PlaylistModel reloads the
tracks, so that ServicePluginManager can register as a TrackProvider for
service-related tracks. This patch forces ServicePluginManager to be
loaded before tracks are restored into the playlist.

When the tracks are loaded into the playlist, their associated service
is initialized in the plugin manager so that the track can be loaded
properly into the playlist. However, MainWindow also needs to
initialize any remaining enabled services so that all enabled services
can show up in the servicebrowser. This patch also adds a check so that
when the MainWindow tells ServicePluginManager to initialize all the
services, it will skip the services that have already been initialized.

CCMAIL: unnamedrambler at gmail dot com
CCMAIL: nhnfreespirit at gmail dot com

Commit by stharward :: r871784 /trunk/extragear/multimedia/amarok/src/statusbar_ng/StatusBar.cpp:

Fixed mistyped signal

Commit by stharward :: r870227 amarok/trunk/ (26 files in 5 dirs):

Navigator Overhaul 2: Electric Boogaloo

I did a partial reworking of the navigators in the playlist overhaul,
but they still needed some work. They've now been significantly
simplified, and should be chosen properly to the user's Repeat and
Random settings.

CCMAIL: amarok-devel at kde dot org

Commit by stharward :: r870227 /trunk/extragear/multimedia/amarok/src/ (26 files in 5 dirs):

Navigator Overhaul 2: Electric Boogaloo

I did a partial reworking of the navigators in the playlist overhaul,
but they still needed some work. They've now been significantly
simplified, and should be chosen properly to the user's Repeat and
Random settings.

CCMAIL: amarok-devel at kde dot org

Commit by stharward :: r870088 amarok/trunk/extragear/multimedia/amarok/src/Amarok.h:

Fixed a compiler warning

Commit by stharward :: r870088 /trunk/extragear/multimedia/amarok/src/Amarok.h:

Fixed a compiler warning