Commit by stpere on master :: rhrev43704 haiku/: (link)

Installer: minor memory leak fix. CID 1713.

Commit by stpere on master :: rhrev43643 haiku/: (link)

shortcut_catcher: memory leak fixes

memory allocated in get_key_map(..) wasn't released.

CID 5696, CID 5697, CID 1699, CID 1700

Commit by stpere on master :: rhrev43642 haiku/: (link)

MediaPlayer: Fix movement of items in playlist

In Playlist, whenever a move of items occured causing the
currently playing song to change its position, so :
1. Importing files (D&D for example) before its position
2. Removings files before it
3. Moving files before it

was causing the currently playing song to restart because
it was thinking a new entry was asked (it had a different
index number suddently).

Also adjusted the behaviour when you delete the currently
playing track.

Should fix ticket #6689.

Commit by stpere on master :: rhrev43633 haiku/: (link)

Tracker: Fix inconsistent "Open parent" behaviour

1. When in /boot, you couldn't go to the parent (which is fine by itself),
but the menu item wasn't disabled.

2. In Single Window Browsing, doing "Open parent" wasn't respecting that
setting and was opening new windows.

3. In filepanel, when navigating to Desktop folder, the "Go to parent" was
still proposed even though it would do nothing choosing it.

4. Opening a Pose in Single Window Browsing was repopulating the menus and
putting the shortcuts again. That was an issue if Navigator bar was used
since it conflicts with its shortcuts.

Fixing ticket #6851.

Commit by stpere on master :: rhrev43632 haiku/: (link)

MediaPlayer: Double-click on playlist item to restart it

Double-clicking on the currently playing playlist item restart that
item's playback from the beginning.

Ticket #6560.

Commit by stpere on master :: rhrev43631 haiku/: (link)

Tracker: FSMoveToTrash(): needless check and possible crash fix

In an earlier commit, I removed a memleak, but it was covering more cases
than intended. Thanks to Alex Wilson's insight, it seems that simply removing
the check is better (since that check is essentially redone in FSMoveToTrash()).

Commit by stpere on master :: rhrev43628 haiku/: (link)

intel accelerant: NULL dereferences (overlays)

Rather than checking if "window" AND "view" are NULL, check if
"window" OR "view" are NULL, since neither could be null and deferenced later
on.

From the Matrox accelerant, it seems that such event occurs when a
"Workspace switch, screen prefs change, or overlay app shutdown occurs"

Might be interesting to revisit tickets related to intel accelerant.

CID 205.

Commit by stpere on master :: rhrev43627 haiku/: (link)

Tracker: Memory leak fix

The leak occured everytime a folder, or queries where opened while
navigating.

CID 5848.

Commit by stpere on master :: rhrev43624 haiku/: (link)

Tracker (FSUtils): negative passed to unsigned parameter

BVolume::BlockSize() might return a negative value (error code) and it
was passed as parameter of CalcItemsAndSize() as a size_t (unsigned).

Thus the check for an error code failed.

CID 4171.

Commit by stpere on master :: rhrev43623 haiku/: (link)

Tracker (InfoWindow): small memory leak fix

In the case of a broken symlink, a Model object was leaked when trying
to get the icon of the target.

CID 5844.

Commit by stpere on master :: rhrev43621 haiku/: (link)

FindPanel: Avoid NULL deference; CID 352.

Commit by stpere on master :: rhrev43618 haiku/: (link)

PoseView: Fix assertion in InitDirentIterator

The dynamic_cast was called twice, and the assert was
done on the first attempt. Now it just cast once, assert on this
and pass it further as before.

CID 3122.

Commit by stpere on master :: rhrev43617 haiku/: (link)

Tracker: memory leak fix

In MoveRefsToTrash(), the srcList wasn't deleted after usage.

CID 5849.

Commit by stpere on master :: rhrev43616 haiku/: (link)

ffmpeg (gif codec): Init len variable

It was already fixed upstream. CID 9309.

Commit by stpere on master :: rhrev43615 haiku/: (link)

ffmpeg: infinite loop (als decoder)

CID 3176. Patch proposed upstream.

Commit by stpere on master :: rhrev43614 haiku/: (link)

Firewire: uninit buffers returned

Probably a copy-paste error caused the wrong variables being returned
in fw_xfer_alloc_buf() for the received transfers.

CID 10746.

Commit by stpere on master :: rhrev43613 haiku/: (link)

No functional change; invert the order of includes.

Commit by stpere on master :: rhrev43612 haiku/: (link)

MediaConverter: Move a NULL check

To avoid a NULL dereference, moving a NULL check earlier.

CID 5955.

Commit by stpere on master :: rhrev43611 haiku/: (link)

TextView: initialize buttons variable

CID 10751.

Commit by stpere on master :: rhrev43610 haiku/: (link)

Terminal: NULL dereference fix

An inversion in a condition could lead to a NULL dereference.

CID 11039.