Commit by stpere on master :: rhrev44130 haiku/: (link)

top: Attempt to avoid negative "(unknown)" %

Top was using the 'theorical' interval value to determine the percentages.
The measured thread times were taken in an always a bit larger interval than
that theorical value, hence the negative '%' occuring regularly.

Should fix #4589.

Commit by stpere on master :: rhrev44125 haiku/: (link)

Tracker: Removing the Desktop Background Image don't clear a pointer

fBackgroundImage wasn't being cleared when removing the desktop
background image because the loading process wasn't ignoring
loading failures (as is the "no background for this workspace" setting).

fBackgroundImage not being NULL was causing crashes mainly in
ScreenChanged(), where it was trying to re-center a non-existant
background. Was causing #7376 and maybe others.

Commit by stpere on master :: rhrev44124 haiku/: (link)

Tracker: Consider extra column margin in PoseView::Extent()

In List Mode, consider the extra margin added to the right of
the last column when computing the Extent of the PoseView. This
was causing the ResizeToFit to resize a bit too small.

Fixes #4318

Commit by stpere on master :: rhrev44121 haiku/: (link)

setgcc: add -l argument to ls call in script

In previous, it was still working as I was more interested into != 0 than
exact count. Still, for clarity sake, I add -l to get the actual count.

Thanks Axel.

Commit by stpere on master :: rhrev44116 haiku/: (link)

setgcc: error message

The bash script tried to verify the existence of a file,
but there were several fils fitting the wildcard expression.
So, [ -e .../*gcc ]; was interpreted as if it had too many
arguments. Replaced that expression by a count of files.

Fixes #8493.

Commit by stpere on master :: rhrev44115 haiku/: (link)

MediaPlayer: Looping regardless of setting

• Fixed a regression I introduced in hrev43642. Ticket #8364.
• Small coding style fix

Commit by stpere on master :: rhrev43775 haiku/: (link)

Desklink: Close the Volume Window after dropping the replicant

When dropping a replicant of the Volume Control, close the volume window.

Enhancement #7718.

Commit by stpere on master :: rhrev43774 haiku/: (link)

CPUFrequency replicant

Use be_control_look to outline label (and change text color) when needed.

Commit by stpere on master :: rhrev43773 haiku/: (link)

Outline of labels/strings drawn to desktop

• Rather than duplicating the decision taking logic involving wheter or not to draw the outline or glow in every replicant, update be_control_look to make it more generic.
• The Monitoring of the background preferences is now only done in Tracker (where it was already being done).
• Add a BControlLook::B_IGNORE_OUTLINE flag to avoid this new behaviour.
• Remove that said logic from ActivityMonitor and use be_control_look.
• Use the ignore flag in DeskCalc to avoid the outline in its case. Should fix #7716, #7291.

Commit by stpere on master :: rhrev43704 haiku/: (link)

Installer: minor memory leak fix. CID 1713.

Commit by stpere on master :: rhrev43643 haiku/: (link)

shortcut_catcher: memory leak fixes

memory allocated in get_key_map(..) wasn't released.

CID 5696, CID 5697, CID 1699, CID 1700

Commit by stpere on master :: rhrev43642 haiku/: (link)

MediaPlayer: Fix movement of items in playlist

In Playlist, whenever a move of items occured causing the
currently playing song to change its position, so :
1. Importing files (D&D for example) before its position
2. Removings files before it
3. Moving files before it

was causing the currently playing song to restart because
it was thinking a new entry was asked (it had a different
index number suddently).

Also adjusted the behaviour when you delete the currently
playing track.

Should fix ticket #6689.

Commit by stpere on master :: rhrev43633 haiku/: (link)

Tracker: Fix inconsistent "Open parent" behaviour

1. When in /boot, you couldn't go to the parent (which is fine by itself),
but the menu item wasn't disabled.

2. In Single Window Browsing, doing "Open parent" wasn't respecting that
setting and was opening new windows.

3. In filepanel, when navigating to Desktop folder, the "Go to parent" was
still proposed even though it would do nothing choosing it.

4. Opening a Pose in Single Window Browsing was repopulating the menus and
putting the shortcuts again. That was an issue if Navigator bar was used
since it conflicts with its shortcuts.

Fixing ticket #6851.

Commit by stpere on master :: rhrev43632 haiku/: (link)

MediaPlayer: Double-click on playlist item to restart it

Double-clicking on the currently playing playlist item restart that
item's playback from the beginning.

Ticket #6560.

Commit by stpere on master :: rhrev43631 haiku/: (link)

Tracker: FSMoveToTrash(): needless check and possible crash fix

In an earlier commit, I removed a memleak, but it was covering more cases
than intended. Thanks to Alex Wilson's insight, it seems that simply removing
the check is better (since that check is essentially redone in FSMoveToTrash()).

Commit by stpere on master :: rhrev43628 haiku/: (link)

intel accelerant: NULL dereferences (overlays)

Rather than checking if "window" AND "view" are NULL, check if
"window" OR "view" are NULL, since neither could be null and deferenced later
on.

From the Matrox accelerant, it seems that such event occurs when a
"Workspace switch, screen prefs change, or overlay app shutdown occurs"

Might be interesting to revisit tickets related to intel accelerant.

CID 205.

Commit by stpere on master :: rhrev43627 haiku/: (link)

Tracker: Memory leak fix

The leak occured everytime a folder, or queries where opened while
navigating.

CID 5848.

Commit by stpere on master :: rhrev43624 haiku/: (link)

Tracker (FSUtils): negative passed to unsigned parameter

BVolume::BlockSize() might return a negative value (error code) and it
was passed as parameter of CalcItemsAndSize() as a size_t (unsigned).

Thus the check for an error code failed.

CID 4171.

Commit by stpere on master :: rhrev43623 haiku/: (link)

Tracker (InfoWindow): small memory leak fix

In the case of a broken symlink, a Model object was leaked when trying
to get the icon of the target.

CID 5844.

Commit by stpere on master :: rhrev43621 haiku/: (link)

FindPanel: Avoid NULL deference; CID 352.