date | project | content | link |
|---|
| 07:04 Thursday | WebKit | Commit by thakis@chromium.org :: r118312 Source/WebCore/ (2 files in 2 dirs): | # |
| 21:55 Tuesday | WebKit | Commit by thakis@chromium.org :: r117995 Source/WebCore/ (3 files in 2 dirs): Give FileInputType a setFiles() method, let Drag-n-Drop call it. https://bugs.webkit.org/show_bug.cgi?id=87139
Reviewed by Ojan Vafai.
filesChosen(), the FileChooserClient callback, used to modify m_fileList directly. Instead, convert the FileChooserClient data to a FileList and pass that to a factored-out setFiles() method. This is in preparation to making the files property writable.
Pure refactoring, no functionality change.
- html/FileInputType.cpp: (WebCore::FileInputType::toFileList): (WebCore::FileInputType::setFiles): (WebCore::FileInputType::filesChosen): (WebCore):
- html/FileInputType.h: (FileInputType):
| # |
| 07:22 on May 16 | WebKit | Commit by thakis@chromium.org :: r117209 Source/WebCore/ (ChangeLog WebCore.gyp/WebCore.gyp): [chromium] Remove some unused gyp lines https://bugs.webkit.org/show_bug.cgi?id=86545
Reviewed by Dirk Pranke.
mac_framework_dirs adds directories to search for frameworks (similar to -I for includes), it doesn't add any frameworks. Having something that ends in .framewok in mac_framework_dirs doesn't make sense.
No intended functionality change.
| # |
| 03:20 on May 12 | WebKit | Commit by thakis@chromium.org :: r116817 Source/WebCore/ (ChangeLog WebCore.gyp/WebCore.gyp): [chromium/mac] Let libwebkit.dylib link in Debug/components build https://bugs.webkit.org/show_bug.cgi?id=86244
Reviewed by James Robinson.
In static builds, this was not needed because the targets depending on 'webkit' already link in QuartzCore. In Release components builds, it wasn't needed because they are built with -dead_strip, which stripped the referencing code.
| # |
| 02:03 on May 03 | WebKit | Commit by thakis@chromium.org :: r115893 Source/WTF/ (ChangeLog wtf/TypeTraits.h): | # |
| 07:59 on Apr 27 | WebKit | Commit by thakis@chromium.org :: r115406 Source/WTF/ (ChangeLog wtf/Compiler.h): Don't define WTF_COMPILER_SUPPORTS_CXX_NULLPTR twice when building with clang on windows. https://bugs.webkit.org/show_bug.cgi?id=85018
Reviewed by Anders Carlsson.
Clang sets _MSC_VER when compiling for a -pc-win32 target (just like it sets __GNUC__ on unix). As a result, WTF_COMPILER_SUPPORTS_CXX_NULLPTR gets currently set twice, once for clang and once for _MSC_VER. Guard the second instance with !COMPILER(CLANG). This matches the gcc code for WTF_COMPILER_SUPPORTS_CXX_NULLPTR in the same file.
| # |
| 07:40 on Apr 27 | WebKit | Commit by thakis@chromium.org :: r115404 Source/WebCore/ (2 files in 2 dirs): [chromium] Fix C++ language use. https://bugs.webkit.org/show_bug.cgi?id=85015
Reviewed by James Robinson.
Even though MSVC allows it, a sizeof followed by a non-parenthesized typename is not valid C++.
No functionality change.
- rendering/RenderThemeChromiumWin.cpp: (WebCore): (WebCore::getNonClientMetrics):
| # |
| 08:50 on Apr 19 | WebKit | Commit by thakis@chromium.org :: r114606 Source/WebKit/chromium/ (ChangeLog src/WebPluginContainerImpl.cpp): | # |
| 11:17 on Apr 16 | WebKit | Commit by thakis@chromium.org :: r114227 Source/WTF/ (ChangeLog wtf/NullPtr.h): Make NullPtr.h compile with clang -std=c++11 and libstdc++4.2 https://bugs.webkit.org/show_bug.cgi?id=83999
Reviewed by Sam Weinig.
Before this patch, NullPtr.h assumed that a working |nullptr| implied a working |std::nullptr_t| as well. With clang and libstdc++4.2, this is not true.
I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03) with clang.
| # |
| 07:09 on Apr 14 | WebKit | Commit by thakis@chromium.org :: r114201 Source/WebKit/chromium/ (ChangeLog tests/LayerChromiumTest.cpp): [chromium] There is no Color(float, float, float) constructor, fix an attempt to call it. https://bugs.webkit.org/show_bug.cgi?id=83920
Reviewed by James Robinson.
Found by clang: third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion] EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f))); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~
- tests/LayerChromiumTest.cpp:
| # |
| 00:17 on Apr 12 | WebKit | Commit by thakis@chromium.org :: r113901 Tools/ (2 files in 2 dirs): [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin. https://bugs.webkit.org/show_bug.cgi?id=83709
Reviewed by Anders Carlsson.
- DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon):
| # |
| 23:59 on Mar 13 | WebKit | Commit by thakis@chromium.org on chromium :: r110597 /1025/Source/WebCore/ (2 files in 2 dirs): | # |
| 03:58 on Mar 13 | WebKit | Commit by thakis@chromium.org :: r110510 Source/WebCore/ (2 files in 2 dirs): | # |
| 07:02 on Mar 09 | WebKit | Commit by thakis@chromium.org :: r110251 Source/WebCore/ (ChangeLog WebCore.gyp/WebCore.gyp): [chromium] Only build NEON files if target_arch=="arm" https://bugs.webkit.org/show_bug.cgi?id=80626
Currently, webcore_arm_neon will compile a bunch of files whose contents are completely ifdef'd away on non-arm, and then bundle all the generated empty .o files into a useless libwebcore_arm_neon.a. Don't do this.
Reviewed by Tony Chang.
- WebCore.gyp/WebCore.gyp:
- WebCore.gypi:
| # |
| 19:09 on Feb 14 | WebKit | Commit by thakis@chromium.org on chromium :: r107711 /1025/ (26 files in 6 dirs): | # |
| 02:37 on Feb 14 | WebKit | Commit by thakis@chromium.org :: r107618 Source/WebKit/chromium/ (ChangeLog src/WebKit.cpp): [chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac. https://bugs.webkit.org/show_bug.cgi?id=78246
This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/), and helps with the component build on mac (InitWebCoreSystemInterface is not an exported function, and it shouldn't be).
Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's called twice, so it's safe to land this change, and remove the calls in client code in a later CL.
Reviewed by Darin Fisher.
- src/WebKit.cpp: (WebKit::initializeWithoutV8):
| # |
| 00:25 on Feb 11 | WebKit | Commit by thakis@chromium.org on chromium :: r107430 /1025/Source/WebKit/chromium/ (4 files in 3 dirs): | # |
| 02:21 on Feb 01 | WebKit | Commit by thakis@chromium.org :: r106401 Source/WebKit/chromium/ (4 files in 3 dirs): [chromium] Expose windowResizerRectChanged() on WebWidget. https://bugs.webkit.org/show_bug.cgi?id=77453
Needed for http://crbug.com/111266
Reviewed by Darin Fisher.
- public/WebWidget.h: (WebWidget): (WebKit::WebWidget::didChangeWindowResizerRect):
- src/WebViewImpl.cpp: (WebKit::WebViewImpl::didChangeWindowResizerRect): (WebKit):
- src/WebViewImpl.h: (WebViewImpl):
| # |
| 03:01 on Jan 29 | WebKit | Commit by thakis@chromium.org :: r106195 /trunk/ (5 files in 3 dirs): [chromium] Add support for building standalone webkit/chromium checkouts with ninja. https://bugs.webkit.org/show_bug.cgi?id=77243
Reviewed by Adam Barth.
Source/WebKit/chromium:
- gyp_webkit: Tools:
- Scripts/update-webkit:
- Scripts/webkitdirs.pm: (isChromiumNinja): (determineIsChromiumNinja): (buildChromiumNinja): (buildChromium):
| # |
| 02:50 on Jan 14 | WebKit | Commit by thakis@chromium.org :: r105003 Source/WebCore/ (2 files in 2 dirs): | # |