CIA.vc
thakis@chromium.org
Real-time open source activity stats
Stats » Authors » thakis@chromium.org
informationsyndicateUTC clock
11:21 on Feb 14, 2012
event counters
The last message was received 8.72 hours ago at 02:37 on Feb 14, 2012
1 messages so far today, 0 messages yesterday
1 messages so far this week, 1 messages last week
3 messages so far this month, 2 messages last month
1015 messages since the first one, 2.71 years ago, for an average of 0.97 days between messages
recent messages
dateReversed sort columnprojectcontentlink
02:37 todayWebKit
Commit by thakis@chromium.org :: r107618 Source/WebKit/chromium/ (ChangeLog src/WebKit.cpp):

[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac.
https://bugs.webkit.org/show_bug.cgi?id=78246

This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/),
and helps with the component build on mac (InitWebCoreSystemInterface is not an
exported function, and it shouldn't be).

Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's
called twice, so it's safe to land this change, and remove the calls in client
code in a later CL.

Reviewed by Darin Fisher.

  • src/WebKit.cpp: (WebKit::initializeWithoutV8):
#
00:25 SaturdayWebKit
Commit by thakis@chromium.org on chromium :: r107430 /1025/Source/WebKit/chromium/ (4 files in 3 dirs):

Merge 106401 (part of http://crbug.com/111266) -
[chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453

Needed for http://crbug.com/111266

Reviewed by Darin Fisher.

#
02:21 on Feb 01WebKit
Commit by thakis@chromium.org :: r106401 Source/WebKit/chromium/ (4 files in 3 dirs):

[chromium] Expose windowResizerRectChanged() on WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=77453

Needed for http://crbug.com/111266

Reviewed by Darin Fisher.

  • public/WebWidget.h: (WebWidget): (WebKit::WebWidget::didChangeWindowResizerRect):
  • src/WebViewImpl.cpp: (WebKit::WebViewImpl::didChangeWindowResizerRect): (WebKit):
  • src/WebViewImpl.h: (WebViewImpl):
#
03:01 on Jan 29WebKit
Commit by thakis@chromium.org :: r106195 /trunk/ (5 files in 3 dirs):

[chromium] Add support for building standalone webkit/chromium checkouts with ninja.
https://bugs.webkit.org/show_bug.cgi?id=77243

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • gyp_webkit: Tools:
  • Scripts/update-webkit:
  • Scripts/webkitdirs.pm: (isChromiumNinja): (determineIsChromiumNinja): (buildChromiumNinja): (buildChromium):
#
02:50 on Jan 14WebKit
Commit by thakis@chromium.org :: r105003 Source/WebCore/ (2 files in 2 dirs):

Remove a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=76307

Reviewed by James Robinson.

  • platform/mac/ScrollElasticityController.mm: (WebCore::ScrollElasticityController::snapRubberBandTimerFired):
#
02:14 on Nov 24, 2011WebKit
Commit by thakis@chromium.org :: r101108 Source/WebCore/ (2 files in 2 dirs):

Remove one static initializer (for kTickTime)
https://bugs.webkit.org/show_bug.cgi?id=73049

Reviewed by Adam Barth.

  • platform/ScrollAnimatorNone.cpp:
#
07:57 on Nov 12, 2011WebKit
Commit by thakis@chromium.org :: r100070 Source/ (11 files in 6 dirs):

[chromium] Remove 2 static initializers and 3 exit time destructors. Turn on -Wexit-time-destructors.
https://bugs.webkit.org/show_bug.cgi?id=72146

Reviewed by Nate Chapin.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp: Source/WebKit/chromium:
  • WebKit.gyp:
  • src/DebuggerAgentManager.cpp: (WebKit::DebuggerAgentManager::debugHostDispatchHandler): (WebKit::DebuggerAgentManager::onWebViewClosed):
  • src/DebuggerAgentManager.h:
  • src/WebAccessibilityObject.cpp: (WebKit::WebAccessibilityObject::keyboardShortcut):
  • src/WebViewImpl.cpp: (WebKit::pageGroupLoadDeferrerStack): (WebKit::WebView::willEnterModalLoop): (WebKit::WebView::didExitModalLoop):
#
20:52 on Nov 08, 2011WebKit
Commit by thakis@chromium.org :: r99588 Source/WebCore/ (8 files in 3 dirs):

[chromium] Remove 6 exit time destructors and 6 static initializers
https://bugs.webkit.org/show_bug.cgi?id=71760

Reviewed by Nate Chapin.

Do this by moving global statics into function-local statics, and using
DEFINE_LOCAL_STATIC to leak them. Since this code is accessed on a single
thread, this is a safe change to make.

No behavior change, so no new tests.

  • bindings/v8/ScriptGCEvent.cpp: (WebCore::sEventListeners): (WebCore::ScriptGCEvent::addEventListener): (WebCore::ScriptGCEvent::removeEventListener): (WebCore::ScriptGCEvent::gcEpilogueCallback):
  • bindings/v8/ScriptGCEvent.h:
  • bindings/v8/V8NPObject.cpp: (WebCore::staticTemplateMap): (WebCore::weakTemplateCallback): (WebCore::npObjectGetProperty): (WebCore::staticNPObjectMap): (WebCore::weakNPObjectCallback): (WebCore::createV8ObjectForNPObject): (WebCore::forgetV8ObjectForNPObject):
  • bindings/v8/V8Proxy.cpp: (WebCore::staticExtensionsList): (WebCore::V8Proxy::registeredExtensionWithV8): (WebCore::V8Proxy::registerExtension): (WebCore::V8Proxy::extensions):
  • bindings/v8/V8Proxy.h:
  • bindings/v8/npruntime.cpp:
  • plugins/chromium/PluginDataChromium.cpp: (WebCore::pluginCache): (WebCore::PluginData::initPlugins): (WebCore::PluginData::refresh): (WebCore::getPluginMimeTypeFromExtension):
#
20:06 on Nov 04, 2011WebKit
Commit by thakis@chromium.org :: r99293 Source/WebCore/ (4 files in 2 dirs):

[chromium] Remove most exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=71524

Do this by using the DEFINE_STATIC_LOCAL macro, which allocates things on the heaps and then leaks them.

Reviewed by Dimitri Glazkov.

No behavior change, so no new tests.

  • platform/chromium/CursorChromium.cpp: (WebCore::pointerCursor): (WebCore::crossCursor): (WebCore::handCursor): (WebCore::iBeamCursor): (WebCore::waitCursor): (WebCore::helpCursor): (WebCore::eastResizeCursor): (WebCore::northResizeCursor): (WebCore::northEastResizeCursor): (WebCore::northWestResizeCursor): (WebCore::southResizeCursor): (WebCore::southEastResizeCursor): (WebCore::southWestResizeCursor): (WebCore::westResizeCursor): (WebCore::northSouthResizeCursor): (WebCore::eastWestResizeCursor): (WebCore::northEastSouthWestResizeCursor): (WebCore::northWestSouthEastResizeCursor): (WebCore::columnResizeCursor): (WebCore::rowResizeCursor): (WebCore::middlePanningCursor): (WebCore::eastPanningCursor): (WebCore::northPanningCursor): (WebCore::northEastPanningCursor): (WebCore::northWestPanningCursor): (WebCore::southPanningCursor): (WebCore::southEastPanningCursor): (WebCore::southWestPanningCursor): (WebCore::westPanningCursor): (WebCore::moveCursor): (WebCore::verticalTextCursor): (WebCore::cellCursor): (WebCore::contextMenuCursor): (WebCore::aliasCursor): (WebCore::progressCursor): (WebCore::noDropCursor): (WebCore::copyCursor): (WebCore::noneCursor): (WebCore::notAllowedCursor): (WebCore::zoomInCursor): (WebCore::zoomOutCursor): (WebCore::grabCursor): (WebCore::grabbingCursor):
  • platform/chromium/LanguageChromium.cpp: (WebCore::platformDefaultLanguage):
  • platform/chromium/MIMETypeRegistryChromium.cpp: (WebCore::dummyHashSet):
#
17:43 on Oct 25, 2011WebKit
Commit by thakis@chromium.org :: r98347 Source/ (4 files in 3 dirs):

Source/WebCore: [chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

#
01:24 on Oct 25, 2011WebKit
Commit by thakis@chromium.org :: r98294 Source/WebCore/ (ChangeLog WebCore.gyp/WebCore.gyp):

[chromium/mac] Fix an ODR violation.
https://bugs.webkit.org/show_bug.cgi?id=70753

Reviewed by Anders Carlsson.

Both ScrollAnimatorNone and ScrollAnimatorMac define ScrollAnimator::create() on OS X.
Remove the unused one.

  • WebCore.gyp/WebCore.gyp:
#
02:36 on Oct 21, 2011WebKit
Commit by thakis@chromium.org :: r98045 /trunk/ (5 files in 4 dirs):

[chromium/mac] Add support for building with make
https://bugs.webkit.org/show_bug.cgi?id=70455

Reviewed by Adam Barth.

Depends on http://codereview.chromium.org/8352029/
`GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
create a toplevel Makefile.chromium.

If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
`Tools/Scripts/build-webkit --chromium` will build with make instead of
xcodebuild.

Source/WebKit/chromium:

  • gyp_webkit: Tools: Also let nrwt use a binary from out/ if it exists.
  • Scripts/webkitdirs.pm: (determineBaseProductDir): (isChromiumMacMake): (determineIsChromiumMacMake): (buildChromium):
#
04:34 on Oct 20, 2011WebKit
Commit by thakis@chromium.org :: r97921 Source/WebKit/chromium/ (ChangeLog gyp_webkit):

[chromium/mac] Use clang as compiler!
https://bugs.webkit.org/show_bug.cgi?id=70425

Reviewed by Adam Barth.

It looks like http://trac.webkit.org/changeset/97415 was all that's
needed to get this to work.

  • gyp_webkit: Don't force clang off, which means it's now on by default on mac.
#
01:07 on Oct 14, 2011WebKit
Commit by thakis@chromium.org :: r97415 Source/WebKit/chromium/ (ChangeLog DEPS):

[chromium] Automatically pull clang on `update-webkit --chromium` on mac
https://bugs.webkit.org/show_bug.cgi?id=70058

Reviewed by Adam Barth.

  • DEPS:
#
23:25 on Oct 12, 2011WebKit
Commit by thakis@chromium.org :: r97301 Source/WebKit/chromium/ (6 files in 3 dirs):

[chromium] Add a setSelectionToRange() method to WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=69846

Also add a method to WebRange to create a range given a frame and an
interval.

This will be used to implement the "replacement range" feature of OS X
IMEs, see http://codereview.chromium.org/8227018 (the change to
render_widget.cc).
The renderer will set the selection to the replacement range before
calling confirmComposition(). This matches how WK2 does this, see
Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm,
WebPage::setComposition(). The function convertToRange() was taken
from there, too.

Reviewed by Darin Fisher.

  • public/WebFrame.h: (WebKit::WebFrame::setSelectionToRange):
  • src/WebFrameImpl.cpp: (WebKit::WebViewImpl::setSelectionToRange):
  • src/WebFrameImpl.h: (WebKit::WebViewImpl::setSelectionToRange):
  • src/WebRange.cpp: (WebRange::fromGlobalRange):
  • src/WebRange.h: (WebRange::fromGlobalRange):
#
02:56 on Oct 12, 2011WebKit
Commit by thakis@chromium.org :: r97204 Source/WebCore/ (2 files in 2 dirs):

[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
https://bugs.webkit.org/show_bug.cgi?id=69589

Reviewed by Dirk Pranke.

When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
255 by default, so the build used to fail with
"open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.

  • WebCore.gyp/scripts/rule_binding.py:
#
02:25 on Oct 11, 2011WebKit
Commit by thakis@chromium.org :: r97108 Source/WebKit/chromium/ (ChangeLog DEPS):

[chromium] Pull tools/clang from upstream.
https://bugs.webkit.org/show_bug.cgi?id=69797

Reviewed by Adam Barth.

  • DEPS:
#
04:55 on Oct 07, 2011WebKit
Commit by thakis@chromium.org :: r96892 Source/WebCore/ (2 files in 2 dirs):

[chromium] Let rule_binding use os.execvp() instead of subprocess.call() to spawn fewer processes.
https://bugs.webkit.org/show_bug.cgi?id=69589

Reviewed by Adam Barth.

When building with `make -j40`, all the binding rules are built en bloc. Since this script currently
uses subprocess.call(), that actually spawns 80 processes at once. OS X has a max process limit of
255 by default, so the build used to fail with
"open2: fork failed: Resource temporarily unavailable at ../bindings/scripts/preprocessor.pm line 60"
As a fix, use execvp() instead, which replaces the current process instead of spawning a new one.

  • WebCore.gyp/scripts/rule_binding.py:
#
23:37 on Sep 18, 2011WebKit
Commit by thakis@chromium.org :: r95398 Source/JavaScriptCore/ (ChangeLog JavaScriptCore.gypi):

Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

  • JavaScriptCore.gypi:
#
20:59 on Aug 31, 2011WebKit
Commit by thakis@chromium.org :: r94214 /trunk/ (6 files in 6 dirs):

Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
https://bugs.webkit.org/show_bug.cgi?id=67297

Reviewed by Tony Chang.

Source/WebCore:

I need this to disable smooth scrolling in chromium tests. I'm making
the change to ScrollAnimatorMac to make unforking the file easier. I
changed scrollAnimatorEnabled() to default to true so that this change
is a no-op for Safari; in chromium the flag is set explicitly to true
or false anyway.

  • page/Settings.cpp: (WebCore::Settings::Settings):
  • platform/chromium/ScrollAnimatorChromiumMac.mm: (WebCore::ScrollAnimatorChromiumMac::scroll):
  • platform/mac/ScrollAnimatorMac.mm: (WebCore::ScrollAnimatorMac::scroll): Tools: Explicitly disable smooth scrolling in chromium's DRT.
  • DumpRenderTree/chromium/WebPreferences.cpp: (WebPreferences::applyTo):
#