http://cia.vc/stats/author/thakis%40chromium.org21030615Python Subversion client for CIA1.18WebKitSource118312thakis@chromium.org[chromium/mac] Unbreak popup menus. https://bugs.webkit.org/show_bug.cgi?id=87325 Reviewed by David Levin. http://svn.webkit.org/repository/webkit/trunk@117607 added this function, but the Chromium/Mac build doesn't use the file added in that change and hence didn't have the category method.. Adding it doesn't help, as the category calls a 10.7-only function. Just don't use the category for chromium/mac. Fixes http://crbug.com/129418 * platform/mac/WebCoreNSCellExtras.h: 39WebCore/ChangeLogWebCore/platform/mac/WebCoreNSCellExtras.h1337843089Python Subversion client for CIA1.18WebKitSource117995thakis@chromium.orgGive FileInputType a setFiles() method, let Drag-n-Drop call it. https://bugs.webkit.org/show_bug.cgi?id=87139 Reviewed by Ojan Vafai. filesChosen(), the FileChooserClient callback, used to modify m_fileList directly. Instead, convert the FileChooserClient data to a FileList and pass that to a factored-out setFiles() method. This is in preparation to making the files property writable. Pure refactoring, no functionality change. * html/FileInputType.cpp: (WebCore::FileInputType::toFileList): (WebCore::FileInputType::setFiles): (WebCore::FileInputType::filesChosen): (WebCore): * html/FileInputType.h: (FileInputType): 135WebCore/ChangeLogWebCore/html/FileInputType.cppWebCore/html/FileInputType.h1337723748Python Subversion client for CIA1.18WebKitSource117209thakis@chromium.org[chromium] Remove some unused gyp lines https://bugs.webkit.org/show_bug.cgi?id=86545 Reviewed by Dirk Pranke. mac_framework_dirs adds directories to search for frameworks (similar to -I for includes), it doesn't add any frameworks. Having something that ends in .framewok in mac_framework_dirs doesn't make sense. No intended functionality change. * WebCore.gyp/WebCore.gyp: 58WebCore/ChangeLogWebCore/WebCore.gyp/WebCore.gyp1337152945Python Subversion client for CIA1.18WebKitSource116817thakis@chromium.org[chromium/mac] Let libwebkit.dylib link in Debug/components build https://bugs.webkit.org/show_bug.cgi?id=86244 Reviewed by James Robinson. In static builds, this was not needed because the targets depending on 'webkit' already link in QuartzCore. In Release components builds, it wasn't needed because they are built with -dead_strip, which stripped the referencing code. * WebCore.gyp/WebCore.gyp: 39WebCore/ChangeLogWebCore/WebCore.gyp/WebCore.gyp1336792821Python Subversion client for CIA1.18WebKitSource115893thakis@chromium.orgLet WebKit parse with clang on windows with -std=c++11 https://bugs.webkit.org/show_bug.cgi?id=85398 Reviewed by Ryosuke Niwa. See http://trac.webkit.org/changeset/85945 for background on the line I'm changing. With clang, __GXX_EXPERIMENTLAL_CXX0X__ is set in c++11 mode, but MSVC's c++ library doesn't have a tr1/memory header. So also check for __GLIBCXX__, like it's done in the rest of this file. * wtf/TypeTraits.h: 38WTF/ChangeLogWTF/wtf/TypeTraits.h1336010592Python Subversion client for CIA1.18WebKitSource115406thakis@chromium.orgDon't define WTF_COMPILER_SUPPORTS_CXX_NULLPTR twice when building with clang on windows. https://bugs.webkit.org/show_bug.cgi?id=85018 Reviewed by Anders Carlsson. Clang sets _MSC_VER when compiling for a -pc-win32 target (just like it sets __GNUC__ on unix). As a result, WTF_COMPILER_SUPPORTS_CXX_NULLPTR gets currently set twice, once for clang and once for _MSC_VER. Guard the second instance with !COMPILER(CLANG). This matches the gcc code for WTF_COMPILER_SUPPORTS_CXX_NULLPTR in the same file. * wtf/Compiler.h: 38WTF/ChangeLogWTF/wtf/Compiler.h1335513587Python Subversion client for CIA1.18WebKitSource115404thakis@chromium.org[chromium] Fix C++ language use. https://bugs.webkit.org/show_bug.cgi?id=85015 Reviewed by James Robinson. Even though MSVC allows it, a sizeof followed by a non-parenthesized typename is not valid C++. No functionality change. * rendering/RenderThemeChromiumWin.cpp: (WebCore): (WebCore::getNonClientMetrics): 40WebCore/ChangeLogWebCore/rendering/RenderThemeChromiumWin.cpp1335512449Python Subversion client for CIA1.18WebKitSource114606thakis@chromium.org[chromium/mac] Fix build. https://bugs.webkit.org/show_bug.cgi?id=84314 Unreviewed, build fix after http://trac.webkit.org/changeset/114604 * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::setBackingIOSurfaceId): 34WebKit/chromium/ChangeLogWebKit/chromium/src/WebPluginContainerImpl.cpp1334825417Python Subversion client for CIA1.18WebKitSource114227thakis@chromium.orgMake NullPtr.h compile with clang -std=c++11 and libstdc++4.2 https://bugs.webkit.org/show_bug.cgi?id=83999 Reviewed by Sam Weinig. Before this patch, NullPtr.h assumed that a working |nullptr| implied a working |std::nullptr_t| as well. With clang and libstdc++4.2, this is not true. I tested (-stdlib=libc++, -stdlib=libstdc++) x (-std=c++11, -std=c++03) with clang. * wtf/NullPtr.h: (std): 53WTF/ChangeLogWTF/wtf/NullPtr.h1334575046Python Subversion client for CIA1.18WebKitSource114201thakis@chromium.org[chromium] There is no Color(float, float, float) constructor, fix an attempt to call it. https://bugs.webkit.org/show_bug.cgi?id=83920 Reviewed by James Robinson. Found by clang: third_party/WebKit/Source/WebKit/chromium/tests/LayerChromiumTest.cpp:508:89:error: implicit conversion turns literal floating-point number into integer: 'float' to 'int' [-Werror,-Wliteral-conversion] EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(1, testLayer->setBackgroundColor(Color(0.4f, 0.4f, 0.4f))); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ * tests/LayerChromiumTest.cpp: 38WebKit/chromium/ChangeLogWebKit/chromium/tests/LayerChromiumTest.cpp1334387341Python Subversion client for CIA1.18WebKitTools113901thakis@chromium.org[mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin. https://bugs.webkit.org/show_bug.cgi?id=83709 Reviewed by Anders Carlsson. * DumpRenderTree/TestNetscapePlugIn/main.cpp: (handleEventCarbon): 55ChangeLogDumpRenderTree/TestNetscapePlugIn/main.cpp1334189830Python Subversion client for CIA1.18WebKitchromium110597thakis@chromium.orgMerge 110499 - [Skia] Release CGImage used to apply color space conversion to SkBitmap https://bugs.webkit.org/show_bug.cgi?id=80892 Patch by Brian Salomon <bsalomon@google.com> on 2012-03-12 Reviewed by Adam Barth. Regressions should be covered by any test that does image decode on the mac. * platform/image-decoders/skia/ImageDecoderSkia.cpp: (WebCore::resolveColorSpace): TBR=abarth@webkit.org Review URL: https://chromiumcodereview.appspot.com/9689079 137951025/Source/WebCore/ChangeLog1025/Source/WebCore/platform/image-decoders/skia/ImageDecoderSkia.cpp1331683162Python Subversion client for CIA1.18WebKitSource110510thakis@chromium.org[chromium/mac] Make sure libWebKitSystemInterface.a doesn't contain ppc object files. https://bugs.webkit.org/show_bug.cgi?id=80902 Reviewed by Adam Barth. Follow-up to http://codereview.chromium.org/9638015/ No intended behavior change. * WebCore.gyp/mac/adjust_visibility.sh: 40WebCore/ChangeLogWebCore/WebCore.gyp/mac/adjust_visibility.sh1331611124Python Subversion client for CIA1.18WebKitSource110251thakis@chromium.org[chromium] Only build NEON files if target_arch=="arm" https://bugs.webkit.org/show_bug.cgi?id=80626 Currently, webcore_arm_neon will compile a bunch of files whose contents are completely ifdef'd away on non-arm, and then bundle all the generated empty .o files into a useless libwebcore_arm_neon.a. Don't do this. Reviewed by Tony Chang. * WebCore.gyp/WebCore.gyp: * WebCore.gypi: 77WebCore/ChangeLogWebCore/WebCore.gyp/WebCore.gyp1331276527Python Subversion client for CIA1.18WebKitchromium107711thakis@chromium.orgMerge 107094 - Chromium: Fix Mac rubber band overhang drawing on composited pages and re-enable tests. https://bugs.webkit.org/show_bug.cgi?id=78007 This got broken by: http://trac.webkit.org/changeset/105470 And the tests were accidentally(?) disabled in: http://trac.webkit.org/changeset/95191 There is still three tests that fail from the set, but the cause for these is different, which I'm still investigating. Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-08 Reviewed by James Robinson. Source/WebKit/chromium: * src/NonCompositedContentHost.cpp: (WebKit::NonCompositedContentHost::NonCompositedContentHost): LayoutTests: * platform/chromium/test_expectations.txt: TBR=commit-queue@webkit.org Review URL: https://chromiumcodereview.appspot.com/9358057 33601025/LayoutTests/ChangeLog1025/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-n-expected.png1025/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-ne-expected.png1025/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-nw-expected.png1025/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-size-change-expected.png1025/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-sw-expected.png1025/LayoutTests/platform/chromium/compositing/rubberbanding/transform-overhang-w-expected.png1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne-expected.png1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-ne.html1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw-expected.png1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-nw.html1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se-expected.png1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-se.html1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw-expected.png1025/LayoutTests/platform/chromium/rubberbanding/custom-scrollbars-sw.html1025/LayoutTests/platform/chromium/rubberbanding/overhang-e-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-n-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-ne-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-nw-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-s-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-se-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-sw-expected.png1025/LayoutTests/platform/chromium/rubberbanding/overhang-w-expected.png1025/LayoutTests/platform/chromium/test_expectations.txt1025/Source/WebKit/chromium/ChangeLog1025/Source/WebKit/chromium/src/NonCompositedContentHost.cpp1329246583Python Subversion client for CIA1.18WebKitSource107618thakis@chromium.org[chromium] Let WebKit::initialize call InitWebCoreSystemInterface on mac. https://bugs.webkit.org/show_bug.cgi?id=78246 This allows removing a bunch of code in chromium land (https://chromiumcodereview.appspot.com/9374020/), and helps with the component build on mac (InitWebCoreSystemInterface is not an exported function, and it shouldn't be). Source/WebKit/mac/WebCoreSupport/WebSystemInterface.mm early-returns when it's called twice, so it's safe to land this change, and remove the calls in client code in a later CL. Reviewed by Darin Fisher. * src/WebKit.cpp: (WebKit::initializeWithoutV8): 55WebKit/chromium/ChangeLogWebKit/chromium/src/WebKit.cpp1329187069Python Subversion client for CIA1.18WebKitchromium107430thakis@chromium.orgMerge 106401 (part of http://crbug.com/111266) - [chromium] Expose windowResizerRectChanged() on WebWidget. https://bugs.webkit.org/show_bug.cgi?id=77453 Needed for http://crbug.com/111266 Reviewed by Darin Fisher. * public/WebWidget.h: (WebWidget): (WebKit::WebWidget::didChangeWindowResizerRect): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::didChangeWindowResizerRect): (WebKit): * src/WebViewImpl.h: (WebViewImpl): TBR=thakis@chromium.org Review URL: https://chromiumcodereview.appspot.com/9384018 3421025/Source/WebKit/chromium/ChangeLog1025/Source/WebKit/chromium/public/WebWidget.h1025/Source/WebKit/chromium/src/WebViewImpl.cpp1025/Source/WebKit/chromium/src/WebViewImpl.h1328919942Python Subversion client for CIA1.18WebKitSource106401thakis@chromium.org[chromium] Expose windowResizerRectChanged() on WebWidget. https://bugs.webkit.org/show_bug.cgi?id=77453 Needed for http://crbug.com/111266 Reviewed by Darin Fisher. * public/WebWidget.h: (WebWidget): (WebKit::WebWidget::didChangeWindowResizerRect): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::didChangeWindowResizerRect): (WebKit): * src/WebViewImpl.h: (WebViewImpl): 77WebKit/chromium/ChangeLogWebKit/chromium/public/WebWidget.hWebKit/chromium/src/WebViewImpl.cppWebKit/chromium/src/WebViewImpl.h1328062919Python Subversion client for CIA1.18WebKit106195thakis@chromium.org[chromium] Add support for building standalone webkit/chromium checkouts with ninja. https://bugs.webkit.org/show_bug.cgi?id=77243 Reviewed by Adam Barth. Source/WebKit/chromium: * gyp_webkit: Tools: * Scripts/update-webkit: * Scripts/webkitdirs.pm: (isChromiumNinja): (determineIsChromiumNinja): (buildChromiumNinja): (buildChromium): 190trunk/Source/WebKit/chromium/ChangeLogtrunk/Source/WebKit/chromium/gyp_webkittrunk/Tools/ChangeLogtrunk/Tools/Scripts/update-webkittrunk/Tools/Scripts/webkitdirs.pm1327806099Python Subversion client for CIA1.18WebKitSource105003thakis@chromium.orgRemove a unused variable. https://bugs.webkit.org/show_bug.cgi?id=76307 Reviewed by James Robinson. * platform/mac/ScrollElasticityController.mm: (WebCore::ScrollElasticityController::snapRubberBandTimerFired): 34WebCore/ChangeLogWebCore/platform/mac/ScrollElasticityController.mm1326509403