Commit by vprus :: src/gdb/ (ChangeLog remote.c):

• remote.c (remote_get_threadlist): If we got empty response, bail out immediately, and don't emit any warnings.

Commit by vprus :: src/gdb/ (8 files in 3 dirs):

Easier and more stubborn MI memory read commands.

      * mi/mi-cmds.c (mi_cmds): Register data-read-memory-bytes
      and data-write-memory-bytes.
      * mi/mi-cmds.h (mi_cmd_data_read_memory_bytes)
      (mi_cmd_data_write_memory_bytes): New.
      * mi/mi-main.c (mi_cmd_data_read_memory): Use regular target_read.
      (mi_cmd_data_read_memory_bytes, mi_cmd_data_write_memory_bytes):
      New.
      (mi_cmd_list_features): Add "data-read-memory-bytes" feature.
      * target.c (target_read_until_error): Remove.
      (read_whatever_is_readable, free_memory_read_result_vector)
      (read_memory_robust): New.
      * target.h (target_read_until_error): Remove.
      (struct memory_read_result, free_memory_read_result_vector)
      (read_memory_robust): New.

Commit by vprus :: src/gdb/ (ChangeLog mi/mi-main.c):

• mi/mi-main.c (mi_cmd_list_thread_groups): Adjust for current naming of thread groups (iN, not N).

Commit by vprus :: src/gdb/doc/ (ChangeLog gdb.texinfo):

• gdb.texinfo (GDB/MI Tracepoint Commands): Add comma after @xref.

Commit by vprus :: src/gdb/ (ChangeLog tracepoint.c):

• tracepoint.c (tvariables_info_1): Actually compute the number of rows in the result.

Commit by vprus :: src/gdb/doc/ (ChangeLog gdb.texinfo):

• gdb.texinfo (GDB/MI Tracepoint Commands): Document MI tracepoint commands.

Commit by vprus :: src/gdb/ (8 files in 2 dirs):

Implement -trace-save.

      * mi-cmds.h (mi_cmds_trace_save): Declare.
      * mi-cmds.c (mi_cmds): Register -trace-save.
      * mi/mi-main.c (mi_cmd_trace_save): New.
      * remote.c (remote_save_trace_data): Take const parameter.
      * target.h (struct target_ops::to_save_trace_data): Take
      const parameter.
      * target.c (update_current_target): Adjust to the above.
      * tracepoint.c (trave_save): New, extracted from
      (trace_save_command): ...this.
      (tfile_trace_find): Remove message that is unnecessary now
      that 'tfind' reports found frame.
      * tracepoint.h (trace_save): Declare.

Commit by vprus :: src/gdb/ (7 files in 2 dirs):

Implement -trace-find.

      * mi/mi-cmds.c (mi_cmds): Register -trace-find.
      * mi/mi-cmds.h (mi_cmd_trace_find): Declare.
      * mi/mi-main.c (mi_cmd_trace_find): New.
      * target.h (struct target_ops): Document to_trace_find.
      * tracepoint.h (tfind_1): Declare.
      * tracepoint.c (finish_tfind_command): Rename to...
      (tfind_1): ...this.
      * remote.c (remote_trace_find): Return -1 if target say
      there's no frame.  Improve error diagnostics.

Commit by vprus :: src/gdb/ (6 files in 2 dirs):

-trace-define-variable and -trace-list-variables.

      * tracepoint.c (create_trace_state_variable): Make
      private copy of name, as opposed to assuming the
      pointer lives forever.
      (tvariables_info_1): New.
      (tvariables_info): Use the above.
      * tracepoint.h (create_trace_state_variable, tvariables_info_1):
      Declare.
      * mi/mi-cmds.c (mi_cmds): Register -trace-define-variable
      and -trace-list-variables.
      * mi/mi-cmds.h (mi_cmd_trace_define_variable)
      (mi_cmd_trace_list_variables): New.
      * mi/mi-main.c (mi_cmd_trace_define_variable)
      (mi_cmd_trace_list_variables): New.

Commit by vprus :: src/gdb/ (4 files in 2 dirs):

Implement -break-passcount.

      * mi/mi-cmd-break.c (mi_cmd_break_passcount): New.
      * mi/mi-cmds.c (mi_cmds): Register -break-passcount.
      * mi/mi-cmds.h (mi_cmd_break_passcount): Declare.

Commit by vprus :: src/gdb/ (6 files in 2 dirs):

-trace-start/-trace-end/-trace-status.

      * mi/mi-cmds.c (mi_cmds): Register -trace-start, -trace-status
      and -trace-stop.
      * mi/mi-cmds.h (mi_cmd_trace_start, mi_cmd_trace_status)
      (mi_cmd_trace_stop): Declare.
      * mi/mi-main.c (mi_cmd_trace_start, mi_cmd_trace_status)
      (mi_cmd_trace_stop): New.
      * tracepoint.c (start_tracing): New, extracted from...
      (trace_start_command): ...this.
      (trace_status_mi): New.
      * tracepoint.h (struct trace_status): Document
      stopping_tracepoint.
      (start_tracing, stop_tracing, trace_status_mi): Declare.

Commit by vprus :: src/gdb/ (ChangeLog mi/mi-cmd-break.c):

Implement creating tracepoints with -break-insert.

      * mi/mi-cmd-break.c (mi_cmd_break_insert): Handle -a
      to mean that tracepoint should be created.

Commit by vprus :: src/gdb/ (ChangeLog breakpoint.c):

• breakpoint.c (check_no_tracepoint_commands): Use current spelling of 'teval'.

Commit by vprus :: src/gdb/ChangeLog:

Remove conflict marker.

Commit by vprus :: src/gdb/ (13 files in 6 dirs):

Unify actions and commands

      * defs.h (read_command_lines, read_command_lines_1): New
      parameters validator and closure.
      * tracepoint.h (struct action_line): Remove.
      * breakpoint.h (struct breakpoint): Remove the 'actions'
      field.
      * defs.h (enum command_control_type): New value
      while_stepping_control.
      (struct command_line): Add comments.
      * breakpoint.c (breakoint_is_tracepoint): New.
      (breakpoint_set_commands): For tracepoints,
      verify the commands are permissible.
      (check_tracepoint_commands): New.
      (commands_command): Require that each new line is validated using
      check_tracepoint_command, if we set commands for a tracepoint.
      (create_tracepoint_from_upload): Likewise.
      (print_one_breakpoint_location): Remove the code to print
      actions specifically.
      (tracepoint_save_command): Relay to print_command_lines.
      * cli/cli-script.c (process_next_line): New parameters validator
      and closure. Handle 'while-stepping'. Call validator if not null.
      (read_command_lines, read_command_lines1): Likewise.
      (recurse_read_control_structure): New parameters validator and
      closure. Handle while_stepping_control.
      (print_command_lines): Handle while-stepping.
      (get_command_line, define_command, document_command): Adjust.
      * remote.c (remote_download_tracepoint): Adjust.
      * tracepoint.c (make_cleanup_free_actions, read_actions)
      (free_actions, do_free_actions_cleanup): Remove.
      (trace_actions_command): Use read_command_lines.
      (validate_actionline): Use error in one place.
      (encode_actions_1): New, extracted from...
      (encode_actions): ...this. Also use cleanups for exception
      safety.
      (trace_dump_command): Adjust.
      * mi/mi-cmd-break (mi_cmd_break_commands): Validate commands if
      it's tracepoint.

Commit by vprus :: src/gdb/ (4 files in 2 dirs):

Simplify MI breakpoint setting.

      * breakpoint.c (break_command_really): Make nonstatic and
      rename to...
      (create_breakpoint): ...this. Rename prior function by this name
      to...
      (create_breakpoint_sal): ...this.
      (create_breakpoints): Rename to...
      (create_breakpoints_sal): ...this.
      (set_breakpoint): Remove.
      * breakpoint.h: Adjust to above changes.
      * mi/mi-cmd-break.c (mi_cmd_break_insert): Simplify.

Commit by vprus :: src/gdb/ (14 files in 4 dirs):

Multiexec MI

      * breakpoint.c (clear_syscall_counts): Take struct inferior*.
      * inferior.c (add_inferior_silent): Notify inferior_added
      observer.
      (delete_inferior_1): Notify inferior_removed observer.
      (exit_inferior_1): Pass inferior, not pid, to observer.
      (inferior_appeared): Likewise.
      (add_inferior_with_spaces): New.
      (add_inferior_command): Use the above.
      * inferior.h (delete_inferior_1, add_inferior_with_spaces):
      Declare.

      * inflow.c (inflow_inferior_exit): Likewise.
      * jit.c (jit_inferior_exit_hook): Likewise.

      * mi/mi-cmds.c (mi_cmds): Register add-inferior and
      remove-inferior.
      * mi/mi-cmds.h (mi_cmd_add_inferior, mi_cmd_remove_inferior): New.
      * mi/mi-interp.c (mi_inferior_added, mi_inferior_removed): New.
      (report_initial_inferior): New.
      (mi_inferior_removed): Register the above. Make sure
      inferior_added observer is called on the first inferior.
      (mi_new_thread, mi_thread_exit): Thread group is now identified by
      inferior number, not pid.
      (mi_solib_loaded, mi_solib_unloaded): Report which inferiors are
      affected.
      * mi/mi-main.c (current_context): New.
      (proceed_thread_callback): Use typed closure.
      Proceed everything if pid is 0. Most implementation split into
      (proceed_thread): ... this.
      (run_one_inferior): New.
      (mi_cmd_exec_continue, mi_cmd_exec_interrupt, mi_cmd_exec_run):
      Adjust for multiexec behaviour.
      (mi_cmd_add_inferior, mi_cmd_remove_inferior): New.
      (mi_cmd_execute): Handle the 'thread-group' option here.
      Do some extra checks.
      * mi-parse.c (mi_parse): Handle the --all and --thread-group
      options.
      * mi-parse.h (struct mi_parse): New fields all and thread_group.

Commit by vprus :: src/gdb/ (4 files in 2 dirs):

Make -exec-run a proper MI commands.

      * mi/mi-cmds.h (mi_cmd_exec_run): Declare.
      * mi/mi-cmds.c (mi_cmds): Adjust.
      * mi/mi-main.c (mi_cmd_exec_run): New.

Commit by vprus :: src/gdb/doc/ (ChangeLog gdb.texinfo):

• gdb.texinfo (GDB/MI Result Records): Clarify ^running.

Commit by vprus :: src/gdb/ (ChangeLog mi/mi-cmd-stack.c):

• mi/mi-cmd-stack.c (mi_cmd_stack_list_locals): Add extra whitespace character after a dot in comment. (mi_cmd_stack_list_arguments, mi_cmd_stack_list_variables): Likewise. (list_args_or_locals): For the 'all' (that is -stack-list-variables) case, always output list of tuples. Output 'arg' field if variable is argument.