CIA.vc
welwarsky
Real-time open source activity stats
Stats » Authors » welwarsky
informationsyndicateUTC clock
01:46 on May 27, 2012
event counters
The last message was received 2.23 years ago at 22:17 on Mar 06, 2010
0 messages so far today, 0 messages yesterday
0 messages so far this week, 0 messages last week
0 messages so far this month, 0 messages last month
9 messages since the first one, 2.93 years ago, for an average of 3.96 months between messages
recent messages
dateReversed sort columnprojectcontentlink
22:17 on Mar 06, 2010KDE
Commit by welwarsky :: r1100137 digikam/trunk/extragear/graphics/digikam/imageplugins/coreplugin/bwsepiatool.cpp:
prevent resource leaks, delete preview and settings because they have no parent.
#
22:16 on Mar 06, 2010KDE
Commit by welwarsky :: r1100136 digikam/trunk/extragear/graphics/digikam/libs/dimg/filters/bw/bwsepiasettings.cpp:
fix parent/child relations, based on my understanding
Layouts do not take ownership of the widgets they manage, those must be either explicitly deleted or or be child of another widget in the tree.
KTabWidget takes ownership of its tabs, those don't need a parent.
#
22:09 on Mar 06, 2010KDE
Commit by welwarsky :: r1100133 digikam/trunk/extragear/graphics/digikam/utilities/imageeditor/widgets/ (previewlist.cpp previewlist.h):
allow construction of PreviewList without a parent
PreviewThreadWrapper must not be a child of the PreviewLists parent, this causes crashes when the parent widget is destroyed before the PreviewLists destructor is called
#
23:30 on Mar 03, 2010KDE
Commit by welwarsky :: r1098586 digikam/trunk/extragear/graphics/digikam/imageplugins/coreplugin/autocorrectiontool.cpp:
Fix resource leak: make PreviewList a child of the AutoCorrectionTool instance instead of the ImagePlugin_core instance and explicitely delete it on destruction to free the stored autocorrection filters

For some reason the explicit delete is necessary, otherwise I get a crash on closing the application.
#
23:25 on Mar 03, 2010KDE
Commit by welwarsky :: r1098582 digikam/trunk/extragear/graphics/digikam/libs/dimg/filters/auto/ (10 files):
autocorrection filters don't need to deep-copy the reference image, let them share data with the original copy and make sure its treated const
#
23:19 on Mar 03, 2010KDE
Commit by welwarsky :: r1098578 digikam/trunk/extragear/graphics/digikam/utilities/imageeditor/editor/editortool.cpp:
when setting a new filter, be sure to delete the previous one
#
23:18 on Mar 03, 2010KDE
Commit by welwarsky :: r1098576 digikam/trunk/extragear/graphics/digikam/libs/dimg/filters/wb/ (wbfilter.cpp wbfilter.h):
be more pedantic about const'ness
#
22:54 on Mar 03, 2010KDE
Commit by welwarsky :: r1098567 digikam/trunk/extragear/graphics/digikam/libs/histogram/ (imagehistogram.cpp imagehistogram.h):
be more pedantic about const'ness
#
13:50 on Jun 21, 2009KDE
Commit by welwarsky :: r984825 digikam/trunk/extragear/graphics/digikam/digikam/dbstatdlg.cpp:
QList::length() is Qt 4.5 only.
QList::count() is equivalent and works for earlier versions
#