Commit by yourpalal on master :: rhrev44098 haiku/: (link)

Layout tweaks in Filetypes. Fixes #6449 [3 commits]

Commit by yourpalal on master :: rhrev44092 haiku/: (link)

Fix bug from the removal of BALMLayoutBuilder::Snake. [72 commits]

GCC considers the method chain one big function call, so pushes all
parameters onto the stack before hand (something I discovered after
quite a bit of debugging). In this case, layout->RightOf() returns NULL
before the view is added, which caused the layout to become undefined.

Commit by yourpalal on master :: rhrev43935 haiku/: (link)

Resolve TODO about possible use after free bug. [14 commits]

Commit by yourpalal on master :: rhrev43570 haiku/: (link)

Fix potential uninitialized variable bug in BLayout::AllUnarchived(). [3 commits]

BMessage::GetInfo() doesn't set the count output var in error cases.

Commit by yourpalal on master :: rhrev43547 haiku/: (link)

Remove clamping in new BSplitLayout methods.

Since clamping the index for these methods could lead to confusing side effects, we'll just avoid the clamping, and let things segfault when the programmer goes out of bounds.

Closes #7902

Commit by yourpalal on master :: rhrev43546 haiku/: (link)

Add Hannah Boneß to the AboutSystem contributors list. [2 commits]

Commit by yourpalal on master :: rhrev43514 haiku/: (link)

Merge branch 'master' of ssh://git.haiku-os.org/haiku [38 commits]

Commit by yourpalal :: r42346 /haiku/trunk/src/tests/kits/interface/layout/LayoutTest1.cpp:

Update LayoutTest1.cpp to use the templatized layout builders, and compile while I'm at it.

Commit by yourpalal :: r42303 /haiku/trunk/src/apps/devices/ (3 files):

Replace use of old layout-builder classes with new ones in devices app.

Commit by yourpalal :: r42228 /haiku/trunk/src/preferences/filetypes/ApplicationTypeWindow.cpp:

Make the 'Long description' textview in FileTypes use the BScrollView::SetBorderHighlighted() method when it is focused, also enable tab-key navigation (which was the whole purpose of creating the custom class used for the field) with the B_NAVIGABLE flag.

Commit by yourpalal :: r42224 /haiku/trunk/headers/os/interface/LayoutBuilder.h:

Add new constructors to BLayoutBuilder::Grid and BLayoutBuilder::Group that accept a plain old BView, and give it a new layout. These are very similar to the constructors that are already in place taking a BWindow. This solves a problem I have come across a few times, where one wants to build a layout in something like a BBox. Althought there is currently a way to do it with the layout builders, this is prettier.

Commit by yourpalal :: r42222 /haiku/trunk/ (2 files in 2 dirs):

Change the value of other spacing/inset constants so that B_USE_DEFAULT_SPACING has its own unique value. Also adjust BControlLook::ComposeSpacing() to reflect this.
closes #7447

Commit by yourpalal :: r42077 /haiku/trunk/ (6 files in 2 dirs):

• Add new SetInsets() methods to BTwoDimensionalLayout, BSplitView
• Also add equivalent methods to the layout builders in LayoutBuilder.h
• BSplitView now calls BControlLook::ComposeSpacing(), instead of BSplitLayout
• part of #7447

Commit by yourpalal :: r42025 /haiku/trunk/ (7 files in 2 dirs):

• Add new spacing/inset constants for the layout API. For now, leave B_USE_DEFAULT_SPACING, but this will go soon.
• Rename BControlLook::ComposeItemSpacing() to ComposeSpacing(), and extend it to handle the new constants.
• Adjust users of BControlLook::ComposeItemSpacing() accordingly.
• part of #7447

Commit by yourpalal :: r41781 /haiku/trunk/src/preferences/media/MediaWindow.cpp:

Shrink Media preflet main window by removing doubled spacing in one place, and using default spacing (11.0f) in place of a custom spacing (14.0f).
+alpha

Commit by yourpalal :: r41686 /haiku/trunk/src/apps/mediaconverter/ (2 files):

• Fix layout problem which appeared with the introduction of CollapsingLayouter. Basically, one of the layouts expected empty columns to act like glue, which is how they worked at the time. Now use BSpaceLayoutItem::CreateGlue() to get equivalent behaviour.
• Also do a very small bit of refactoring, to have MediaFileInfoView take better charge of its max size. +alpha

Commit by yourpalal :: r41665 /haiku/trunk/src/preferences/filetypes/FileTypesWindow.cpp:

Fix a typo I introduced in FileTypes in r41662, spotted by Axel (thanks!). Upon closer examination, the portion of code that contained the typo was superfluous, so I removed it all together.

+alpha

Commit by yourpalal :: r41664 /haiku/trunk/src/preferences/media/MediaWindow.cpp:

Replace use of sprintf with snprintf in media preflet. Fixes CID 7943 (secure coding).

Commit by yourpalal :: r41662 /haiku/trunk/src/preferences/filetypes/ (AttributeWindow.cpp FileTypesWindow.cpp):

Fix layout problems in Filetypes that became apparent with the introduction of CollapsingLayouter.
+alpha

Commit by yourpalal :: r41660 /haiku/trunk/src/kits/interface/layouter/CollapsingLayouter.cpp:

Remove unused method from CollapsingLayouter class.