Commit by Burkhard Lück on KDE/4.8 :: rv4.7.97-14-gdb679af ark/doc/index.docbook: (link)

doc update to 4.8.1

Commit by Raphael Kubo da Costa on master :: rv4.7.97-41-g5f03f7e ark/kerfuffle/cliinterface.cpp: (link)

GIT_SILENT: Remove superfluous parentheses

Commit by Theofilos Intzoglou on master :: rv4.7.97-40-gdbbb229 ark/: (link)

Merge branch 'master' of git://anongit.kde.org/ark

Commit by Raphael Kubo da Costa on master :: rv4.7.97-38-g83365ca ark/ (5 files in 4 dirs): (link)

Merge branch 'KDE/4.8'

Experimentally merge the stable (KDE/4.8) branch into master with `git merge
--log --edit -s recursive -Xours'. Some translation commits ended up being
merged, but tsdgeos said it's OK as they will be automatically reverted by
scripty.

• KDE/4.8: clizip: Define PasswordPromptPattern. cliinterface: A password prompt can also be shown when extracting. queries: Consider an empty password as a request cancellation. cliinterface: Correctly set QIODevice::Text. cli7zip: Completely remove RootNodeSwitch. SVN_SILENT made messages (.desktop file) SVN_SILENT made messages (.desktop file) SVN_SILENT made messages (.desktop file) fix linking order which fixes a linker issue on windows SVN_SILENT made messages (.desktop file) SVN_SILENT made messages (.desktop file) Add missing add_definition() calls. SVN_SILENT made messages (.desktop file) Save and restore the size of the internal viewer window. SVN_SILENT made messages (.desktop file) SVN_SILENT made messages (.desktop file) SVN_SILENT made messages (.desktop file)

Commit by Theofilos Intzoglou on master :: rv4.7.95-25-g6e8c9c3 ark/plugins/karchiveplugin/ (karchiveplugin.cpp karchiveplugin.h): (link)

ark karchive plugin extract all fix

If no item is selected from the archive, extract everything, check if
an entry is a directory and append a '/' if necessary and extract one file
at a time so we can check for overwriting and file errors.
REVIEW: 102960

Commit by Raphael Kubo da Costa on KDE/4.8 :: rv4.7.97-13-gf01dd13 ark/plugins/clizipplugin/cliplugin.cpp: (link)

clizip: Define PasswordPromptPattern.

Commit by Raphael Kubo da Costa on KDE/4.8 :: rv4.7.97-12-g24c5e1c ark/kerfuffle/cliinterface.cpp: (link)

cliinterface: A password prompt can also be shown when extracting.

This is a condition that is not currently exercised, but trying to fix
bug 291282 in another way made this problem more evident.

Suppose a user is asked for the archive password before the CLI
program is actually called to extract some files. If she presses OK
without entering a password, the code in CliInterface::copyFiles()
would not pass $PasswordSwitch to the CLI program because the password
is empty. In the case of infozip, it would then prompt the user for a
password, which would leave Ark stalled because there was no check for
a password prompt while already running the CLI program in extraction
mode.

Commit by Raphael Kubo da Costa on master :: rv4.7.95-24-g24b95be ark/kerfuffle/cliinterface.cpp: (link)

GIT_SILENT: Add TODO notes for the future.

Commit by Raphael Kubo da Costa on KDE/4.8 :: rv4.7.97-11-gc8913c3 ark/kerfuffle/queries.cpp: (link)

queries: Consider an empty password as a request cancellation.

Empty passwords do not make sense as valid passwords (infozip, rar and
the 7-Zip on Windows do not create archives with empty passwords, for
example).

Calling Query::setResponse(false) when an empty password is passed
makes the code in CliInterface consider the current action has been
canceled, as if the user has pressed the Cancel button in the password
query dialog, and not pass a single newline in password queries.

Even though the related bug report can also be considered to be caused
by PasswordPromptPattern not being defined for the clizip plugin and
CliInterface::handleLine() not checking for password prompts in Copy
mode, this commit has the advantage that the user is not prompted twice
for zip files if she enters an empty password the first time.

The user should be informed that the action has been canceled, but
this can be done in a separate commit.

BUG: 291282
FIXED-IN: 4.8.1

Commit by Raphael Kubo da Costa on KDE/4.8 :: rv4.7.97-10-g23b5cb6 ark/kerfuffle/cliinterface.cpp: (link)

cliinterface: Correctly set QIODevice::Text.

Calling setTextModeEnabled() only works with an open QIODevice, which
is not the case with KProcess here. Just pass QIODevice::Text to
setNextOpenMode() instead.

Commit by Raphael Kubo da Costa on KDE/4.8 :: rv4.7.97-9-g0e67d6d ark/plugins/cli7zplugin/cliplugin.cpp: (link)

cli7zip: Completely remove RootNodeSwitch.

Follow-up to 45c6c6f5bcff6bf754fccd6377836e025a6baade, which removed the
definition of RootNodeSwitch but did not remove the reference in
ExtractArgs, resulting in a crash whenever a 7z archive was extracted.

Commit by Patrick Spendrin on KDE/4.8 :: rv4.7.97-5-g467d80f ark/kerfuffle/tests/CMakeLists.txt: (link)

fix linking order which fixes a linker issue on windows

Commit by Patrick Spendrin on master :: rv4.7.95-23-g4a98e5f ark/kerfuffle/tests/CMakeLists.txt: (link)

fix linking order which fixes a linker issue on windows
(cherry picked from commit 467d80f0a87e9b79d0281f0a86e192e99d8ceb27)

Commit by Raphael Kubo da Costa on master :: rv4.7.95-22-g89cabc6 ark/kerfuffle/jobs.cpp: (link)

Remove unneeded includes.

GIT_SILENT

Commit by Raphael Kubo da Costa on master :: rv4.7.95-21-g15a8bc3 ark/part/ (part.cpp part.h): (link)

Rename updateSplitterSizes() to a more descriptive name.

"update" sounded as if the splitter itself would have its sizes
updated. The method, however, saves the splitter's sizes so they are
restored in the next run.

Commit by Raphael Kubo da Costa on master :: rv4.7.95-20-gf85478e ark/part/ (part.cpp part.h): (link)

Make m_previewDir a non-pointer variable.

At the small penalty of always creating a temporary directory instead
of only doing so if a file was previewed, we get rid of another
pointer and the associated manual memory management.

Commit by Raphael Kubo da Costa on KDE/4.8 :: rv4.7.95-6-g5149649 ark/CMakeLists.txt: (link)

Add missing add_definition() calls.

For some unknown reason, while the svn to git conversion work was going
on in branches/work/kdeutils-build-standalone, the lines adding
${QT_DEFINITIONS} and ${KDE4_DEFINITIONS} to the definitions passed to
the compiler end up not being included in each application's
CMakeLists.txt.

This was not a problem during the 4.7 series, as Dirk still packaged
kdeutils as a single tarball, and the top-level CMakeLists.txt used did
include these lines.

The issue came to attention during the 4.8 beta/RC phase, when 32-bit
Linux users had problems creating tarballs with Ark: libarchive is
usually built in those systems with -D_FILE_OFFSET_BITS=64. This is set
in KDE4_DEFINITIONS, which was not being used to build Ark. struct stat
then had different sizes for Ark and libarchive, which caused all sorts
of trouble.

Packagers might want to look at this commit and the equivalent ones to
the other affected kdeutils applications (filelight, kcalc, kcharselect,
kdf, kfloppy, kgpg, kremotecontrol, ktimer, kwallet, superkaramba and
sweeper) and apply them to their 4.8-RC packages.

Sorry for the mess!

BUG: 289307
FIXED-IN: 4.8.0
CCMAIL: release-team at kde dot org
CCMAIL: kde-packager at kde dot org

Commit by Raphael Kubo da Costa on master :: rv4.7.95-19-g52ada1c ark/CMakeLists.txt: (link)

Add missing add_definition() calls.

For some unknown reason, while the svn to git conversion work was going
on in branches/work/kdeutils-build-standalone, the lines adding
${QT_DEFINITIONS} and ${KDE4_DEFINITIONS} to the definitions passed to
the compiler end up not being included in each application's
CMakeLists.txt.

This was not a problem during the 4.7 series, as Dirk still packaged
kdeutils as a single tarball, and the top-level CMakeLists.txt used did
include these lines.

The issue came to attention during the 4.8 beta/RC phase, when 32-bit
Linux users had problems creating tarballs with Ark: libarchive is
usually built in those systems with -D_FILE_OFFSET_BITS=64. This is set
in KDE4_DEFINITIONS, which was not being used to build Ark. struct stat
then had different sizes for Ark and libarchive, which caused all sorts
of trouble.

Packagers might want to look at this commit and the equivalent ones to
the other affected kdeutils applications (filelight, kcalc, kcharselect,
kdf, kfloppy, kgpg, kremotecontrol, ktimer, kwallet, superkaramba and
sweeper) and apply them to their 4.8-RC packages.

Sorry for the mess!

CCBUG: 289307
FIXED-IN: 4.8.0
(cherry picked from commit 5149649d5388b570871f8579aaea1703136c9460)

Commit by Jonathan Marten on master :: rv4.7.95-18-g7b0f82b ark/part/ (arkviewer.cpp arkviewer.h): (link)

Option to view files with unknown MIME type as plain text.

If no viewer part or external viewer can be found for the file,
ask the user whether it should be shown in the internal viewer
as plain text.

Logic in ArkViewer::view() rearranged to reduce nesting and to
centralise MIME type determination in a single place.

REVIEW:103110
GUI:

Commit by Jonathan Marten on KDE/4.8 :: rv4.7.95-4-gd99ba06 ark/part/ (arkviewer.cpp arkviewer.h): (link)

Save and restore the size of the internal viewer window.

REVIEW:103581