Commit by Michael Jansen on master :: rv1.91.0-384-ga6e908d k3b/CMakeLists.txt: (link)

Remove find_package(Qt4) and QT_INCLUDES.

find_package(KDE4) looks for Qt and adds all necessary stuff to the KDE4_XX
variables.

Commit by Andrius da Costa Ribas on master :: rv1.91.0-379-g6309e02 k3b/src/CMakeLists.txt: (link)

Fix application icon path/filename.

Commit by Andrius da Costa Ribas on master :: rv1.91.0-378-g975c94d k3b/src/option/k3bdevicewidget.cpp: (link)

::cuserid is considered obsolete, and it's not available on Windows, getpwuid is provided by kdewin library.

Commit by Pino Toscano on master :: rv1.91.0-374-ga9c3e73 k3b/src/icons/update.sh: (link)

update.sh: save the icons as hicolor

given that:

• only application and mimetype icons are install in the global icon theme of the installation prefix
• other icon are installed locally in the k3b data dir we can pick the oxygen icons as "hicolor", and be (hopefully) safe they won't clash with other icon themes

Commit by Pino Toscano on master :: rv1.91.0-373-g62a07ca k3b/src/icons/mimetypes/CMakeLists.txt: (link)

mimetype icons: install in the global icon theme

now that they are "hicolor", install them among the global icon theme of the installation prefix;
this way there is a mimetype icon available even if the current icon theme is not oxygen

Commit by Pino Toscano on master :: rv1.91.0-372-g14dff02 k3b/src/icons/ (64 files in 3 dirs): (link)

icons: rename to hicolor

this way, they can be used even if the current icon theme is not oxygen
(they are installed in the k3b data dir, so there's no clash with global icons)

Commit by Pino Toscano on 2.0 :: rv2.0.1-74-g60dcd43 k3b/k3bsetup/k3bsetup: (link)

k3bsetup: fix the shebang line to be just /bin/sh

Commit by Pino Toscano on 2.0 :: rv2.0.1-73-gf86c398 k3b/k3bsetup/k3bsetup: (link)

k3bsetup: put the shebang in the first line

Commit by Rex Dieter on master :: rv1.91.0-370-g8d33a48 k3b/plugins/decoder/ffmpeg/CMakeLists.txt: (link)

fix for newer (kde-4.7+) FindFFMPEG.cmake
which sets ${FFMPEG_INCLUDE_DIRS} instead of ${FFMPEG_INCLUDE_DIR}

Commit by Christophe Giboudeaux on master :: rv1.91.0-366-g7e4fbdd k3b/COPYING: (link)

Fix address.

Commit by Sebastian Trueg on 2.0 :: rv2.0.1-66-ge9e8838 k3b/src/rip/videodvd/k3bvideodvdrippingdialog.cpp: (link)

Crash fix: check array boundaries

Commit by Sebastian Trueg on master :: rv1.91.0-364-g3386776 k3b/src/rip/videodvd/k3bvideodvdrippingdialog.cpp: (link)

Crash fix: check array boundaries

Commit by Burkhard Lück on master :: rv1.91.0-362-g1cd9575 k3b/doc/ (7 files): (link)

doc update to 2.1

Commit by Burkhard Lück on master :: rv1.91.0-361-g186b8b0 k3b/src/option/k3bexternalbinoptiontab.cpp: (link)

button name changed from Search to Refresh

Commit by Raphael Kubo da Costa on master :: rv1.91.0-358-gdfe605a k3b/libk3bdevice/k3bscsicommand_bsd.cpp: (link)

Refactor the FreeBSD SCSI/CAM interface.

>From the review request:
  Main idea of the change is to improve the case where SCSI sense data
  is not automatically provided and has to be explicitly requested.

  Current code essentially duplicates main transport code for this task.

  The proposed code recursively calls into the transport code with
  MMC_REQUEST_SENSE command.  This also fixes a problem with the existing
  code where it re-uses a CCB of the original command for sense fetching
  but doesn't ensure that all the previously used bytes are reset to
  proper values.

  This can result in a malformed MMC_REQUEST_SENSE CCB which can confuse
  certain hardware (e.g. it hangs Optiarc DVD RW AD-7191S 1.02).  Also the
  style of the code is cleaned up.

  Because of the code re-use the code is now more compact. Additionally
  some historic and useless code was dropped - the code for setting errno.
  errno value is not used by the calling code and this is an artifact of
  the FreeBSD-specific code having been borrowed from a different project
  (as attested by Heiner Eichmann <h dot eichmann at gmx dot de>).

Patch by Andriy Gapon <avg at FreeBSD dot org>, thanks a lot!

REVIEW: 103293

Commit by Raphael Kubo da Costa on 2.0 :: rv2.0.1-64-ga6a2ed3 k3b/libk3bdevice/k3bscsicommand_bsd.cpp: (link)

Refactor the FreeBSD SCSI/CAM interface.

>From the review request:
  Main idea of the change is to improve the case where SCSI sense data
  is not automatically provided and has to be explicitly requested.

  Current code essentially duplicates main transport code for this task.

  The proposed code recursively calls into the transport code with
  MMC_REQUEST_SENSE command.  This also fixes a problem with the existing
  code where it re-uses a CCB of the original command for sense fetching
  but doesn't ensure that all the previously used bytes are reset to
  proper values.

  This can result in a malformed MMC_REQUEST_SENSE CCB which can confuse
  certain hardware (e.g. it hangs Optiarc DVD RW AD-7191S 1.02).  Also the
  style of the code is cleaned up.

  Because of the code re-use the code is now more compact. Additionally
  some historic and useless code was dropped - the code for setting errno.
  errno value is not used by the calling code and this is an artifact of
  the FreeBSD-specific code having been borrowed from a different project
  (as attested by Heiner Eichmann <h dot eichmann at gmx dot de>).

Patch by Andriy Gapon <avg at FreeBSD dot org>, thanks a lot!

REVIEW: 103293
(cherry picked from commit dfe605a68406bd8830d3ab6c6e228f2c387a4122)

Commit by Michal Malek on master :: rv1.91.0-353-g8ead3ef k3b/ChangeLog: (link)

Changelog update

Commit by Andrius Štikonas on master :: rv1.91.0-351-g69d256e k3b/libk3b/tools/k3bmedium.cpp: (link)

i18n: Plurals should be used in the first argument.

Commit by Andrius Štikonas on master :: rv1.91.0-349-gc710035 k3b/src/k3bmediumdelegate.cpp: (link)

i18n: Plurals should be used in the first argument.

Commit by Christoph Feck on master :: rv1.91.0-348-g8c85900 k3b/tests/CMakeLists.txt: (link)

SVN_SILENT link