Commit by wikinaut :: r115450 /trunk/tools/viaf/ (viaf.bookmarklet.js viaf.js):

v1.22 fix for bug36879

Commit by krinkle :: r115449 /trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm:

follow-up r115448: fix typo

Commit by krinkle :: r115448 /trunk/tools/bugzilla/bugzilla-4.0/extensions/Wikimedia/Extension.pm:

bug_format_comment: +git commit, +gerrit Change-Id, update gerrit change set

• bug_format_comment - Fix redirect for GerritChangeset As of Gerrit 3.2 the link format is https://gerrit.wikimedia.org/r/#/c/1/ instead of https://gerrit.wikimedia.org/r/#change,1 Use the permalink without the hash instead. - Add linker for GerritChangeId (using gerrit query search) - Add linker for GitCommit (using gerrit query search)
• See also: - https://gerrit.wikimedia.org/r/9109

Commit by reedy :: r115447 /trunk/tools/gerrit-dippybird/dippy-bird.php:

Plurals!

Commit by siebrand :: r115446 /trunk/translatewiki/MediaWiki/mediawiki-defines.txt:

EducationProgram was already enabled again on twn.

Commit by raymond :: r115445 /trunk/extensions/ (33 files in 32 dirs):

Localisation updates from http://translatewiki.net.

Commit by siebrand :: r115444 /trunk/translatewiki/MediaWiki/mediawiki-defines.txt:

Remove superfluous newlines in previous commit.

Commit by siebrand :: r115443 /trunk/translatewiki/MediaWiki/mediawiki-defines.txt:

Update tags.

Commit by siebrand :: r115442 /trunk/tools/ToolserverI18N/language/messages/ (10 files):

Localisation updates from http://translatewiki.net.

Commit by siebrand :: r115441 /trunk/extensions/CSS/CSS.i18n.php:

Test commit. Assuming this will fail, because CSS is marked as being in git.Z

Commit by raymond :: r115440 /trunk/translatewiki/MediaWiki/mediawiki-defines.txt:

Revert r115439. See bug 37133

Commit by raymond :: r115439 /trunk/translatewiki/MediaWiki/mediawiki-defines.txt:

Disabled for the moment due to misconfiguration in Git

Checking AdManager
Initialized empty Git repository in /resources/projects/mediawiki-extensions/extensions/AdManager/.git/
error: The requested URL returned error: 401 while accessing https://gerrit.wikimedia.org/r/p/mediawiki/extensions/AdManager.git/info/refs
fatal: HTTP request failed
Clone of 'https://gerrit.wikimedia.org/r/p/mediawiki/extensions/AdManager.git' into submodule path 'extensions/AdManager' failed

Commit by krinkle :: r115438 /trunk/extensions/OnlineStatusBar/ (17 files in 3 dirs):

Follow-up r115430

• Escape messages before inserting into the document with .html(). Not just for security reasons but also for good function in general. As otherwise special characters can cause the interface to break unexpectedly. For example: $("<div>").html( mw.msg('blabla') ) Will unexpectedly be interpreted as HTML and create a <blabla> element in the DOM. Causing a blank spot in the interface instead of text "<blabla>" (which is better than nothing at all). Usually the best fix is to simply use .text() instead of .html(), but since one of the msg parameters here is an <img>, instead escaping the other parameters.
• Fix typo in .i18n.php: 'uknown' -> 'unknown'. This caused the following in the front-end: "&lt;onlinestatusbar-status-unknown&gt;", because the module and js code didn't have the typo.
• Fix using global variables mw and $ (aliasing from mediaWiki and jQuery instead). r115430 changed $() to jQuery(), but left inner code still referring to the $ global. Could be fixed by using jQuery(function ($) {}); (so that no additional closure is needed). But since mediaWiki>mw should be aliases as well, created a closure instead.
• Using .done() on the jqXHR (which inherits from $.Deferred) in $.ajax. The success/error/complete properties have been deprecated in favor of Deferred methods done(), fail() and always(). (the old AJAX properties are now aliases to these as of jQuery 1.7).
• Server can give status "online", "offline", "busy", "away" and "unknown". However front-end had no handling for "unknown". This caused a 404 error: GET /mw/extensions/OnlineStatusBar/resources/images/undefined 404 Added a statusgrey.png for it. Also added basic future proof check, never insert a 404 error.
• Moved addModules() call to where the html is added. No need to load this module on all pages unconditionally.
• Don't use setInterval for asynchronous and/or potentially long-running functions. Instead call it once and schedule again from a callback. Otherwise internet problems or slow connections can cause a long list of pending requests to build up. Done by using the always() callback (which fires both if the deferred is done or failed), and calling setTimeout (instead of setInterval) from there.
• Fix indention level of javascript code.
• Using Title case in ExtensionCredits name (like the rest of the code and documentation)
• Removed unused $wgOnlineStatusBarIcon configuration variable
• Removed unused $iconbar variable in JS.
• The HTML template inserted from PHP contained the (invisible) <div class="onlinestatusbaricon"></div> structure. I removed this since by default (no javascript) it is invisible, and the javascript replaces the html of the parent of this (thereby removing the element). So it wasn't used for anything at all. Removed then unused css as well.
• Skin style fixes: - standard: Using em instead of px, to match skin margin (it was slightly hangout outside the border in Chrome) - monobook: Remove negative top margin. overlapped sitenotice if there is a sitenotice. add 1em margin right. To match #content padding - simple: Set 1em margin right. To match #content padding - vector: Remove negative top margin. overlapped sitenotice if there is a sitenotice.
• I'm not sure what the class "metadata" is for, but left it as it is. Although it appears to be unused in the extension. Not used in core mediawiki either.

Commit by raymond :: r115437 /trunk/extensions/ (11 files in 11 dirs):

Localisation updates from http://translatewiki.net.

Commit by krinkle :: r115436 /trunk/extensions/OnlineStatusBar/ (4 files):

whitespace clean up

• Follows-up: * r115434 * r115433

Commit by mah :: r115435 /trunk/tools/bugzilla/client/ (20 files):

add misc junk

Commit by siebrand :: r115434 /trunk/extensions/OnlineStatusBar/ (7 files):

Update indentation and some other coding style related thingies.

No functional changes. Ping r115429.

Commit by siebrand :: r115433 /trunk/extensions/OnlineStatusBar/ (6 files):

stylize.php.

Commit by siebrand :: r115432 /trunk/extensions/OnlineStatus/ (4 files):

stylize.php and indentation tweaks.
bumped version number.

Commit by tstarling :: r115431 /trunk/php/luasandbox/ (6 files):

• Add our own copy of the string library, slightly patched to run hook functions during recursive match() operations. This avoids a request/emergency timeout for e.g. string.rep('x', 1000000):find('x*y'), which is O(N^2). Patch included.
• Include LUA_MASKCOUNT in the hook mask so that the hook will run after each instruction, not just each line. The exploit scenarios for this one are rather arcane since a one-line loop triggers the line hook on each iteration, but it couldn't hurt to fix it.