Commit by morrita@google.com :: r118660 Source/WebKit/chromium/ (ChangeLog src/FrameLoaderClientImpl.cpp):

Unreviewed Mac Chromium build fix.

• src/FrameLoaderClientImpl.cpp: (WebKit::FrameLoaderClientImpl::allowStyleScoped):

Commit by zandobersek@gmail.com :: r118659 Source/WebCore/ (7 files in 2 dirs):

Unreviewed, rolling out r118650.
http://trac.webkit.org/changeset/118650
https://bugs.webkit.org/show_bug.cgi?id=87639

Patch caused massive failures throughout the builders
(Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit dot review dot bot at gmail dot com> on 2012-05-28

• css/MediaQuery.cpp: (WebCore): (WebCore::MediaQuery::serialize): (WebCore::MediaQuery::MediaQuery): (WebCore::MediaQuery::cssText):
• css/MediaQuery.h: (WebCore::MediaQuery::expressions): (WebCore::MediaQuery::mediaType): (MediaQuery): (WebCore::MediaQuery::copy):
• css/MediaQueryEvaluator.cpp: (WebCore::MediaQueryEvaluator::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator): (WebCore::MediaQueryEvaluator::eval): (WebCore::aspect_ratioMediaFeatureEval): (WebCore::device_aspect_ratioMediaFeatureEval): (WebCore::transform_3dMediaFeatureEval): (WebCore::view_modeMediaFeatureEval): (WebCore::createFunctionMap):
• css/MediaQueryEvaluator.h: (WebCore): (MediaQueryEvaluator):
• css/StyleResolver.cpp: (WebCore): (WebCore::StyleResolver::collectMatchingRulesForList):
• css/StyleResolver.h: (MediaQueryResult): (WebCore::MediaQueryResult::MediaQueryResult): (WebCore): (StyleResolver):

Commit by commit-queue@webkit.org :: r118658 LayoutTests/ (2 files in 2 dirs):

[EFL] New tests added in r118567 should be skipped on EFL port
https://bugs.webkit.org/show_bug.cgi?id=87618

Unreviewed EFL gardening. Move the test added in r118567 to test
expectations since the EFL port lacks support for
LayoutTestController::layerTreeAsText.

Patch by Christophe Dumez <christophe dot dumez at intel dot com> on 2012-05-28

• platform/efl/test_expectations.txt:

Commit by gyuyoung.kim@samsung.com :: r118657 /trunk/ (20 files in 16 dirs):

Move allowRoundingHacks to Internals interface
https://bugs.webkit.org/show_bug.cgi?id=87328

Reviewed by Hajime Morita.

.:

• Source/autotools/symbols.filter: Add allowRoundingHacks symbol filter. Source/WebCore: Add allowRoundingHacks function, because it is able to work in the cross-port way by means of the Internals interface. In addition, a function is added in order to restore default setting values. No new tests, since we are improving here the infra-structure for testing a specific method.
• testing/Internals.cpp: (WebCore::Internals::reset): (WebCore): (WebCore::Internals::resetDefaultsToConsistentValues): (WebCore::Internals::allowRoundingHacks):
• testing/Internals.h: (Internals):
• testing/Internals.idl: Source/WebKit2:
• win/WebKit2.def: Add setAllowsRoundingHacks() to symbol filter. Tools: Remove allowRoundingHacks functions, because it is able to work in the cross-port way through the Internals interface.
• DumpRenderTree/LayoutTestController.cpp: (LayoutTestController::staticFunctions):
• DumpRenderTree/LayoutTestController.h: (LayoutTestController):
• DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
• DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
• DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
• DumpRenderTree/mac/LayoutTestControllerMac.mm:
• DumpRenderTree/win/LayoutTestControllerWin.cpp:
• DumpRenderTree/wx/LayoutTestControllerWx.cpp: LayoutTests: Invoke allowRoundingHacks function from internals, because it is able to work in the cross-port way via the Internals interface.
• platform/mac/fast/text/rounding-hacks-expansion.html:
• platform/mac/fast/text/rounding-hacks.html:

Commit by macpherson@chromium.org :: r118656 Tools/ (2 files in 2 dirs):

Fix mac build with older XCode by defining NSEC_PER_MSEC.
https://bugs.webkit.org/show_bug.cgi?id=87616

Reviewed by Hajime Morita.

The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
Patch just adds a #ifndef / #define check.

• DumpRenderTree/mac/FrameLoadDelegate.mm: (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):

Commit by commit-queue@webkit.org :: r118655 Source/WebCore/ (2 files in 2 dirs):

[BlackBerry] http authentication crash the browser when user commit or cancel the http authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=87579

Patch by Jonathan Dong <jonathan dot dong at torchmobile dot com dot cn> on 2012-05-28
Reviewed by George Staikos.

In function NetworkJob::startNewJobWithRequest, We should cancel the
NetworkJob first before we start a new NetworkJob which reuses the
resource handle of the old one. If we only set the m_handle = 0 of the
old NetworkJob without cancelling itself, it will still receives data
notification from network thread and handles the received data with
the released resource handler, which will cause the crash.

No new tests because no behavior has changed.

• platform/network/blackberry/NetworkJob.cpp: (WebCore::NetworkJob::startNewJobWithRequest):

Commit by morrita@google.com :: r118654 Source/WebCore/ (4 files in 2 dirs):

[Refactoring][ShadowDOM] Some ElementShadow methods can be inlined.
https://bugs.webkit.org/show_bug.cgi?id=87617

Reviewed by Kentaro Hara.

Inlined ElementShadow::attachHost(), ElementShadow::detachHost() and
ElementShadow::reattach()

No new tests. No behavior change.

• dom/Element.cpp: (WebCore::Element::attach): (WebCore::Element::detach):
• dom/ElementShadow.cpp: (WebCore::ElememtnShadow::reattachHostChildrenAndShadow):
• dom/ElementShadow.h: (ElementShadow):

Commit by morrita@google.com :: r118653 Source/WebKit/chromium/ (3 files in 2 dirs):

https://bugs.webkit.org/show_bug.cgi?id=87609
[Chromium] FrameLoaderClient::allowStyleScoped() should be implemented interms of WebPermissionClient

Reviewed by Kent Tamura.

Added allowStyleScoped() implementation which is essentially same as shadowDOMAllowed().

• src/FrameLoaderClientImpl.cpp:
• src/FrameLoaderClientImpl.h: (FrameLoaderClientImpl):

Commit by commit-queue@webkit.org :: r118652 Source/WebCore/ (7 files in 2 dirs):

Web Inspector: CodeGeneratorInspector.py: protect typed API from C++ implicit float to int cast
https://bugs.webkit.org/show_bug.cgi?id=87183

Patch by Peter Rybin <peter dot rybin at gmail dot com> on 2012-05-28
Reviewed by Yury Semikhatsky.

An intermediate C++ class is introduced that uses C++ template technique to control actual type
of its constructor argument.
All input parameters of type "int" now have type ExactlyInt.
All usage sites are fixed accordingly.

• inspector/CodeGeneratorInspector.py: (TypeModel.RefPtrBased): (TypeModel.Enum): (TypeModel.ValueType): (TypeModel.ValueType.get_opt_output_type_): (TypeModel.ValueType.ValueOptional.get_command_return_pass_model): (TypeModel.ExactlyInt): (TypeModel.ExactlyInt.__init__): (TypeModel.ExactlyInt.get_input_param_type_text): (TypeModel.ExactlyInt.get_opt_output_type_): (TypeModel.init_class): (ExactlyInt):
• inspector/InspectorAgent.cpp: (WebCore::InspectorAgent::enable): (WebCore::InspectorAgent::didCreateWorker): (WebCore::InspectorAgent::didDestroyWorker): (WebCore::InspectorAgent::evaluateForTestInFrontend):
• inspector/InspectorApplicationCacheAgent.cpp: (WebCore::InspectorApplicationCacheAgent::updateApplicationCacheStatus): (WebCore::InspectorApplicationCacheAgent::getFramesWithManifests):
• inspector/InspectorDOMAgent.cpp: (WebCore::InspectorDOMAgent::buildObjectForNode):
• inspector/InspectorMemoryAgent.cpp: (WebCore::jsHeapInfo): (WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
• inspector/PageRuntimeAgent.cpp: (WebCore::PageRuntimeAgent::notifyContextCreated):

Commit by haraken@chromium.org :: r118651 Source/WebCore/ (12 files in 3 dirs):

Unreviewed. Rebaselined run-binding-tests results.

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::JSTestActiveDOMObjectOwner::finalize):
• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: (WebCore::JSTestCustomNamedGetterOwner::finalize):
• bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::JSTestEventConstructorOwner::finalize):
• bindings/scripts/test/JS/JSTestEventTarget.cpp: (WebCore::JSTestEventTargetOwner::finalize):
• bindings/scripts/test/JS/JSTestException.cpp: (WebCore::JSTestExceptionOwner::finalize):
• bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterfaceOwner::finalize):
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListenerOwner::finalize):
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructorOwner::finalize):
• bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObjOwner::finalize):
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize):
• bindings/scripts/test/V8/V8TestObj.cpp: (WebCore::V8TestObj::installPerContextProperties):

Commit by darin@apple.com :: r118650 Source/WebCore/ (7 files in 2 dirs):

StyleResolver need not allocate each MediaQueryResult on the heap
https://bugs.webkit.org/show_bug.cgi?id=75223

Reviewed by Daniel Bates.

• css/MediaQuery.cpp: Removed some comments that pointed to CSS documents. There is no guarantee these links will be valid over time. (WebCore::MediaQuery::MediaQuery): Rewrote for clarity, conventional WebKit coding style, and simplicity. (WebCore::MediaQuery::copy): Moved out of line; not performance critical, and this allows us to cut down header dependencies. (WebCore::MediaQuery::cssText): Updated for change to data member name.
• css/MediaQuery.h: Removed unneeded includes. Removed non-helpful argument name "exprs". Changed expressions function to return a reference instead of a pointer. Changed mediaType and cssText functions to return a reference. Renamed m_serializationCache to m_serializedQuery. Moved copy function out of header.
• css/MediaQueryEvaluator.cpp: Renamed EvalFunc to MediaFeatureEvaluationFunction. Broke a FIXME into three and reworded for clarity. (WebCore::MediaQueryEvaluator): Updated for name changes. (WebCore::MediaQueryEvaluator::eval): Rewrote this for clarity and to regularize the logic a bit. (WebCore::aspect_ratioMediaFeatureEval): Got rid of a != 0 that is contrary to the normal WebKit style. (WebCore::device_aspect_ratioMediaFeatureEval): Ditto. (WebCore::transform_3dMediaFeatureEval): Fixed mangled #if that was here. (WebCore::view_modeMediaFeatureEval): Replaced UNUSED_PARAM usage with ASSERT_UNUSED. (WebCore::createFunctionMap): Changed this so it returns the map so we can use a cleaner style in the caller. (WebCore::MediaQueryEvaluator::eval): Updated to take a reference and improved the comments and coding style a bit.
• css/MediaQueryEvaluator.h: Updated comment style. Removed unused constructor. Removed unneeded destructor declaration. Renamed m_expResult to m_mediaFeatureResult.
• css/StyleResolver.cpp: Moved the MediaQueryResult class into this file and made it a structure rather than a class. (WebCore::StyleResolver::addViewportDependentMediaQueryResult): Updated to take a reference argument instead of a pointer and for the new vector type. (WebCore::StyleResolver::affectedByViewportChange): Updated for above changes.
• css/StyleResolver.h: Removed many unneeded includes and forward declarations of classes, including now-unneeded include of MediaQueryExp.h. Replaced MediaQueryResult definition with a forward declaration. Changed addViewportDependentMediaQueryResult to take a reference instead of a pointer. Changed m_viewportDependentMediaQueryResults to be a vector of values rather than of pointers.

Commit by darin@apple.com :: r118649 Source/WTF/ (ChangeLog wtf/Vector.h):

Fix an incorrect assertion in Vector::remove
https://bugs.webkit.org/show_bug.cgi?id=87612

Reviewed by Dan Bernstein.

• wtf/Vector.h: There's no good reason to disallow calling remove with a size of 0, even when the position is at the end of the vector, so changed the two-argument Vector::remove assertion to assert that the position is <= size rather than < size.

Commit by shinyak@chromium.org :: r118648 /trunk/ (7 files in 4 dirs):

cut, copy or paste event won't be fired in Shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=87352

Reviewed by Dimitri Glazkov.

Source/WebCore:

cut, copy or paste event was not fired in Shadow DOM.
Since event re-targeting has been implemented, it should be safe to fire them in Shadow DOM now.

Tests: fast/dom/shadow/cppevent-in-shadow.html
fast/dom/shadow/cppevent-input-in-shadow.html

• editing/Editor.cpp: (WebCore::Editor::findEventTargetFrom): LayoutTests:
• fast/dom/shadow/cppevent-in-shadow-expected.txt: Added.
• fast/dom/shadow/cppevent-in-shadow.html: Added.
• fast/dom/shadow/cppevent-input-in-shadow-expected.txt: Added.
• fast/dom/shadow/cppevent-input-in-shadow.html: Added.

Commit by commit-queue@webkit.org :: r118647 /trunk/ (7 files in 6 dirs):

[EFL] Enable blob support for the EFL port
https://bugs.webkit.org/show_bug.cgi?id=85363

Patch by Sudarsana Nagineni <sudarsana dot nagineni at linux dot intel dot com> on 2012-05-27
Reviewed by Hajime Morita.

.:

Enable Blob support by default for the EFL port.

• Source/cmake/OptionsEfl.cmake: Tools: Enable Blob support by default for the EFL port.
• Scripts/webkitperl/FeatureList.pm: LayoutTests: Unskip tests which require blob support to be enabled.
• platform/efl/Skipped:
• platform/efl/test_expectations.txt:

Commit by ggaren@apple.com :: r118646 Source/JavaScriptCore/ (6 files in 2 dirs):

Weak pointer finalization should be lazy
https://bugs.webkit.org/show_bug.cgi?id=87599

Reviewed by Darin Adler.

• heap/Heap.cpp: (JSC::Heap::collect): Don't force immediate finalization -- it will happen lazily.
• heap/MarkedBlock.cpp: (JSC::MarkedBlock::sweep): Sweep a block's weak set when sweeping the block. The weak set may not have been swept yet, and this is our last chance to run weak finalizers before we recycle the memory they reference.
• heap/MarkedBlock.h:
• heap/MarkedSpace.cpp: (JSC::MarkedBlock::sweepWeakSets):
• heap/MarkedSpace.h: (JSC::MarkedSpace::sweepWeakSets): Nixed sweepWeakSets because it's unused now.

Commit by hayato@chromium.org :: r118645 /trunk/ (5 files in 4 dirs):

Support multiple shadow roots in event dispatching.
https://bugs.webkit.org/show_bug.cgi?id=87470

Reviewed by Dimitri Glazkov.

Source/WebCore:

The current implementation does not set event's target correctly
if an event happens on DOM tree with multiple shadow roots. So
this patch updates an event re-targeting algorithm so that it
works even if it is applied to multiple shadow roots.

Tests: fast/dom/shadow/shadow-dom-event-dispatching.html

• dom/ComposedShadowTreeWalker.cpp: (WebCore::ComposedShadowTreeWalker::traverseParentIncludingInsertionPointAndShadowRoot):
• dom/EventDispatcher.cpp: (WebCore::EventDispatcher::ensureEventAncestors): LayoutTests:
• fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
• fast/dom/shadow/shadow-dom-event-dispatching.html:

Commit by benjamin@webkit.org :: r118644 Source/WebCore/ (3 files in 2 dirs):

Minor code cleaning for the interface of MainResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=87607

Reviewed by Darin Adler.

• loader/MainResourceLoader.cpp: (WebCore::MainResourceLoader::MainResourceLoader): (WebCore::MainResourceLoader::handleSubstituteDataLoadNow): (WebCore::MainResourceLoader::handleSubstituteDataLoadSoon):
• loader/MainResourceLoader.h: (MainResourceLoader): -Add the OVERRIDE keyword for the methods inherited from ResourceLoader. -Remove the useless declaration of handleDataLoad(ResourceRequest&), this method does not exist. -Rename handleDataLoadNow() to handleSubstituteDataLoadNow() and make the method private. This should only be used by handleSubstituteDataLoadSoon() and indirectly through the timer.

Commit by yosin@chromium.org :: r118643 Source/ (4 files in 4 dirs):

[WTF] Introduce UINT64_C to MathExtras.h
https://bugs.webkit.org/show_bug.cgi?id=87485

Reviewed by Kent Tamura.

Source/WebCore:

This patch introduces UINT64_C for all platforms to avoid using
conditional compilation.

No new tests. This patch doesn't change behavior.

• Modules/websockets/WebSocketFrame.cpp: (WebCore::WebSocketFrame::parseFrame): Replace conditional compilation with UINT64_C. Source/WTF:
• wtf/MathExtras.h:

Commit by mitz@apple.com :: r118642 /releases/Apple/Safari 5.1.7/ (6 files in 6 dirs):

Added a tag for the Safari 5.1.7 release.

Safari 5.1.7 includes JavaScriptCore-x534.57.3, JavaScriptGlue-x534.57.2, WebCore-x534.57.2, WebKit-x534.57.2, and WebKit2-x534.57.2.

Commit by mitz@apple.com :: r118641 /releases/Apple/OS X Lion Update 10.7.4/ (5 files in 5 dirs):

Added a tag for the OS X Lion Update 10.7.4 release.

OS X Lion v10.7.4 includes JavaScriptCore-7534.56.6, WebCore-7534.56.5, WebKit-7534.56.5, and WebKit2-7534.56.5.