2009-11-21  Eric Seidel  <eric at webkit dot org>

        Reviewed by Adam Barth.

        bugzilla-tool --help spews way too much text
        https://bugs.webkit.org/show_bug.cgi?id=31771

        * Scripts/bugzilla-tool:
         - Remove self.cached_scm initialization hack.
        * Scripts/modules/buildbot.py:
         - Make default_host accessible to callers.
        * Scripts/modules/commands/download.py:
         - Phrase help for all commands consistently and remove spurious help text punctuation.
        * Scripts/modules/commands/queries.py: Ditto.
        * Scripts/modules/commands/queues.py: Ditto.
        * Scripts/modules/commands/upload.py: Ditto.
        * Scripts/modules/multicommandtool.py:
         - Add HelpPrintingOptionParser.format_epilog to replace
           NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
           per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
         - Make --help only show a list of commands like "svn help" and "git help" do --
           previously --help was listing all commands and options.
         - Sort list of commands alphabetically.

2009-11-21  Jon Honeycutt  <jhoneycutt at apple dot com>

        Windows build fix. Unreviewed.

        * Interfaces/IWebSerializedJSValue.idl:

2009-11-21  Daniel Bates  <dbates at webkit dot org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=31647

        Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.

        No functionality was changed. So, no new tests.

        * dom/KeyboardEvent.cpp:
        (WebCore::KeyboardEvent::~KeyboardEvent):
        * dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
        (WebCore::KeyboardEvent::keyEvent):

2009-11-21  Eric Seidel  <eric at webkit dot org>

        No review.  Fixing a typo from the previous patch for bug 31767.

        AbstractQueue.run_bugzilla_tool throws an exception
        https://bugs.webkit.org/show_bug.cgi?id=31769

        * Scripts/modules/commands/queues.py:

2009-11-21  Eric Seidel  <eric at webkit dot org>

        Reviewed by Adam Barth.

        commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
        https://bugs.webkit.org/show_bug.cgi?id=31767

        What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
        Since we don't have a good way to test BugzillaTool pieces, I've
        left out a test for now.

        * Scripts/bugzilla-tool:
         - Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
        * Scripts/modules/commands/queues.py:
         - Use tool.path() instead of __file__.
        * Scripts/modules/multicommandtool.py:
         - Add a new path() method to MultiComandTool.
        * Scripts/modules/multicommandtool_unittest.py:
         - Provide a path() method.  Little point in testing this mock implementation.

2009-11-21  Adam Barth  <abarth at webkit dot org>

        Unreviewed "build" fix.  Turns out I was testing the wrong copy of
        WebKitTools.

        * Scripts/modules/commands/download.py:

2009-11-21  Adam Barth  <abarth at webkit dot org>

        Reviewed by Eric Seidel.

        Convert check-style to use LandingSequence
        https://bugs.webkit.org/show_bug.cgi?id=31763

        Instead of manipulating the working copy by hand, we should use the
        LandingSequence in CheckStyle.  This will make this code eaiser to
        test.

        * Scripts/modules/commands/download.py:

DOMElement::tagName() is unimplemented

https://bugs.webkit.org/show_bug.cgi?id=31746

Reviewed by Darin Adler.

• DOMCoreClasses.cpp: (DOMElement::tagName): Create a BString from the element's tag name, and release its BSTR into result.

DOMNode::childNodes() is unimplemented

https://bugs.webkit.org/show_bug.cgi?id=31745

Reviewed by Darin Adler.

• DOMCoreClasses.cpp: (DOMNode::childNodes): Create a DOMNodeList from the node's child nodes.

2009-11-20  Adam Barth  <abarth at webkit dot org>

        Reviewed by Eric Seidel.

        Unit test query commands
        https://bugs.webkit.org/show_bug.cgi?id=31755

        These tests are pretty rough, but hopefully they'll grow.

        * Scripts/modules/commands/queries_unittest.py: Added.
        * Scripts/modules/mock_bugzillatool.py: Added.
        * Scripts/run-webkit-unittests:

2009-11-20  Eric Seidel  <eric at webkit dot org>

        Reviewed by Adam Barth.

        Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
        https://bugs.webkit.org/show_bug.cgi?id=31758

        * Scripts/modules/multicommandtool.py:
         - Allow passing of explicit commands to MultiCommandTool.__init__
        * Scripts/modules/multicommandtool_unittest.py:
         - Use new Command.name naming system.
         - Test Command auto-discovery.
        * Scripts/modules/workqueue.py:
         - bug_id no longer exists, use patch['bug_id'] instead.
        * Scripts/modules/workqueue_unittest.py:
         - WorkQueues require names now.
         - should_proceed_with_work_item must return a patch object.

WAI-ARIA: add support for aria-owns
https://bugs.webkit.org/show_bug.cgi?id=31702

Reviewed by Beth Dakin.

WebCore:

Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.

Test: platform/mac/accessibility/aria-owns.html

• accessibility/AccessibilityObject.h: (WebCore::AccessibilityObject::supportsARIAOwns): (WebCore::AccessibilityObject::ariaOwnsElements):
• accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::ariaOwnsElements): (WebCore::AccessibilityRenderObject::supportsARIAOwns):
• accessibility/AccessibilityRenderObject.h:
• accessibility/mac/AccessibilityObjectWrapper.mm: (-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeNames]): (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
• html/HTMLAttributeNames.in: WebKitTools:
• DumpRenderTree/AccessibilityUIElement.cpp: (ariaOwnsElementAtIndexCallback): (AccessibilityUIElement::getJSClass):
• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: (AccessibilityUIElement::ariaOwnsElementAtIndex):
• DumpRenderTree/mac/AccessibilityUIElementMac.mm: (AccessibilityUIElement::ariaOwnsElementAtIndex):
• DumpRenderTree/win/AccessibilityUIElementWin.cpp: (AccessibilityUIElement::ariaOwnsElementAtIndex): LayoutTests:
• platform/mac/accessibility/aria-owns-expected.txt: Added.
• platform/mac/accessibility/aria-owns.html: Added.

2009-11-20  Eric Seidel  <eric at webkit dot org>

        Reviewed by Adam Barth.

        Fix exception thrown when running the commit-queue.

        * Scripts/modules/statusbot.py: patch is optional.
        * Scripts/modules/workqueue.py: WorkQUeue requires a name.

Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.

Reviewed by Jon Honeycutt.

Fix a typo in serialize() caused when fixing build bustage (put a ! back in).

• Interfaces/IWebSerializedJSValue.idl:
• WebSerializedJSValue.cpp: (WebSerializedJSValue::WebSerializedJSValue): (WebSerializedJSValue::createInstance): (WebSerializedJSValue::serialize): (WebSerializedJSValue::deserialize):
• WebSerializedJSValue.h:

Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.

Reviewed by Dave Hyatt.

• Interfaces/IWebSerializedJSValue.idl:
• Interfaces/JavaScriptCoreAPITypes.idl:
• WebKit.vcproj/Interfaces.vcproj:
• WebSerializedJSValue.cpp: (WebSerializedJSValue::deserialize):
• WebSerializedJSValue.h:

Make sure to export WebSerializedJSValue.

Reviewed by Darin Adler.

• WebKit.exp:

Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.

Reviewed by Dave Hyatt.

• Interfaces/IWebFrameLoadDelegate.idl:
• Interfaces/IWebSerializedJSValue.idl:
• Interfaces/JavaScriptCoreAPITypes.idl: Added.
• Interfaces/WebKit.idl:
• WebKit.vcproj/Interfaces.vcproj:

2009-11-20  Eric Carlson  <eric dot carlson at apple dot com>

        Reviewed by Simon Fraser.

        <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

        * css/mediaControls.css:
            Define closed caption toggle button.

        * rendering/RenderMedia.cpp:
        (WebCore::RenderMedia::updateControls):
            Create closed caption toggle button in display order.

        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::shouldRenderMediaControlPart):
            Don't require MediaControllerThemeQuickTime theme for captions toggle button.
            No need to check if the movie has video, a closed captions track is a video
            track.

2009-11-20  Eric Carlson  <eric dot carlson at apple dot com>

        Reviewed by Simon Fraser.

        <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

2009-11-20  Eric Carlson  <eric dot carlson at apple dot com>

        Reviewed by Simon Fraser.

        <rdar://problem/7414396> Leopard & Tiger: Support closed caption in <video> element

        Remove closed captions test from skipped list.

        * platform/mac-leopard/Skipped:
        * platform/mac-tiger/Skipped:

Not reviewed. Fix chromium build.

• public/WebAccessibilityRole.h: (WebKit::):
• src/AssertMatchingEnums.cpp:

2009-11-20  Joseph Pecoraro  <joepeck at webkit dot org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Running code in the Console that ends with a
        single line comment no longer produces a parse error.

        * inspector/front-end/InjectedScript.js:
        (InjectedScript._evaluateOn):