date | project | content | link |
|---|
| 18 sec ago | WebKit | Commit by kov@webkit.org :: r117280 /releases/WebKitGTK/webkit-1.8/ (5 files in 4 dirs): Merge 113825 - Crash due to intruding float not removed from next siblings. https://bugs.webkit.org/show_bug.cgi?id=83301
Reviewed by Eric Seidel.
Source/WebCore:
Test: fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html
markSiblingsWithFloatsForLayout currently only handled overhanging floats and made checks for those by checking if logicalBottomForFloat > our logicalHeight. We need to take care of intruding floats as well, since these can intrude into the neighbouring blocks too. So, generalized the function to check all our next siblings if they contains that float (one getting removed) and if yes, mark it and all its descendants for layout. This fixes the crash.
For performance, we change the looping condition to iterate over the next sibling blocks first and finding which ones can contain floats and then check it against our floating object list. Currently, it is the other way around and is less performant due to repeated calls to isRenderBlock(), isFloatingOrPositioned() and avoidFloats().
- rendering/RenderBlock.cpp: (WebCore::RenderBlock::markSiblingsWithFloatsForLayout): LayoutTests:
- fast/block/float/intruding-float-not-removed-from-next-sibling-crash-expected.txt: Added.
- fast/block/float/intruding-float-not-removed-from-next-sibling-crash.html: Added.
| # |
| 39 sec ago | WebKit | Commit by kov@webkit.org :: r117279 /releases/WebKitGTK/webkit-1.8/ (5 files in 4 dirs): Merge 113670 - ASSERTION FAILED: !attached() in Node::attach. https://bugs.webkit.org/show_bug.cgi?id=80726
Reviewed by Adam Barth.
Source/WebCore:
While parsing XML document, prevent attaching the leaf text node back to document, if its parent is not attached.
Test: fast/dom/text-node-attach-crash.xhtml
- xml/parser/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::exitText): LayoutTests:
- fast/dom/text-node-attach-crash-expected.txt: Added.
- fast/dom/text-node-attach-crash.xhtml: Added.
| # |
| 1 min ago | WebKit | Commit by kov@webkit.org :: r117278 /releases/WebKitGTK/webkit-1.8/ (5 files in 5 dirs): Merge 112184 - FrameLoader::shouldAllowNavigation uses Frame for context rather than Document https://bugs.webkit.org/show_bug.cgi?id=81020
Reviewed by Eric Seidel.
Source/WebCore:
The vast majority of security checks in the browser should use a ScriptExecutionContext (aka a Document) to designate "who" is attempting to perform a given action. Unfortunately, shouldAllowNavigation was using a Frame to designate "who" is attempting the navigation.
In cases when the executing script is "inactive" (i.e., belongs to a document that is not currently displayed in a Frame), using the Frame can cause us to grant the script the privileges of the document that's currently displayed in the Frame rather than the one that contains the script.
This patch moves shouldAllowNavigation from FrameLoader to Document (and renames it to canNavigate), effectively change the context object from a Frame to a Document.
Test: http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html
- bindings/generic/BindingSecurity.h: (BindingSecurity): (WebCore):
- bindings/v8/V8Utilities.cpp: (WebCore):
- bindings/v8/V8Utilities.h: (WebCore): - Deletes unused code.
- dom/Document.cpp: (WebCore::canAccessAncestor): (WebCore): (WebCore::Document::canNavigate): - canNavigate is copied from FrameLoader::shouldAllowNavigation. I've added a null-check bailout if the document is inactive.
- dom/Document.h: (Document):
- loader/FormState.cpp: (WebCore::FormState::FormState): (WebCore::FormState::create):
- loader/FormState.h: (WebCore): (FormState): (WebCore::FormState::sourceDocument):
- loader/FormSubmission.cpp: (WebCore::FormSubmission::create): - Changes the context object from Frame to Document.
- loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm): (WebCore::FrameLoader::loadFrameRequest): (WebCore): (WebCore::FrameLoader::findFrameForNavigation): - FrameLoader::findFrameForNavigation still incorrectly uses Frame as the context object, but that's a bug for another patch. (WebCore::createWindow):
- loader/FrameLoader.h: (FrameLoader):
- loader/NavigationScheduler.cpp: (WebCore::ScheduledFormSubmission::fire):
- page/DOMWindow.cpp: (WebCore::DOMWindow::close): (WebCore::DOMWindow::setLocation): (WebCore::DOMWindow::open):
- page/History.cpp: (WebCore::History::go): Source/WebKit/mac: Update call site to new function name.
- WebCoreSupport/WebFrameLoaderClient.mm: (WebFrameLoaderClient::dispatchWillSubmitForm): Source/WebKit/win: Update call site to new function name.
- WebFrame.cpp: (WebFrame::dispatchWillSubmitForm): Source/WebKit2: Update call site to new function name.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): LayoutTests: Test that a script from an inactive document doesn't inherit the navigation privileges of the document that currently occupies the frame.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child-expected.txt: Added.
- http/tests/security/frameNavigation/inactive-function-in-popup-navigate-child.html: Added.
- http/tests/security/frameNavigation/resources/fail.html: Added.
- http/tests/security/frameNavigation/resources/iframe-with-inner-frame-on-foreign-domain.html:
- http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html: Added.
| # |
| 1 min ago | WebKit | Commit by pfeldman@chromium.org :: r117277 /trunk/ (23 files in 7 dirs): Web Inspector: split ScriptMapping into UISourceCodeProvider and SourceMapping. https://bugs.webkit.org/show_bug.cgi?id=86616
Reviewed by Vsevolod Vlasov.
Source/WebCore:
This change simply splits the interface.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CompilerScriptMapping.js: (WebInspector.CompilerScriptMapping.prototype.get uiSourceCodes): (WebInspector.CompilerScriptMapping.prototype.reset):
- inspector/front-end/DebuggerModel.js:
- inspector/front-end/DebuggerResourceBinding.js: (WebInspector.DebuggerResourceBinding): (WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
- inspector/front-end/DebuggerScriptMapping.js: (WebInspector.DebuggerScriptMapping): (WebInspector.DebuggerScriptMapping.prototype.uiSourceCodes): (WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded): (WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced): (WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
- inspector/front-end/FilteredItemSelectionDialog.js: (WebInspector.OpenScriptDialog): (WebInspector.OpenScriptDialog.install): (WebInspector.OpenScriptDialog._show):
- inspector/front-end/PresentationConsoleMessageHelper.js: (WebInspector.PresentationConsoleMessageHelper): (WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
- inspector/front-end/ResourceScriptMapping.js: (WebInspector.ResourceScriptMapping.prototype.uiSourceCodes): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
- inspector/front-end/Script.js:
- inspector/front-end/ScriptSnippetModel.js: (WebInspector.ScriptSnippetModel.prototype._uiSourceCodes): (WebInspector.SnippetScriptMapping.prototype.uiSourceCodes): (WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded): (WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
- inspector/front-end/ScriptsPanel.js:
- inspector/front-end/ScriptsSearchScope.js: (WebInspector.ScriptsSearchScope): (WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
- inspector/front-end/SourceMapping.js: Renamed from Source/WebCore/inspector/front-end/ScriptMapping.js.
- inspector/front-end/UISourceCode.js: (WebInspector.UISourceCodeProvider): (WebInspector.UISourceCodeProvider.prototype.uiSourceCodes): (WebInspector.UILocation): (WebInspector.UILocation.prototype.uiLocationToRawLocation):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html: LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- inspector/debugger/scripts-panel.html:
| # |
| 9 min ago | WebKit | Commit by commit-queue@webkit.org :: r117276 /trunk/ (14 files in 10 dirs): Add didFinishProgress BundleUIClient callback https://bugs.webkit.org/show_bug.cgi?id=86541
Patch by Dinu Jacob <dinu dot jacob at nokia dot com> on 2012-05-16 Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
Added didFinishProgress BundleUIClient callback needed by WebKitTestRunner. This callback is invoked in postProgressFinishedNotification.
- WebProcess/InjectedBundle/API/c/WKBundlePage.h:
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp: (WebKit::InjectedBundlePageLoaderClient::didFinishProgress): (WebKit):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h: (InjectedBundlePageLoaderClient):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
- WebProcess/qt/QtBuiltinBundlePage.cpp: (WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage): Tools: Added support for dumpProgressFinishedCallback.
- WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage): (WTR::InjectedBundlePage::didFinishProgress): (WTR):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: (InjectedBundlePage):
- WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: (WTR::LayoutTestController::LayoutTestController):
- WebKitTestRunner/InjectedBundle/LayoutTestController.h: (WTR::LayoutTestController::dumpProgressFinishedCallback): (WTR::LayoutTestController::setShouldDumpProgressFinishedCallback): (WTR::LayoutTestController::shouldDumpProgressFinishedCallback): (LayoutTestController): LayoutTests: Unskip passing test.
- platform/qt-5.0-wk2/Skipped:
| # |
| 12 min ago | WebKit | Commit by kkristof@inf.u-szeged.hu :: r117275 LayoutTests/ (ChangeLog platform/qt/Skipped): | # |
| 15 min ago | WebKit | Commit by vsevik@chromium.org :: r117274 Source/WebCore/ (8 files in 2 dirs): Web Inspector: Implement snippet creation/renaming in ScriptsNavigator. https://bugs.webkit.org/show_bug.cgi?id=82622
Reviewed by Pavel Feldman.
Implemented snippet creation and renaming. Added TitleChanged event to UISourceCode.
- inspector/front-end/NavigatorOverlayController.js: (WebInspector.NavigatorOverlayController.prototype._containingElementFocused): (WebInspector.NavigatorOverlayController.prototype.isNavigatorPinned): (WebInspector.NavigatorOverlayController.prototype.isNavigatorHidden):
- inspector/front-end/NavigatorView.js: (WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged): (WebInspector.NavigatorView.prototype._updateScriptTitle): (WebInspector.NavigatorView.prototype._addUISourceCodeListeners): (WebInspector.NavigatorView.prototype._removeUISourceCodeListeners): (WebInspector.NavigatorView.prototype._fileRenamed): (WebInspector.NavigatorScriptTreeElement.prototype.onattach):
- inspector/front-end/ScriptSnippetModel.js: (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
- inspector/front-end/ScriptsNavigator.js: (WebInspector.ScriptsNavigator): (WebInspector.ScriptsNavigator.prototype._snippetsNavigatorViewForUISourceCode): (WebInspector.ScriptsNavigator.prototype.addUISourceCode): (WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded): (WebInspector.ScriptsNavigator.prototype.revealUISourceCode): (WebInspector.ScriptsNavigator.prototype.replaceUISourceCode): (WebInspector.ScriptsNavigator.prototype.rename): (WebInspector.ScriptsNavigator.prototype._fileRenamed): (WebInspector.ScriptsNavigator.prototype._snippetCreationRequested): (WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet): (WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar): (WebInspector.ScriptsPanel.prototype.set _fileRenamed): (WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback): (WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
- inspector/front-end/TabbedEditorContainer.js: (WebInspector.TabbedEditorContainer.prototype._appendFileTab): (WebInspector.TabbedEditorContainer.prototype._tabClosed): (WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
- inspector/front-end/UISourceCode.js: (WebInspector.UISourceCode.prototype.urlChanged):
| # |
| 30 min ago | WebKit | Commit by apavlov@chromium.org :: r117273 Source/WebCore/ (3 files in 2 dirs): Web Inspector: gradient properties are painful to inspect / author. https://bugs.webkit.org/show_bug.cgi?id=86379
Reviewed by Pavel Feldman.
The CSS styles layout has been changed to allow property values to wrap onto subsequent lines to let the users see the entire value text.
- inspector/front-end/StylesSidebarPane.js: (WebInspector.StylePropertyTreeElement.prototype.updateTitle.): Avoid line breaks between the color swatch and value.
- inspector/front-end/elementsPanel.css: (.styles-section .properties li.not-parsed-ok img.exclamation-mark): (.styles-section .properties li): (.styles-section .properties li .webkit-css-property): (.styles-section.expanded .properties > li): (.styles-section .properties > li .webkit-css-property): (.styles-section .properties > li.child-editing): (.styles-section .properties > li.child-editing .webkit-css-property): (.styles-section .properties .enabled-button):
| # |
| 39 min ago | WebKit | Commit by yurys@chromium.org :: r117272 Source/WebCore/ (9 files in 4 dirs): Web Inspector: rename ProfileView.js to CPUProfileView.js https://bugs.webkit.org/show_bug.cgi?id=86612
Reviewed by Pavel Feldman.
Renamed ProfileView.js to CPUProfileView.js to match the file content.
- WebCore.gypi:
- WebCore.vcproj/WebCore.vcproj:
- inspector/compile-front-end.py:
- inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js. (WebInspector.CPUProfileView.profileCallback): (WebInspector.CPUProfileView.prototype.get statusBarItems): (WebInspector.CPUProfileView.prototype.get profile): (WebInspector.CPUProfileView.prototype.set profile): (WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree): (WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree): (WebInspector.CPUProfileView.prototype.get currentTree): (WebInspector.CPUProfileView.prototype.set currentTree): (WebInspector.CPUProfileView.prototype.willHide): (WebInspector.CPUProfileView.prototype.refresh): (WebInspector.CPUProfileView.prototype.refreshVisibleData): (WebInspector.CPUProfileView.prototype.refreshShowAsPercents): (WebInspector.CPUProfileView.prototype.searchCanceled): (WebInspector.CPUProfileView.prototype.performSearch.matchesQuery): (WebInspector.CPUProfileView.prototype.performSearch): (WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult): (WebInspector.CPUProfileView.prototype.jumpToLastSearchResult): (WebInspector.CPUProfileView.prototype.jumpToNextSearchResult): (WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult): (WebInspector.CPUProfileView.prototype.showingFirstSearchResult): (WebInspector.CPUProfileView.prototype.showingLastSearchResult): (WebInspector.CPUProfileView.prototype._jumpToSearchResult): (WebInspector.CPUProfileView.prototype._changeView.set else): (WebInspector.CPUProfileView.prototype._focusClicked): (WebInspector.CPUProfileView.prototype._excludeClicked): (WebInspector.CPUProfileView.prototype._resetClicked): (WebInspector.CPUProfileView.prototype._dataGridNodeSelected): (WebInspector.CPUProfileView.prototype._dataGridNodeDeselected): (WebInspector.CPUProfileView.prototype._sortProfile): (WebInspector.CPUProfileView.prototype._assignParentsInProfile): (WebInspector.CPUProfileType): (WebInspector.CPUProfileType.prototype.get buttonTooltip): (WebInspector.CPUProfileType.prototype.buttonClicked): (WebInspector.CPUProfileType.prototype.get treeItemTitle): (WebInspector.CPUProfileType.prototype.get description): (WebInspector.CPUProfileType.prototype.isRecordingProfile): (WebInspector.CPUProfileType.prototype.startRecordingProfile): (WebInspector.CPUProfileType.prototype.stopRecordingProfile): (WebInspector.CPUProfileType.prototype.setRecordingProfile): (WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile): (WebInspector.CPUProfileType.prototype.createView): (WebInspector.CPUProfileType.prototype.createTemporaryProfile): (WebInspector.CPUProfileType.prototype.createProfile):
- inspector/front-end/HeapSnapshotView.js: (WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.html:
| # |
| 17:12 today | WebKit | Commit by commit-queue@webkit.org :: r117271 /trunk/ (5 files in 4 dirs): "border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border https://bugs.webkit.org/show_bug.cgi?id=67877
Patch by Arpita Bahuguna <arpitabahuguna at gmail dot com> on 2012-05-16 Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/table-collapsed-borders.html
- rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::computeCollapsedBeforeBorder): When getting the previous row group's after border, pass SkipEmptySections as the second param to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the table passing SkipEmptySections to sectionAbove() would return null which should be the expected behavior. (WebCore::RenderTableCell::computeCollapsedAfterBorder): When getting the following row group's before border, pass SkipEmptySections as the second param to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the table passing SkipEmptySections to sectionBelow() would return null which should be the expected behavior. LayoutTests:
- fast/css/table-collapsed-borders-expected.html: Added.
- fast/css/table-collapsed-borders.html: Added. Added new reftest for testing table with collapsed borders.
| # |
| 17:08 today | WebKit | Commit by pfeldman@chromium.org :: r117270 Source/WebCore/ (2 files in 2 dirs): Web Inspector: follow up to r117267 - fixing typo and removing unnecessary dispatch. https://bugs.webkit.org/show_bug.cgi?id=86613
Reviewed by Vsevolod Vlasov.
- inspector/front-end/ResourceScriptMapping.js: (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
| # |
| 16:55 today | WebKit | Commit by commit-queue@webkit.org :: r117268 LayoutTests/ (2 files in 2 dirs): | # |
| 16:41 today | WebKit | Commit by pfeldman@chromium.org :: r117267 /trunk/ (14 files in 5 dirs): Web Inspector: get rid of UISourceCodeListChanged event. https://bugs.webkit.org/show_bug.cgi?id=86601
Reviewed by Vsevolod Vlasov.
Source/WebCore:
There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.
- inspector/front-end/CompilerScriptMapping.js: (WebInspector.CompilerScriptMapping.prototype.reset):
- inspector/front-end/DebuggerScriptMapping.js: (WebInspector.DebuggerScriptMapping): (WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded): (WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced): (WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
- inspector/front-end/NavigatorView.js:
- inspector/front-end/ResourceScriptMapping.js: (WebInspector.ResourceScriptMapping.prototype.addScript): (WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced): (WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved): (WebInspector.ResourceScriptMapping.prototype.reset):
- inspector/front-end/ScriptMapping.js:
- inspector/front-end/ScriptSnippetModel.js: (WebInspector.ScriptSnippetModel.prototype._addScriptSnippet): (WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript): (WebInspector.ScriptSnippetModel.prototype._reset): (WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded): (WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
- inspector/front-end/ScriptsNavigator.js: (WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
- inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
- inspector/front-end/TabbedEditorContainer.js: LayoutTests:
- http/tests/inspector/compiler-script-mapping.html:
- inspector/debugger/scripts-panel.html:
| # |
| 16:26 today | WebKit | Commit by yurys@chromium.org :: r117266 LayoutTests/ (2 files in 2 dirs): [chromium] Layout tests under inspector/profiler are failing on chromium win https://bugs.webkit.org/show_bug.cgi?id=86495
Unreviewed. Remove custom expectations for heap profiler tests. They should pass after r117241.
- platform/chromium/test_expectations.txt:
| # |
| 16:19 today | WebKit | Commit by commit-queue@webkit.org :: r117265 LayoutTests/ (2 files in 2 dirs): | # |
| 16:17 today | WebKit | Commit by commit-queue@webkit.org :: r117264 LayoutTests/ (ChangeLog platform/efl/Skipped): | # |
| 16:14 today | WebKit | Commit by keishi@webkit.org :: r117263 /trunk/ (18 files in 12 dirs): [chromium] Add WebKit API to access inner text value of input element https://bugs.webkit.org/show_bug.cgi?id=85353
Reviewed by Kent Tamura.
.:
- Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue Source/WebCore: Test: fast/forms/editing-value.html We need this to implement the datalist UI for <input type=email multiple>. HTMLInputElement.value gives you the sanitized value so the whitespace between values are trimmed. We need to append the selected suggestion to the end without modifying the rest of the text.
- WebCore.exp.in: Added HTMLInputElement::setEditingValue
- html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setEditingValue): (WebCore):
- html/HTMLInputElement.h: (HTMLInputElement):
- testing/Internals.cpp: (WebCore::Internals::setEditingValue): (WebCore):
- testing/Internals.h: (Internals):
- testing/Internals.idl: Source/WebKit/chromium:
- public/WebInputElement.h: (WebInputElement):
- src/WebInputElement.cpp: (WebKit::WebInputElement::editingValue): (WebKit): (WebKit::WebInputElement::setEditingValue): Source/WebKit2:
- win/WebKit2.def: Added HTMLInputElement::setEditingValue
- win/WebKit2CFLite.def: Added HTMLInputElement::setEditingValue LayoutTests:
- fast/forms/editing-value-expected.txt: Added.
- fast/forms/editing-value.html: Added. Tests that setting the editing value takes care of the style and placeholder, and that it fires an input event.
| # |
| 16:06 today | WebKit | Commit by kkristof@inf.u-szeged.hu :: r117262 LayoutTests/ (ChangeLog platform/qt/Skipped): | # |
| 16:02 today | WebKit | Commit by commit-queue@webkit.org :: r117261 Source/WebCore/ (4 files in 2 dirs): [BlackBerry] Cookies should be checked during parsing to improve performance. https://bugs.webkit.org/show_bug.cgi?id=85028
Patch by Jason Liu <jason dot liu at torchmobile dot com dot cn> on 2012-05-16 Reviewed by George Staikos.
We shouldn't waste time and memery on invalid cookies. It is better to drop them during parsing. We shouldn't check the default domain since it is set with host. So we only check domains which are parsed from response headers.
No new tests. No functionality change.
- platform/blackberry/CookieManager.cpp: (WebCore::CookieManager::setCookies):
- platform/blackberry/CookieManager.h:
- platform/blackberry/CookieParser.cpp: (WebCore::CookieParser::parseOneCookie):
| # |
| 15:55 today | WebKit | Commit by pierre.rossi@gmail.com :: r117260 LayoutTests/ (111 files in 6 dirs): | # |