http://cia.vc/stats/project/webkit101973279929157936289916NoneWebKit is the system framework used on Mac OS X by Safari, Dashboard, Mail.app, and many other OS X applications. It is based on the KHTML engine from KDE.NoneWebKithttp://webkit.orgNonePython Subversion client for CIA1.18WebKitSource118627commit-queue@webkit.org[BlackBerry] Crash when deleting WebPageCompositor https://bugs.webkit.org/show_bug.cgi?id=87589 Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-27 Reviewed by Rob Buis. The WebPageCompositorPrivate is reference counted, so it may outlive either the WebPage or the WebPageCompositor, depending on who releases its reference first. Fixed by disconnecting the objects properly, regardless of who goes away first. Reviewed internally by Mike Lattanzio. PR #156444 * Api/WebPage.cpp: (BlackBerry::WebKit::WebPagePrivate::setCompositor): (BlackBerry::WebKit::WebPagePrivate::destroyCompositor): * Api/WebPageCompositor.cpp: (BlackBerry::WebKit::WebPageCompositor::~WebPageCompositor): (BlackBerry::WebKit::WebPageCompositor::client): * Api/WebPageCompositor_p.h: (BlackBerry::WebKit::WebPageCompositorPrivate::setPage): 100WebKit/blackberry/Api/WebPage.cppWebKit/blackberry/Api/WebPageCompositor.cppWebKit/blackberry/Api/WebPageCompositor_p.hWebKit/blackberry/ChangeLog1338146485Python Subversion client for CIA1.18WebKitSource118626commit-queue@webkit.org[BlackBerry] BackingStore accesses tiles even though it's not active https://bugs.webkit.org/show_bug.cgi?id=87563 Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-18 Reviewed by Antonio Gomes. There are many scenarios that can call render and cause tile access, and they used to be rerouted to the direct rendering code when the backing store was not active. This was thanks to an implicit check for isActive() by virtue of calling shouldDirectRenderingToWindow() from render(). If we're using OpenGL for compositing the backing store contents however, direct rendering is always disabled and we jump right into the tile based rendering code. Fixed by adding an explicit check for isActive() in render(), now that the implicit check in shouldDirectRenderingToWindow() is conditional on having raster usage. Since PR136381/bug83131, when OpenGL compositing is used, and the backing store is not active, it is not in charge of drawing the root layer. Instead, we switch off the paintingGoesToWindow flag on the root RenderLayer so no invalidates will reach the ChromeClient or the BackingStore any more. Instead, invalidations will cause the root accelerated compositing layer to be repainted. Any BackingStore render calls while in this state are pointless, and can safely do an early return. Reviewed internally by Jakob Petsovits. PR #150403 * Api/BackingStore.cpp: (BlackBerry::WebKit::BackingStorePrivate::render): 69WebKit/blackberry/Api/BackingStore.cppWebKit/blackberry/ChangeLog1338145695Python Subversion client for CIA1.18WebKitSource118625commit-queue@webkit.org[BlackBerry] Web page fails to render after clicking link with target=_blank https://bugs.webkit.org/show_bug.cgi?id=87562 Patch by Arvid Nilsson <anilsson@rim.com> on 2012-04-12 Reviewed by Antonio Gomes. Clicking such a link opens a new tab. The compositor was briefly in charge of drawing the root layer while the backing store was inactive and the user was looking at the other tab. The problem was that the compositor believed it was still painting the root layer even after the backing store became active again. The flag was not properly cleared when turning off compositing. Fixed by returning false from drawsRootLayer() if we don't have a root layer. Reviewed internally by Filip Spacek. PR #149342 * Api/WebPageCompositor.cpp: (BlackBerry::WebKit::WebPageCompositorPrivate::drawsRootLayer): 50WebKit/blackberry/Api/WebPageCompositor.cppWebKit/blackberry/ChangeLog1338144273Python Subversion client for CIA1.18WebKitSource118624ddkilzer@apple.comUse xcrun to find gperf path on platforms that use Xcode <http://webkit.org/b/87587> Reviewed by Dan Bernstein. * WebCore.xcodeproj/project.pbxproj: (Generate Derived Sources): Set GPERF environment variable using xcrun. * css/makeprop.pl: Use GPERF environment variable if set, else "gperf". * css/makevalues.pl: Ditto. * make-hash-tools.pl: Ditto. 111WebCore/ChangeLogWebCore/WebCore.xcodeproj/project.pbxprojWebCore/css/makeprop.plWebCore/css/makevalues.plWebCore/make-hash-tools.pl1338134533Python Subversion client for CIA1.18WebKitTools118623dbarton@mathscribe.com[watchlist] Add myself & a rule for MathML https://bugs.webkit.org/show_bug.cgi?id=87586 Reviewed by Adam Barth. * Scripts/webkitpy/common/config/watchlist: 42ChangeLogScripts/webkitpy/common/config/watchlist1338120424Python Subversion client for CIA1.18WebKit118622commit-queue@webkit.org[FileAPI] FileReader should fire progress event when blob has been completely read into memory https://bugs.webkit.org/show_bug.cgi?id=87585 Patch by Li Yin <li.yin@intel.com> on 2012-05-27 Reviewed by Kentaro Hara. From Spec: http://www.w3.org/TR/FileAPI/#dfn-progress-event One progress event will fire when blob has been completely read into memory. Firefox, Opera and IE follows the spec. Webkit based browser doesn't do that, it only fires progress event at interval of 50ms. WebKit should add the behavior to make the conformance with the spec. Source/WebCore: Tests: fast/files/file-reader-event-listener.html * fileapi/FileReader.cpp: (WebCore::FileReader::didFinishLoading): LayoutTests: * fast/files/file-reader-event-listener-expected.txt: * fast/files/file-reader-event-listener.html: 116trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/files/file-reader-event-listener-expected.txttrunk/LayoutTests/fast/files/file-reader-event-listener.htmltrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/fileapi/FileReader.cpp1338120025Python Subversion client for CIA1.18WebKitTools118621ddkilzer@apple.comUse xcrun to find path to nm for Mac port <http://webkit.org/b/87588> Reviewed by Dan Bernstein. * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.nm_command): Add. Tries to find a path for the nm command using xcrun. Falls back to returning 'nm'. * Scripts/webkitpy/layout_tests/port/webkit.py: (WebKitPort.nm_command): Add. Returns 'nm'. (WebKitPort._webcore_symbols_string): Call self.nm_command(). 77ChangeLogScripts/webkitpy/layout_tests/port/mac.pyScripts/webkitpy/layout_tests/port/webkit.py1338117512Python Subversion client for CIA1.18WebKit118620commit-queue@webkit.org[FileAPI] The result attribute of FileReader shuold use null to replace empty string https://bugs.webkit.org/show_bug.cgi?id=87578 Patch by Li Yin <li.yin@intel.com> on 2012-05-26 Reviewed by Kentaro Hara. Source/WebCore: From Spec: http://www.w3.org/TR/FileAPI/#filedata-attr Before read method has been called or an error in reading has occurred, the result attribute should be null, not empty string. Currently, Firefox, Opera and IE 10 follows the spec, but Webkit based browser don't. WebKit should change the returned value empty string into null to keep conformance with the spec. Tests: fast/files/read-file-async.html fast/files/blob-slice-test.html fast/files/read-blob-async.html fast/files/workers/worker-read-blob-async.html fast/files/workers/worker-read-file-async.html * fileapi/FileReader.cpp: (WebCore::FileReader::stringResult): LayoutTests: From Spec: http://www.w3.org/TR/FileAPI/#filedata-attr Before read method has been called or an error in reading has occurred, the result attribute should be null, not empty string. WebKit should change the returned value empty string into null to keep conformance with the spec. * fast/files/blob-slice-test-expected.txt: * fast/files/read-blob-async-expected.txt: * fast/files/read-file-async-expected.txt: * fast/files/resources/read-common.js: (logResult): * fast/files/workers/worker-read-blob-async-expected.txt: * fast/files/workers/worker-read-file-async-expected.txt: 305trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/files/blob-slice-test-expected.txttrunk/LayoutTests/fast/files/read-blob-async-expected.txttrunk/LayoutTests/fast/files/read-file-async-expected.txttrunk/LayoutTests/fast/files/resources/read-common.jstrunk/LayoutTests/fast/files/workers/worker-read-blob-async-expected.txttrunk/LayoutTests/fast/files/workers/worker-read-file-async-expected.txttrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/fileapi/FileReader.cpp1338099442Python Subversion client for CIA1.18WebKitSource118619aestes@apple.comFix the build when NETSCAPE_PLUGIN_API is disabled by marking a parameter as unused. * plugins/PluginData.cpp: (WebCore::PluginData::initPlugins): 32WebCore/ChangeLogWebCore/plugins/PluginData.cpp1338097362Python Subversion client for CIA1.18WebKit118618japhet@chromium.orgSource/WebCore: Cancel CachedResource loads when the last client is removed. https://bugs.webkit.org/show_bug.cgi?id=35377 Reviewed by Darin Adler. Test: http/tests/cache/cancel-in-progress-load.html * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::errorLoadingResource): * loader/cache/CachedCSSStyleSheet.cpp: (WebCore::CachedCSSStyleSheet::allClientsRemoved): * loader/cache/CachedFont.cpp: (WebCore::CachedFont::allClientsRemoved): * loader/cache/CachedImage.cpp: (WebCore::CachedImage::allClientsRemoved): * loader/cache/CachedRawResource.cpp: (WebCore): * loader/cache/CachedRawResource.h: (WebCore::CachedRawResource::shouldIgnoreHTTPStatusCodeErrors): * loader/cache/CachedResource.cpp: (WebCore::CachedResource::allClientsRemoved): (WebCore): * loader/cache/CachedResource.h: (CachedResource): * loader/cache/CachedScript.cpp: (WebCore::CachedScript::allClientsRemoved): LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=35377. Reviewed by Darin Adler. * http/tests/cache/cancel-in-progress-load-expected.txt: Added. * http/tests/cache/cancel-in-progress-load.html: Added. * http/tests/misc/write-while-waiting.html: Add waitUntilDone()/notifyDone(). The slow script will now be cancelled when the script element is removed from the document. Without waitUntilDone(), LayoutTestController will immediately end the test upon cancellation of the last resource. 248trunk/LayoutTests/ChangeLogtrunk/LayoutTests/http/tests/cache/cancel-in-progress-load-expected.txttrunk/LayoutTests/http/tests/cache/cancel-in-progress-load.htmltrunk/LayoutTests/http/tests/misc/write-while-waiting.htmltrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/loader/SubresourceLoader.cpptrunk/Source/WebCore/loader/cache/CachedCSSStyleSheet.cpptrunk/Source/WebCore/loader/cache/CachedFont.cpptrunk/Source/WebCore/loader/cache/CachedImage.cpptrunk/Source/WebCore/loader/cache/CachedRawResource.cpptrunk/Source/WebCore/loader/cache/CachedRawResource.htrunk/Source/WebCore/loader/cache/CachedResource.cpptrunk/Source/WebCore/loader/cache/CachedResource.htrunk/Source/WebCore/loader/cache/CachedScript.cpp1338095544Python Subversion client for CIA1.18WebKit118617simon.fraser@apple.comfast/block/inline-children-root-linebox-crash.html asserts after r118567 https://bugs.webkit.org/show_bug.cgi?id=87544 Source/WebCore: Reviewed by Darin Adler. RenderInline::offsetFromContainer() set offsetDependsOnPoint to true based on the container's flipped writing mode. However, offsetFromContainer() would then overwrite that, since it only checked for columns. Fix by having RenderInline::offsetFromContainer() check for flipping on the container. This fixes the assertion. The new testcase exercises fixes another issue; unlike mapLocalToAbsolute(), RenderGeometryMap::absoluteRect() didn't pass the rect center point through the mapping, which resulted in a different result in some flipping cases. Test: compositing/geometry/flipped-blocks-inline-mapping.html * rendering/RenderGeometryMap.cpp: (WebCore::RenderGeometryMap::absoluteRect): * rendering/RenderInline.cpp: (WebCore::RenderInline::offsetFromContainer): (WebCore::RenderInline::pushMappingToContainer): LayoutTests: Reviewed by Darin Adler. Remove fast/block/inline-children-root-linebox-crash.html from the skipped list. New, more complex writing mode flipping test with compositing. * compositing/geometry/flipped-blocks-inline-mapping-expected.txt: Added. * compositing/geometry/flipped-blocks-inline-mapping.html: Added. * platform/mac/Skipped: 168trunk/LayoutTests/ChangeLogtrunk/LayoutTests/compositing/geometry/flipped-blocks-inline-mapping-expected.txttrunk/LayoutTests/compositing/geometry/flipped-blocks-inline-mapping.htmltrunk/LayoutTests/platform/mac/Skippedtrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/rendering/RenderGeometryMap.cpptrunk/Source/WebCore/rendering/RenderInline.cpp1338095371Python Subversion client for CIA1.18WebKitSource118616ggaren@apple.comWebKit should be lazy-finalization-safe (esp. the DOM) v2 https://bugs.webkit.org/show_bug.cgi?id=87581 Reviewed by Oliver Hunt. ../JavaScriptCore: * heap/MarkedBlock.cpp: (JSC::MarkedBlock::callDestructor): * heap/WeakBlock.h: * heap/WeakSetInlines.h: (JSC::WeakBlock::finalize): Since we don't guarantee destruction order, it's not valid to access GC pointers like the Structure pointer during finalization. We NULL out the structure pointer in debug builds to try to make this programming mistake more obvious. * API/JSCallbackConstructor.cpp: (JSC::JSCallbackConstructor::destroy): * API/JSCallbackObject.cpp: (JSC::::destroy): (JSC::JSCallbackObjectData::finalize): * runtime/Arguments.cpp: (JSC::Arguments::destroy): * runtime/DateInstance.cpp: (JSC::DateInstance::destroy): * runtime/Error.cpp: (JSC::StrictModeTypeErrorFunction::destroy): * runtime/Executable.cpp: (JSC::ExecutableBase::destroy): (JSC::NativeExecutable::destroy): (JSC::ScriptExecutable::destroy): (JSC::EvalExecutable::destroy): (JSC::ProgramExecutable::destroy): (JSC::FunctionExecutable::destroy): * runtime/JSGlobalObject.cpp: (JSC::JSGlobalObject::destroy): * runtime/JSPropertyNameIterator.cpp: (JSC::JSPropertyNameIterator::destroy): * runtime/JSStaticScopeObject.cpp: (JSC::JSStaticScopeObject::destroy): * runtime/JSString.cpp: (JSC::JSString::destroy): * runtime/JSVariableObject.cpp: (JSC::JSVariableObject::destroy): * runtime/NameInstance.cpp: (JSC::NameInstance::destroy): * runtime/RegExp.cpp: (JSC::RegExp::destroy): * runtime/RegExpConstructor.cpp: (JSC::RegExpConstructor::destroy): * runtime/Structure.cpp: (JSC::Structure::destroy): * runtime/StructureChain.cpp: (JSC::StructureChain::destroy): Use static_cast instead of jsCast because jsCast does Structure-based validation, and our Structure is not guaranteed to be alive when we get finalized. ../WebCore: * bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::destroy): * bindings/js/JSDOMWindowBase.cpp: (WebCore::JSDOMWindowBase::destroy): * bindings/js/JSDOMWindowShell.cpp: (WebCore::JSDOMWindowShell::destroy): * bindings/js/JSNodeCustom.cpp: (WebCore::JSNodeOwner::finalize): * bindings/js/JSWorkerContextBase.cpp: (WebCore::JSWorkerContextBase::destroy): * bindings/scripts/CodeGeneratorJS.pm: (GenerateImplementation): * bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: (WebCore::JSTestActiveDOMObject::destroy): (WebCore::JSTestActiveDOMObjectOwner::finalize): * bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: (WebCore::JSTestCustomNamedGetter::destroy): (WebCore::JSTestCustomNamedGetterOwner::finalize): * bindings/scripts/test/JS/JSTestEventConstructor.cpp: (WebCore::JSTestEventConstructor::destroy): (WebCore::JSTestEventConstructorOwner::finalize): * bindings/scripts/test/JS/JSTestEventTarget.cpp: (WebCore::JSTestEventTarget::destroy): (WebCore::JSTestEventTargetOwner::finalize): * bindings/scripts/test/JS/JSTestException.cpp: (WebCore::JSTestException::destroy): (WebCore::JSTestExceptionOwner::finalize): * bindings/scripts/test/JS/JSTestInterface.cpp: (WebCore::JSTestInterface::destroy): (WebCore::JSTestInterfaceOwner::finalize): * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: (WebCore::JSTestMediaQueryListListener::destroy): (WebCore::JSTestMediaQueryListListenerOwner::finalize): * bindings/scripts/test/JS/JSTestNamedConstructor.cpp: (WebCore::JSTestNamedConstructor::destroy): (WebCore::JSTestNamedConstructorOwner::finalize): * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::JSTestObj::destroy): (WebCore::JSTestObjOwner::finalize): * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp: (WebCore::JSTestSerializedScriptValueInterface::destroy): (WebCore::JSTestSerializedScriptValueInterfaceOwner::finalize): * bridge/objc/objc_runtime.mm: (JSC::Bindings::ObjcFallbackObjectImp::destroy): * bridge/qt/qt_runtime.cpp: (JSC::Bindings::QtRuntimeMethod::destroy): * bridge/qt/qt_runtime_qt4.cpp: (JSC::Bindings::QtRuntimeMethod::destroy): * bridge/runtime_array.cpp: (JSC::RuntimeArray::destroy): * bridge/runtime_method.cpp: (JSC::RuntimeMethod::destroy): * bridge/runtime_object.cpp: (JSC::Bindings::RuntimeObject::destroy): * bridge/runtime_root.cpp: (JSC::Bindings::RootObject::finalize): Use static_cast instead of jsCast because jsCast does Structure-based validation, and our Structure is not guaranteed to be alive when we get finalized. ../WebKit2: * WebProcess/Plugins/Netscape/JSNPObject.cpp: (WebKit::JSNPObject::destroy): (WebKit::JSNPObject::leakNPObject): * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: (WebKit::NPRuntimeObjectMap::finalize): Use static_cast instead of jsCast because jsCast does Structure-based validation, and our Structure is not guaranteed to be alive when we get finalized. 956JavaScriptCore/API/JSCallbackConstructor.cppJavaScriptCore/API/JSCallbackObject.cppJavaScriptCore/ChangeLogJavaScriptCore/heap/MarkedBlock.cppJavaScriptCore/heap/WeakBlock.hJavaScriptCore/heap/WeakSetInlines.hJavaScriptCore/runtime/Arguments.cppJavaScriptCore/runtime/DateInstance.cppJavaScriptCore/runtime/Error.cppJavaScriptCore/runtime/Executable.cppJavaScriptCore/runtime/JSGlobalObject.cppJavaScriptCore/runtime/JSPropertyNameIterator.cppJavaScriptCore/runtime/JSStaticScopeObject.cppJavaScriptCore/runtime/JSString.cppJavaScriptCore/runtime/JSVariableObject.cppJavaScriptCore/runtime/NameInstance.cppJavaScriptCore/runtime/RegExp.cppJavaScriptCore/runtime/RegExpConstructor.cppJavaScriptCore/runtime/Structure.cppJavaScriptCore/runtime/StructureChain.cppWebCore/ChangeLogWebCore/bindings/js/JSDOMGlobalObject.cppWebCore/bindings/js/JSDOMWindowBase.cppWebCore/bindings/js/JSDOMWindowShell.cppWebCore/bindings/js/JSNodeCustom.cppWebCore/bindings/js/JSWorkerContextBase.cppWebCore/bindings/scripts/CodeGeneratorJS.pmWebCore/bindings/scripts/test/JS/JSTestActiveDOMObject.cppWebCore/bindings/scripts/test/JS/JSTestCustomNamedGetter.cppWebCore/bindings/scripts/test/JS/JSTestEventConstructor.cppWebCore/bindings/scripts/test/JS/JSTestEventTarget.cppWebCore/bindings/scripts/test/JS/JSTestException.cppWebCore/bindings/scripts/test/JS/JSTestInterface.cppWebCore/bindings/scripts/test/JS/JSTestMediaQueryListListener.cppWebCore/bindings/scripts/test/JS/JSTestNamedConstructor.cppWebCore/bindings/scripts/test/JS/JSTestObj.cppWebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cppWebCore/bridge/objc/objc_runtime.mmWebCore/bridge/qt/qt_runtime.cppWebCore/bridge/qt/qt_runtime_qt4.cppWebCore/bridge/runtime_array.cppWebCore/bridge/runtime_method.cppWebCore/bridge/runtime_object.cppWebCore/bridge/runtime_root.cppWebKit2/ChangeLogWebKit2/WebProcess/Plugins/Netscape/JSNPObject.cppWebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp1338088019Python Subversion client for CIA1.18WebKitSource118615mjs@apple.comREGRESSION (r116720): Subframe PDF scrolls extremely slowly https://bugs.webkit.org/show_bug.cgi?id=87557 <rdar://problem/11499408> Reviewed by Anders Carlsson. It's not possible to make an automated test for this. * WebProcess/Plugins/PDF/BuiltInPDFView.mm: (WebKit::BuiltInPDFView::wantsWheelEvents): Return true instead of false and delete misleading comment. While the built-in PDF view would get added to the set of scrollable areas anyway, there are some code paths that check wantsWheelEvents explicitly, so it seems necessary to reutrn true. 41WebKit2/ChangeLogWebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm1338086096Python Subversion client for CIA1.18WebKitTools118614dbarton@mathscribe.comMove myself to committers. 22Scripts/webkitpy/common/config/committers.py1338083499Python Subversion client for CIA1.18WebKitLayoutTests118613dbarton@mathscribe.comMy first commit - set svn:mime-type to image/png on one .png file. * platform/mac/mathml/presentation/mroot-pref-width-expected.png: 22ChangeLogplatform/mac/mathml/presentation/mroot-pref-width-expected.png1338080822Python Subversion client for CIA1.18WebKit118612simon.fraser@apple.comClip rects assertion when hovering div with transform https://bugs.webkit.org/show_bug.cgi?id=87580 Source/WebCore: Reviewed by Eric Seidel. Hit testing used to use temporary clip rects in composited documents, until r118562. Now that we cache clip rects for hit testing, we need to clear the cache on descendant layers when a layer gains or loses a transform. Test: fast/layers/clip-rects-assertion.html * rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateTransform): LayoutTests: Reviewed by Eric Seidel. Test that changes transform on hover style, testing for clipRect-related assertions. * fast/layers/clip-rects-assertion-expected.txt: Added. * fast/layers/clip-rects-assertion.html: Added. 132trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/layers/clip-rects-assertion-expected.txttrunk/LayoutTests/fast/layers/clip-rects-assertion.htmltrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/rendering/RenderLayer.cpp1338079324Python Subversion client for CIA1.18WebKitSource118611mitz@apple.com<rdar://problem/11439771> WebProcess sends many synchronous messages to the UI process while scrolling beneath ScrollView::contentsToScreen() https://bugs.webkit.org/show_bug.cgi?id=87571 Reviewed by Anders Carlsson. fakeMouseEventTimerFired() uses the last known mouse position for the fake mouse event, but calls contentsToScreen() to compute a corresponding position in screen coordinates. Avoid this by also recording the last known mouse position in screen coordinates, and using that value. * page/EventHandler.cpp: (WebCore::EventHandler::clear): Added resetting m_currentMouseGlobalPosition. (WebCore::EventHandler::handleMousePressEvent): Added updating m_currentMouseGlobalPosition when updating m_currentMousePosition. (WebCore::EventHandler::handleMouseDoubleClickEvent): Ditto. (WebCore::EventHandler::handleMouseMoveEvent): Ditto. (WebCore::EventHandler::handleMouseReleaseEvent): Ditto. (WebCore::EventHandler::fakeMouseMoveEventTimerFired): Changed to use m_currentMouseGlobalPosition in the fake event instead of calling contentsToScreen(). * page/EventHandler.h: Added m_currentMouseGlobalPosition data member. 101WebCore/ChangeLogWebCore/page/EventHandler.cppWebCore/page/EventHandler.h1338068409Python Subversion client for CIA1.18WebKitSource118610philn@webkit.org[GStreamer] Remove ImageGStreamerCG implementation https://bugs.webkit.org/show_bug.cgi?id=87559 The ImageGStreamerCG abstraction is being removed until I manage to port my gst-mac WebKit branch over to the WebKit2 mac port. No need to update the XCode project because this file is not referenced there anyway. Reviewed by Martin Robinson. * platform/graphics/gstreamer/ImageGStreamer.h: (ImageGStreamer): * platform/graphics/gstreamer/ImageGStreamerCG.mm: Removed. 109WebCore/ChangeLogWebCore/platform/graphics/gstreamer/ImageGStreamer.hWebCore/platform/graphics/gstreamer/ImageGStreamerCG.mm1338062461Python Subversion client for CIA1.18WebKit118609rwlbuis@webkit.orgBug 15799: textPath element does not re-render when referenced path changes https://bugs.webkit.org/show_bug.cgi?id=15799 Patch by Rob Buis <rwlbuis@webkit.org> on 2012-05-26 Reviewed by Nikolas Zimmermann. Source/WebCore: Support textPath updating to changes on the referenced path. To make this possible use the target reference functionality also used by SVGFEImageElement. Tests: svg/custom/textPath-change-id-expected.svg svg/custom/textPath-change-id-pattern-expected.svg svg/custom/textPath-change-id-pattern.svg svg/custom/textPath-change-id.svg svg/custom/textPath-change-id2-expected.svg svg/custom/textPath-change-id2-pattern-expected.svg svg/custom/textPath-change-id2-pattern.svg svg/custom/textPath-change-id2.svg svg/custom/textPath-change-reference-expected.svg svg/custom/textPath-change-reference-pattern-expected.svg svg/custom/textPath-change-reference-pattern.svg svg/custom/textPath-change-reference-using-baseval-expected.svg svg/custom/textPath-change-reference-using-baseval-pattern-expected.svg svg/custom/textPath-change-reference-using-baseval-pattern.svg svg/custom/textPath-change-reference-using-baseval.svg svg/custom/textPath-change-reference.svg svg/custom/textPath-change-reference2-expected.svg svg/custom/textPath-change-reference2-pattern-expected.svg svg/custom/textPath-change-reference2-pattern.svg svg/custom/textPath-change-reference2-using-baseval-expected.svg svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svg svg/custom/textPath-change-reference2-using-baseval-pattern.svg svg/custom/textPath-change-reference2-using-baseval.svg svg/custom/textPath-change-reference2.svg svg/custom/textPath-insert-path-expected.svg svg/custom/textPath-insert-path-pattern-expected.svg svg/custom/textPath-insert-path-pattern.svg svg/custom/textPath-insert-path.svg svg/custom/textPath-modify-child-expected.svg svg/custom/textPath-modify-child-pattern-expected.svg svg/custom/textPath-modify-child-pattern.svg svg/custom/textPath-modify-child.svg svg/custom/textPath-path-change-expected.svg svg/custom/textPath-path-change-pattern-expected.svg svg/custom/textPath-path-change-pattern.svg svg/custom/textPath-path-change-using-svg-dom-expected.svg svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svg svg/custom/textPath-path-change-using-svg-dom-pattern.svg svg/custom/textPath-path-change-using-svg-dom.svg svg/custom/textPath-path-change.svg svg/custom/textPath-path-change2-expected.svg svg/custom/textPath-path-change2-pattern-expected.svg svg/custom/textPath-path-change2-pattern.svg svg/custom/textPath-path-change2.svg svg/custom/textPath-remove-path-expected.svg svg/custom/textPath-remove-path-pattern-expected.svg svg/custom/textPath-remove-path-pattern.svg svg/custom/textPath-remove-path.svg svg/custom/textPath-set-id-expected.svg svg/custom/textPath-set-id.svg svg/custom/textPath-startoffset-expected.svg svg/custom/textPath-startoffset-pattern-expected.svg svg/custom/textPath-startoffset-pattern.svg svg/custom/textPath-startoffset.svg * svg/SVGTextPathElement.cpp: (WebCore::SVGTextPathElement::~SVGTextPathElement): (WebCore): (WebCore::SVGTextPathElement::clearResourceReferences): (WebCore::SVGTextPathElement::svgAttributeChanged): (WebCore::SVGTextPathElement::buildPendingResource): (WebCore::SVGTextPathElement::insertedInto): (WebCore::SVGTextPathElement::removedFrom): * svg/SVGTextPathElement.h: LayoutTests: - textPath-path-change-id.svg, react to change of id attribute on referenced path (makes the xlink:href valid). - textPath-path-change-id2.svg, react to change of id attribute on referenced path (makes the xlink:href invalid). - textPath-path-set-id.svg, react to setting of id attribute on referenced path (makes the xlink:href valid). - textPath-change-reference.svg, <textPath> references existing <path>, change the xlink:href to a non-existing one. - textPath-change-reference-using-baseval.svg, <textPath> references existing <path>, change the xlink:href to a non-existing one using SVG DOM. - textPath-change-reference2.svg, <textPath> references non-existing <path>, change xlink:href to an existing one. - textPath-change-reference2-using-baseval.svg, <textPath> references non-existing <path>, change xlink:href to an existing one using SVG DOM. - textPath-insert-path.svg, <textPath> references non-existing <path>, <path> added dynamically. - textPath-modify-child.svg, react to change on textPath content. - textPath-path-change-using-svg-dom.svg, react to change on pathSegList of referenced path. - textPath-path-change.svg, react to change on d attribute of referenced path. - textPath-path-change2.svg, react to change on d attribute of path referenced by multiple <textPath>s. - textPath-remove-path.svg, <textPath> references existing <path>, <path> is removed from DOM. - textPath-startoffset.svg, react to startOffset attribute change on <textPath>. These tests are duplicated for <textPath> inside a <pattern>. * svg/custom/textPath-change-id-expected.svg: Added. * svg/custom/textPath-change-id-pattern-expected.svg: Added. * svg/custom/textPath-change-id-pattern.svg: Added. * svg/custom/textPath-change-id.svg: Added. * svg/custom/textPath-change-id2-expected.svg: Added. * svg/custom/textPath-change-id2-pattern-expected.svg: Added. * svg/custom/textPath-change-id2-pattern.svg: Added. * svg/custom/textPath-change-id2.svg: Added. * svg/custom/textPath-change-reference-expected.svg: Added. * svg/custom/textPath-change-reference-pattern-expected.svg: Added. * svg/custom/textPath-change-reference-pattern.svg: Added. * svg/custom/textPath-change-reference-using-baseval-expected.svg: Added. * svg/custom/textPath-change-reference-using-baseval-pattern-expected.svg: Added. * svg/custom/textPath-change-reference-using-baseval-pattern.svg: Added. * svg/custom/textPath-change-reference-using-baseval.svg: Added. * svg/custom/textPath-change-reference.svg: Added. * svg/custom/textPath-change-reference2-expected.svg: Added. * svg/custom/textPath-change-reference2-pattern-expected.svg: Added. * svg/custom/textPath-change-reference2-pattern.svg: Added. * svg/custom/textPath-change-reference2-using-baseval-expected.svg: Added. * svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svg: Added. * svg/custom/textPath-change-reference2-using-baseval-pattern.svg: Added. * svg/custom/textPath-change-reference2-using-baseval.svg: Added. * svg/custom/textPath-change-reference2.svg: Added. * svg/custom/textPath-insert-path-expected.svg: Added. * svg/custom/textPath-insert-path-pattern-expected.svg: Added. * svg/custom/textPath-insert-path-pattern.svg: Added. * svg/custom/textPath-insert-path.svg: Added. * svg/custom/textPath-modify-child-expected.svg: Added. * svg/custom/textPath-modify-child-pattern-expected.svg: Added. * svg/custom/textPath-modify-child-pattern.svg: Added. * svg/custom/textPath-modify-child.svg: Added. * svg/custom/textPath-path-change-expected.svg: Added. * svg/custom/textPath-path-change-pattern-expected.svg: Added. * svg/custom/textPath-path-change-pattern.svg: Added. * svg/custom/textPath-path-change-using-svg-dom-expected.svg: Added. * svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svg: Added. * svg/custom/textPath-path-change-using-svg-dom-pattern.svg: Added. * svg/custom/textPath-path-change-using-svg-dom.svg: Added. * svg/custom/textPath-path-change.svg: Added. * svg/custom/textPath-path-change2-expected.svg: Added. * svg/custom/textPath-path-change2-pattern-expected.svg: Added. * svg/custom/textPath-path-change2-pattern.svg: Added. * svg/custom/textPath-path-change2.svg: Added. * svg/custom/textPath-remove-path-expected.svg: Added. * svg/custom/textPath-remove-path-pattern-expected.svg: Added. * svg/custom/textPath-remove-path-pattern.svg: Added. * svg/custom/textPath-remove-path.svg: Added. * svg/custom/textPath-set-id-expected.svg: Added. * svg/custom/textPath-set-id.svg: Added. * svg/custom/textPath-startoffset-expected.svg: Added. * svg/custom/textPath-startoffset-pattern-expected.svg: Added. * svg/custom/textPath-startoffset-pattern.svg: Added. * svg/custom/textPath-startoffset.svg: Added. 1177trunk/LayoutTests/ChangeLogtrunk/LayoutTests/svg/custom/textPath-change-id-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-id-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-id-pattern.svgtrunk/LayoutTests/svg/custom/textPath-change-id.svgtrunk/LayoutTests/svg/custom/textPath-change-id2-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-id2-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-id2-pattern.svgtrunk/LayoutTests/svg/custom/textPath-change-id2.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-pattern.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-using-baseval-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-using-baseval-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-using-baseval-pattern.svgtrunk/LayoutTests/svg/custom/textPath-change-reference-using-baseval.svgtrunk/LayoutTests/svg/custom/textPath-change-reference.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-pattern.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-using-baseval-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-using-baseval-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-using-baseval-pattern.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2-using-baseval.svgtrunk/LayoutTests/svg/custom/textPath-change-reference2.svgtrunk/LayoutTests/svg/custom/textPath-insert-path-expected.svgtrunk/LayoutTests/svg/custom/textPath-insert-path-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-insert-path-pattern.svgtrunk/LayoutTests/svg/custom/textPath-insert-path.svgtrunk/LayoutTests/svg/custom/textPath-modify-child-expected.svgtrunk/LayoutTests/svg/custom/textPath-modify-child-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-modify-child-pattern.svgtrunk/LayoutTests/svg/custom/textPath-modify-child.svgtrunk/LayoutTests/svg/custom/textPath-path-change-expected.svgtrunk/LayoutTests/svg/custom/textPath-path-change-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-path-change-pattern.svgtrunk/LayoutTests/svg/custom/textPath-path-change-using-svg-dom-expected.svgtrunk/LayoutTests/svg/custom/textPath-path-change-using-svg-dom-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-path-change-using-svg-dom-pattern.svgtrunk/LayoutTests/svg/custom/textPath-path-change-using-svg-dom.svgtrunk/LayoutTests/svg/custom/textPath-path-change.svgtrunk/LayoutTests/svg/custom/textPath-path-change2-expected.svgtrunk/LayoutTests/svg/custom/textPath-path-change2-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-path-change2-pattern.svgtrunk/LayoutTests/svg/custom/textPath-path-change2.svgtrunk/LayoutTests/svg/custom/textPath-remove-path-expected.svgtrunk/LayoutTests/svg/custom/textPath-remove-path-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-remove-path-pattern.svgtrunk/LayoutTests/svg/custom/textPath-remove-path.svgtrunk/LayoutTests/svg/custom/textPath-set-id-expected.svgtrunk/LayoutTests/svg/custom/textPath-set-id.svgtrunk/LayoutTests/svg/custom/textPath-startoffset-expected.svgtrunk/LayoutTests/svg/custom/textPath-startoffset-pattern-expected.svgtrunk/LayoutTests/svg/custom/textPath-startoffset-pattern.svgtrunk/LayoutTests/svg/custom/textPath-startoffset.svgtrunk/Source/WebCore/ChangeLogtrunk/Source/WebCore/svg/SVGTextPathElement.cpptrunk/Source/WebCore/svg/SVGTextPathElement.h1338048278Python Subversion client for CIA1.18WebKitSource118608zimmermann@webkit.orgAvoid updateFromElement() usage in SVG https://bugs.webkit.org/show_bug.cgi?id=87573 Stop relying on updateFromElement() - instead rely on addChild/removeChild, which allows us to optimize the resources re-fetching. When a child is added to the tree we don't need to remove existing resources from the SVGResourcesCache - the renderer can't be in the cache yet. Similary, remove the entry from the cache earlier: as soon as the renderer is removed from the tree, instead of waiting for willBeDestroyed(). No new tests, refactoring only. * rendering/svg/RenderSVGBlock.cpp: * rendering/svg/RenderSVGBlock.h: (RenderSVGBlock): * rendering/svg/RenderSVGContainer.cpp: (WebCore::RenderSVGContainer::addChild): (WebCore): (WebCore::RenderSVGContainer::removeChild): * rendering/svg/RenderSVGContainer.h: (RenderSVGContainer): * rendering/svg/RenderSVGInline.cpp: (WebCore::RenderSVGInline::addChild): (WebCore::RenderSVGInline::removeChild): * rendering/svg/RenderSVGInline.h: (RenderSVGInline): * rendering/svg/RenderSVGModelObject.cpp: * rendering/svg/RenderSVGModelObject.h: (RenderSVGModelObject): * rendering/svg/RenderSVGResourceContainer.cpp: (WebCore::RenderSVGResourceContainer::registerResource): * rendering/svg/RenderSVGRoot.cpp: (WebCore::RenderSVGRoot::addChild): (WebCore): (WebCore::RenderSVGRoot::removeChild): * rendering/svg/RenderSVGRoot.h: (RenderSVGRoot): * rendering/svg/RenderSVGText.cpp: (WebCore::RenderSVGText::addChild): (WebCore::RenderSVGText::removeChild): * rendering/svg/SVGResourcesCache.cpp: (WebCore::SVGResourcesCache::clientStyleChanged): (WebCore::rendererCanHaveResources): (WebCore): (WebCore::SVGResourcesCache::clientWasAddedToTree): (WebCore::SVGResourcesCache::clientWillBeRemovedFromTree): * rendering/svg/SVGResourcesCache.h: (SVGResourcesCache): * svg/SVGStyledElement.cpp: * svg/SVGStyledElement.h: (SVGStyledElement): 415WebCore/ChangeLogWebCore/rendering/svg/RenderSVGBlock.cppWebCore/rendering/svg/RenderSVGBlock.hWebCore/rendering/svg/RenderSVGContainer.cppWebCore/rendering/svg/RenderSVGContainer.hWebCore/rendering/svg/RenderSVGInline.cppWebCore/rendering/svg/RenderSVGInline.hWebCore/rendering/svg/RenderSVGModelObject.cppWebCore/rendering/svg/RenderSVGModelObject.hWebCore/rendering/svg/RenderSVGResourceContainer.cppWebCore/rendering/svg/RenderSVGRoot.cppWebCore/rendering/svg/RenderSVGRoot.hWebCore/rendering/svg/RenderSVGText.cppWebCore/rendering/svg/SVGResourcesCache.cppWebCore/rendering/svg/SVGResourcesCache.hWebCore/svg/SVGStyledElement.cppWebCore/svg/SVGStyledElement.h1338039249