http://cia.vc/stats/project/webkit4143512109223338131717NoneWebKit is the system framework used on Mac OS X by Safari, Dashboard, Mail.app, and many other OS X applications. It is based on the KHTML engine from KDE.NoneWebKithttp://webkit.orgNonePython Subversion client for CIA1.18WebKitWebKitSite56302mjs@apple.com2010-03-20 Maciej Stachowiak <mjs@apple.com> Reviewed by Mark Rowe. WebKit blog should be valid HTML5 https://bugs.webkit.org/show_bug.cgi?id=36410 * blog/wp-content/themes/webkit/comments-popup.php: * blog/wp-content/themes/webkit/footer.php: * blog/wp-content/themes/webkit/header.php: 65ChangeLogblog/wp-content/themes/webkit/comments-popup.phpblog/wp-content/themes/webkit/footer.phpblog/wp-content/themes/webkit/header.php1269076036Python Subversion client for CIA1.18WebKitWebCore56301joepeck@webkit.org2010-03-20 Joseph Pecoraro <joepeck@webkit.org> Reviewed by David Kilzer. Assertion failure in media/video-controls-with-mutation-event-handler.html https://bugs.webkit.org/show_bug.cgi?id=36376 Test: media/video-controls-with-mutation-event-handler.html Break early (when not attached) in the defaultEventHandler before the slider is completely set up. * rendering/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::defaultEventHandler): (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): * rendering/RenderMedia.cpp: (WebCore::RenderMedia::createVolumeSlider): 68ChangeLogrendering/MediaControlElements.cpprendering/RenderMedia.cpp1269075883Python Subversion client for CIA1.18WebKitWebKitSite56300mjs@apple.com2010-03-20 Maciej Stachowiak <mjs@apple.com> Reviewed by Mark Rowe. Fix a bunch of HTML5 validation errors on various pages. https://bugs.webkit.org/show_bug.cgi?id=36409 * building/build.html: * building/checkout.html: * building/debug.html: * building/run.html: * building/tools.html: * coding/coding-style.html: * coding/contributing.html: * coding/major-objects.html: * css/main.css: (.asciiart): * demos/index.html: * header.inc: * projects/compat/index.html: * projects/css/index.html: * projects/documentation/index.html: * projects/goals.html: * projects/index.html: * projects/mathml/index.html: * quality/bugpriorities.html: * quality/bugwriting.html: * quality/crashlogs.html: * quality/lifecycle.html: * quality/testing.html: * quality/testwriting.html: 971ChangeLogbuilding/build.htmlbuilding/checkout.htmlbuilding/debug.htmlbuilding/run.htmlbuilding/tools.htmlcoding/coding-style.htmlcoding/contributing.htmlcoding/major-objects.htmlcss/main.cssdemos/index.htmlheader.incprojects/compat/index.htmlprojects/css/index.htmlprojects/documentation/index.htmlprojects/goals.htmlprojects/index.htmlprojects/mathml/index.htmlquality/bugpriorities.htmlquality/bugwriting.htmlquality/crashlogs.htmlquality/lifecycle.htmlquality/testing.htmlquality/testwriting.html1269072744Python Subversion client for CIA1.18WebKitWebKitSite56299mjs@apple.com2010-03-19 Maciej Stachowiak <mjs@apple.com> Reviewed by Mark Rowe. webkit.org should use the HTML5 doctype https://bugs.webkit.org/show_bug.cgi?id=36407 * header.inc: * misc/drosera/index.html: * perf/slickspeed/system/index.php: * perf/slickspeed/system/template.php: * specs/index.html: 94ChangeLogheader.incmisc/drosera/index.htmlperf/slickspeed/system/index.phpperf/slickspeed/system/template.phpspecs/index.html1269069876Python Subversion client for CIA1.18WebKitWebKitSite56298mjs@apple.com2010-03-19 Maciej Stachowiak <mjs@apple.com> Reviewed by Mark Rowe. http://webkit.org/ has an HTML5 validation error https://bugs.webkit.org/show_bug.cgi?id=36406 * nav.inc: 33ChangeLognav.inc1269067380Python Subversion client for CIA1.18WebKit56297hamaji@chromium.org2010-03-19 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Dan Bernstein. WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c) https://bugs.webkit.org/show_bug.cgi?id=34641 * fast/css/first-letter-block-form-controls-crash-expected.txt: Added. * fast/css/first-letter-block-form-controls-crash.html: Added. 2010-03-19 Shinichiro Hamaji <hamaji@chromium.org> Reviewed by Dan Bernstein. WebCore::RenderButton::styleDidChange ReadAV@NULL (6739b7fe455ecb54a6812c0866c3b47c) https://bugs.webkit.org/show_bug.cgi?id=34641 Don't dig into buttons and menu lists when finding which element should be modified by :first-letter pseudo class. Even before this change, we didn't dig into inline buttons and menu lists as they are replaced so this issue wasn't found long time. Test: fast/css/first-letter-block-form-controls-crash.html * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter): 117trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/css/first-letter-block-form-controls-crash-expected.txttrunk/LayoutTests/fast/css/first-letter-block-form-controls-crash.htmltrunk/WebCore/ChangeLogtrunk/WebCore/rendering/RenderBlock.cpp1269062947Python Subversion client for CIA1.18WebKitLayoutTests56296mrowe@apple.comLand a test result that should have been added along with the test in r56286. * transitions/transition-end-event-destroy-iframe-expected.txt: Copied from LayoutTests/transitions/transition-end-event-destroy-renderer-expected.txt. 25ChangeLogtransitions/transition-end-event-destroy-iframe-expected.txt1269059392Python Subversion client for CIA1.18WebKit56295eric@webkit.org2010-03-19 Adam Barth <abarth@webkit.org> Reviewed by Daniel Bates. Change XSSAuditor block syntax https://bugs.webkit.org/show_bug.cgi?id=34436 Update tests to account for the new blocking syntax. Added test for disabling the XSS filter. * http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: * http/tests/security/xssAuditor/malformed-xss-protection-header.html: * http/tests/security/xssAuditor/no-protection-script-tag-expected.txt: Added. * http/tests/security/xssAuditor/no-protection-script-tag.html: Added. * http/tests/security/xssAuditor/resources/echo-head-base-href.pl: * http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: * http/tests/security/xssAuditor/resources/echo-intertag.pl: * http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt: Added. * http/tests/security/xssAuditor/xss-protection-parsing-01.html: Added. 2010-03-19 Adam Barth <abarth@webkit.org> Reviewed by Daniel Bates. Change XSSAuditor block syntax https://bugs.webkit.org/show_bug.cgi?id=34436 Update our blocking syntax to something more reasonable. Also, implemented a way for a web site to disable the filter. Tests: http/tests/security/xssAuditor/no-protection-script-tag.html http/tests/security/xssAuditor/xss-protection-parsing-01.html * page/XSSAuditor.cpp: (WebCore::XSSAuditor::xssProtection): (WebCore::XSSAuditor::findInRequest): * page/XSSAuditor.h: * platform/network/HTTPParsers.cpp: (WebCore::skipToken): (WebCore::parseXSSProtectionHeader): * platform/network/HTTPParsers.h: (WebCore::): 383trunk/LayoutTests/ChangeLogtrunk/LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txttrunk/LayoutTests/http/tests/security/xssAuditor/malformed-xss-protection-header.htmltrunk/LayoutTests/http/tests/security/xssAuditor/no-protection-script-tag-expected.txttrunk/LayoutTests/http/tests/security/xssAuditor/no-protection-script-tag.htmltrunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-head-base-href.pltrunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pltrunk/LayoutTests/http/tests/security/xssAuditor/resources/echo-intertag.pltrunk/LayoutTests/http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txttrunk/LayoutTests/http/tests/security/xssAuditor/xss-protection-parsing-01.htmltrunk/WebCore/ChangeLogtrunk/WebCore/page/XSSAuditor.cpptrunk/WebCore/page/XSSAuditor.htrunk/WebCore/platform/network/HTTPParsers.cpptrunk/WebCore/platform/network/HTTPParsers.h1269057318Python Subversion client for CIA1.18WebKitWebKit56294eric@webkit.org2010-03-19 Kenneth Russell <kbr@google.com> Reviewed by Darin Fisher. Add GraphicsContext3D abstraction to WebKit API https://bugs.webkit.org/show_bug.cgi?id=36262 Added WebGraphicsContext3D to the WebKit API and refactored Chromium's GraphicsContext3D implementation to use it. All of the OpenGL calls have been moved out of WebKit/chromium/src/GraphicsContext3D.cpp and into the WebGraphicsContext3D implementation. GraphicsContext3D is still responsible for the transfer of rendered output from the WebGraphicsContext3D to the HTMLCanvasElement. The GraphicsContext3DInternal class, which is a data member of GraphicsContext3D for the Chromium port, remains. It is possible to eliminate this class and thereby one level of delegation, but this is being deferred. The needed entry point for a Chrome implementation of WebGraphicsContext3D has been added to WebKitClient, but it is not being called yet by GraphicsContext3D. It will be once this patch lands and Chromium is rolled forward to support this entry point. This is a large patch, but the transformation is almost entirely mechanical and there is no change in functionality. Nearly all of GraphicsContext3D and GraphicsContext3DInternal has been moved to WebGraphicsContext3DDefaultImpl. The only area where the splitting of logic is less than mechanical is GraphicsContext3D::beginPaint() and its callees. Ran all WebGL layout tests and demos from Khronos site in Chromium. * WebKit.gyp: * public/WebGraphicsContext3D.h: Added. (WebKit::WebGraphicsContext3D::Attributes::Attributes): (WebKit::WebGraphicsContext3D::~WebGraphicsContext3D): * public/WebKitClient.h: (WebKit::WebKitClient::createGraphicsContext3D): * src/GraphicsContext3D.cpp: (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal): (WebCore::GraphicsContext3DInternal::initialize): (WebCore::GraphicsContext3DInternal::platformGraphicsContext3D): (WebCore::GraphicsContext3DInternal::platformTexture): (WebCore::GraphicsContext3DInternal::beginPaint): (WebCore::GraphicsContext3DInternal::endPaint): (WebCore::GraphicsContext3DInternal::reshape): (WebCore::GraphicsContext3DInternal::bindAttribLocation): (WebCore::GraphicsContext3DInternal::bindTexture): (WebCore::GraphicsContext3DInternal::bufferData): (WebCore::GraphicsContext3DInternal::bufferSubData): (WebCore::GraphicsContext3DInternal::getActiveAttrib): (WebCore::GraphicsContext3DInternal::getActiveUniform): (WebCore::GraphicsContext3DInternal::getAttribLocation): (WebCore::GraphicsContext3DInternal::getContextAttributes): (WebCore::GraphicsContext3DInternal::getProgramInfoLog): (WebCore::GraphicsContext3DInternal::getShaderInfoLog): (WebCore::GraphicsContext3DInternal::getShaderSource): (WebCore::GraphicsContext3DInternal::getString): (WebCore::GraphicsContext3DInternal::getUniformLocation): (WebCore::GraphicsContext3DInternal::readPixels): (WebCore::GraphicsContext3DInternal::shaderSource): (WebCore::GraphicsContext3DInternal::texImage2D): (WebCore::GraphicsContext3DInternal::texSubImage2D): (WebCore::GraphicsContext3DInternal::uniform1fv): (WebCore::GraphicsContext3DInternal::uniform1iv): (WebCore::GraphicsContext3DInternal::uniform2fv): (WebCore::GraphicsContext3DInternal::uniform2iv): (WebCore::GraphicsContext3DInternal::uniform3fv): (WebCore::GraphicsContext3DInternal::uniform3iv): (WebCore::GraphicsContext3DInternal::uniform4fv): (WebCore::GraphicsContext3DInternal::uniform4iv): (WebCore::GraphicsContext3DInternal::uniformMatrix2fv): (WebCore::GraphicsContext3DInternal::uniformMatrix3fv): (WebCore::GraphicsContext3DInternal::uniformMatrix4fv): (WebCore::GraphicsContext3D::GraphicsContext3D): (WebCore::GraphicsContext3D::~GraphicsContext3D): (WebCore::GraphicsContext3D::create): (WebCore::GraphicsContext3D::platformGraphicsContext3D): (WebCore::GraphicsContext3D::platformTexture): (WebCore::GraphicsContext3D::texImage2D): (WebCore::GraphicsContext3D::texSubImage2D): * src/WebGraphicsContext3D.cpp: Added. (WebKit::WebGraphicsContext3D::createDefault): * src/WebGraphicsContext3DDefaultImpl.cpp: Added. (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::create): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::~GLConnection): (WebKit::WebGraphicsContext3DDefaultImpl::VertexAttribPointerState::VertexAttribPointerState): (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::~WebGraphicsContext3DDefaultImpl): (WebKit::WebGraphicsContext3DDefaultImpl::initialize): (WebKit::WebGraphicsContext3DDefaultImpl::makeContextCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::width): (WebKit::WebGraphicsContext3DDefaultImpl::height): (WebKit::WebGraphicsContext3DDefaultImpl::sizeInBytes): (WebKit::createTextureObject): (WebKit::WebGraphicsContext3DDefaultImpl::reshape): (WebKit::WebGraphicsContext3DDefaultImpl::flipVertically): (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::activeTexture): (WebKit::WebGraphicsContext3DDefaultImpl::bindBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::bindFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::disableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::drawElements): (WebKit::WebGraphicsContext3DDefaultImpl::enableVertexAttribArray): (WebKit::WebGraphicsContext3DDefaultImpl::generateMipmap): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveAttrib): (WebKit::WebGraphicsContext3DDefaultImpl::getActiveUniform): (WebKit::WebGraphicsContext3DDefaultImpl::getContextAttributes): (WebKit::WebGraphicsContext3DDefaultImpl::getError): (WebKit::WebGraphicsContext3DDefaultImpl::getProgramInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderInfoLog): (WebKit::WebGraphicsContext3DDefaultImpl::getShaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::getString): (WebKit::WebGraphicsContext3DDefaultImpl::getVertexAttribOffset): (WebKit::WebGraphicsContext3DDefaultImpl::releaseShaderCompiler): (WebKit::WebGraphicsContext3DDefaultImpl::shaderSource): (WebKit::WebGraphicsContext3DDefaultImpl::vertexAttribPointer): (WebKit::WebGraphicsContext3DDefaultImpl::createBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createProgram): (WebKit::WebGraphicsContext3DDefaultImpl::createRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::createTexture): (WebKit::WebGraphicsContext3DDefaultImpl::deleteBuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteFramebuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteProgram): (WebKit::WebGraphicsContext3DDefaultImpl::deleteRenderbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::deleteShader): (WebKit::WebGraphicsContext3DDefaultImpl::deleteTexture): (WebKit::WebGraphicsContext3DDefaultImpl::synthesizeGLError): * src/WebGraphicsContext3DDefaultImpl.h: Added. (WebKit::WebGraphicsContext3DDefaultImpl::): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::chooseFBConfig): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createNewContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::createPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyPbuffer): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::makeCurrent): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::destroyContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::getCurrentContext): (WebKit::WebGraphicsContext3DDefaultImpl::GLConnection::GLConnection): 4968chromium/ChangeLogchromium/WebKit.gypchromium/public/WebGraphicsContext3D.hchromium/public/WebKitClient.hchromium/src/GraphicsContext3D.cppchromium/src/WebGraphicsContext3D.cppchromium/src/WebGraphicsContext3DDefaultImpl.cppchromium/src/WebGraphicsContext3DDefaultImpl.h1269056109Python Subversion client for CIA1.18WebKitWebCore56293eric@webkit.org2010-03-19 Eric Uhrhane <ericu@chromium.org> Reviewed by Dmitry Titov. Refactor DatabaseTracker.cpp for thread safety https://bugs.webkit.org/show_bug.cgi?id=34991 This enables calling into DatabaseTracker from multiple context threads, as will happen once Workers can access the Database. It required a fair amount of reshuffling of locks. I ended up splitting the public interface [calls that take locks and call private functions] from the implementations [calls that assert that locks are already held] in order to avoid lock conflicts. I also had to make sure we weren't sharing Strings or SecurityOrigins across threads. No new tests. Allow access to database handles from multiple threads IFF SQLite is new enough and the user requests it. * platform/sql/SQLiteDatabase.cpp: (WebCore::SQLiteDatabase::SQLiteDatabase): (WebCore::SQLiteDatabase::disableThreadingChecks): * platform/sql/SQLiteDatabase.h: (WebCore::SQLiteDatabase::sqlite3Handle): (WebCore::SQLiteDatabase::disableThreadingChecks): Remove an asynchronous call from Database::close back to the execution thread, so that cleanup can be more deterministic. * storage/Database.cpp: (WebCore::Database::markAsDeletedAndClose): (WebCore::Database::close): * storage/Database.h: (WebCore::Database::): * storage/DatabaseDetails.h: (WebCore::DatabaseDetails::DatabaseDetails): (WebCore::DatabaseDetails::thread): * storage/DatabaseTask.cpp: (WebCore::DatabaseCloseTask::doPerformTask): * storage/DatabaseThread.cpp: (WebCore::DatabaseThread::databaseThread): Any Strings that get stored in DatabaseTracker, and any Strings returned from DatabaseTracker, are now threadsafeCopies. Public functions now take all needed locks, then generally call only private functions [there are a few exceptions: deletion functions and origins()]. Private functions no longer take locks. m_quotaMapGuard becomes m_databaseGuard, and now protects m_database, m_quotaMap, m_proposedDatabases, m_databaseDirectoryPath, m_originsBeingDeleted, m_beingCreated, and m_beingDeleted. m_proposedDatabases replaces m_proposedDatabase, to account for reentrancy. * storage/DatabaseTracker.h: * storage/DatabaseTracker.cpp: (WebCore::DatabaseTracker::originQuotaManagerNoLock): (WebCore::DatabaseTracker::originQuotaManager): (WebCore::DatabaseTracker::DatabaseTracker): (WebCore::DatabaseTracker::setDatabaseDirectoryPath): (WebCore::DatabaseTracker::databaseDirectoryPath): (WebCore::DatabaseTracker::trackerDatabasePath): (WebCore::DatabaseTracker::openTrackerDatabase): (WebCore::DatabaseTracker::canEstablishDatabase): (WebCore::DatabaseTracker::hasEntryForOriginNoLock): (WebCore::DatabaseTracker::hasEntryForOrigin): (WebCore::DatabaseTracker::hasEntryForDatabase): (WebCore::DatabaseTracker::originPath): (WebCore::DatabaseTracker::fullPathForDatabaseNoLock): (WebCore::DatabaseTracker::fullPathForDatabase): (WebCore::DatabaseTracker::populateOrigins): (WebCore::DatabaseTracker::origins): (WebCore::DatabaseTracker::databaseNamesForOriginNoLock): (WebCore::DatabaseTracker::databaseNamesForOrigin): (WebCore::DatabaseTracker::detailsForNameAndOrigin): (WebCore::DatabaseTracker::setDatabaseDetails): (WebCore::DatabaseTracker::usageForDatabase): (WebCore::DatabaseTracker::addOpenDatabase): (WebCore::DatabaseTracker::removeOpenDatabase): (WebCore::DatabaseTracker::usageForOriginNoLock): (WebCore::DatabaseTracker::usageForOrigin): (WebCore::DatabaseTracker::quotaForOriginNoLock): (WebCore::DatabaseTracker::quotaForOrigin): (WebCore::DatabaseTracker::setQuota): (WebCore::DatabaseTracker::addDatabase): (WebCore::DatabaseTracker::deleteAllDatabases): (WebCore::DatabaseTracker::deleteOrigin): (WebCore::DatabaseTracker::deleteDatabase): (WebCore::DatabaseTracker::deleteDatabaseFile): (WebCore::DatabaseTracker::setClient): (WebCore::DatabaseTracker::scheduleNotifyDatabaseChanged): (WebCore::DatabaseTracker::notifyDatabasesChanged): These functions keep track of in-progress deletions and creations, so that we can make sure nobody every deletes a database file while a live database is using it. (WebCore::DatabaseTracker::canCreateDatabase): (WebCore::DatabaseTracker::recordCreatingDatabase): (WebCore::DatabaseTracker::doneCreatingDatabase): (WebCore::DatabaseTracker::creatingDatabase): (WebCore::DatabaseTracker::canDeleteDatabase): (WebCore::DatabaseTracker::recordDeletingDatabase): (WebCore::DatabaseTracker::doneDeletingDatabase): (WebCore::DatabaseTracker::deletingDatabase): (WebCore::DatabaseTracker::canDeleteOrigin): (WebCore::DatabaseTracker::deletingOrigin): (WebCore::DatabaseTracker::recordDeletingOrigin): (WebCore::DatabaseTracker::doneDeletingOrigin): Any SecurityOrigins stored in OriginQuotaManager are now threadsafeCopies of inputs. There's a new tryLock() function in addition to the existing lock(). * storage/OriginQuotaManager.cpp: (WebCore::OriginQuotaManager::tryLock): (WebCore::OriginQuotaManager::trackOrigin): * storage/OriginQuotaManager.h: * page/SecurityOrigin.cpp: (WebCore::SecurityOrigin::databaseIdentifier): Removed DEFINE_STATIC_LOCAL wrapper on a local variable; it appears to have been a small optimization, but it's not thread-safe. 1441ChangeLogpage/SecurityOrigin.cppplatform/sql/SQLiteDatabase.cppplatform/sql/SQLiteDatabase.hstorage/Database.cppstorage/Database.hstorage/DatabaseDetails.hstorage/DatabaseTask.cppstorage/DatabaseThread.cppstorage/DatabaseTracker.cppstorage/DatabaseTracker.hstorage/OriginQuotaManager.cppstorage/OriginQuotaManager.h1269054223Python Subversion client for CIA1.18WebKitWebCore56292eric@webkit.org2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org> Reviewed by Antti Koivisto. Multiselect popups - rendering https://bugs.webkit.org/show_bug.cgi?id=36006 The objective of this patch is to create a compile time flag that can be used to force all <select> elements to be rendered as menu lists. Theme stylesheet mechanism has been used to change the appearance of the elements. Class QtStyleOptionWebComboBox has been introduced to provide to QStyle objects the needed information to render <select multiple> comboboxes. * WebCore.pri: * WebCore.pro: * css/themeQtNoListboxes.css: Added. (select[size][multiple]): * dom/SelectElement.h: (WebCore::SelectElementData::usesMenuList): * platform/qt/QtStyleOptionWebComboBox.h: Added. (WebCore::QtStyleOptionWebComboBox::QtStyleOptionWebComboBox): (WebCore::QtStyleOptionWebComboBox::multiple): (WebCore::QtStyleOptionWebComboBox::checkMultiple): * platform/qt/RenderThemeQt.cpp: (WebCore::RenderThemeQt::extraDefaultStyleSheet): (WebCore::RenderThemeQt::paintMenuList): (WebCore::RenderThemeQt::paintMenuListButton): * platform/qt/RenderThemeQt.h: 261ChangeLogWebCore.priWebCore.procss/themeQtNoListboxes.cssdom/SelectElement.hplatform/qt/QtStyleOptionWebComboBox.hplatform/qt/RenderThemeQt.cppplatform/qt/RenderThemeQt.h1269052507Python Subversion client for CIA1.18WebKit56291eric@webkit.org2010-03-19 Zhenyao Mo <zmo@google.com> Reviewed by Oliver Hunt. Update WebGLArray.slice() to new spec https://bugs.webkit.org/show_bug.cgi?id-35612 * fast/canvas/webgl/array-unit-tests-expected.txt: Changed tests to reflect the new slice parameters; add new test cases for default inputs for slice. * fast/canvas/webgl/array-unit-tests.html: Ditto. * fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt: Changed tests to reflect the new slice parameters. * fast/canvas/webgl/webgl-array-invalid-ranges.html: Ditto. 2010-03-19 Zhenyao Mo <zmo@google.com> Reviewed by Oliver Hunt. Update WebGLArray.slice() to new spec https://bugs.webkit.org/show_bug.cgi?id-35612 * bindings/js/JSWebGLArrayCustom.cpp: Adding support for default inputs. (WebCore::JSWebGLArray::slice): * bindings/v8/custom/V8WebGLArrayCustom.cpp: Ditto. (WebCore::V8WebGLArray::sliceCallback): * html/canvas/WebGLArray.cpp: Map start/end to offset/length. (WebCore::WebGLArray::calculateOffsetAndLength): * html/canvas/WebGLArray.h: Modified slice parameters. * html/canvas/WebGLArray.idl: Define custom binding for slice(). * html/canvas/WebGLByteArray.cpp: Modified slice parameters. (WebCore::WebGLByteArray::slice): * html/canvas/WebGLByteArray.h: Ditto. * html/canvas/WebGLFloatArray.cpp: Ditto. (WebCore::WebGLFloatArray::slice): * html/canvas/WebGLFloatArray.h: Ditto. * html/canvas/WebGLIntArray.cpp: Ditto. (WebCore::WebGLIntArray::slice): * html/canvas/WebGLIntArray.h: Ditto. * html/canvas/WebGLShortArray.cpp: Ditto. (WebCore::WebGLShortArray::slice): * html/canvas/WebGLShortArray.h: Ditto. * html/canvas/WebGLUnsignedByteArray.cpp: Ditto. (WebCore::WebGLUnsignedByteArray::slice): * html/canvas/WebGLUnsignedByteArray.h: Ditto. * html/canvas/WebGLUnsignedIntArray.cpp: Ditto. (WebCore::WebGLUnsignedIntArray::slice): * html/canvas/WebGLUnsignedIntArray.h: Ditto. * html/canvas/WebGLUnsignedShortArray.cpp: Ditto. (WebCore::WebGLUnsignedShortArray::slice): * html/canvas/WebGLUnsignedShortArray.h: Ditto. 694trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/canvas/webgl/array-unit-tests-expected.txttrunk/LayoutTests/fast/canvas/webgl/array-unit-tests.htmltrunk/LayoutTests/fast/canvas/webgl/webgl-array-invalid-ranges-expected.txttrunk/LayoutTests/fast/canvas/webgl/webgl-array-invalid-ranges.htmltrunk/WebCore/ChangeLogtrunk/WebCore/bindings/js/JSWebGLArrayCustom.cpptrunk/WebCore/bindings/v8/custom/V8WebGLArrayCustom.cpptrunk/WebCore/html/canvas/WebGLArray.cpptrunk/WebCore/html/canvas/WebGLArray.htrunk/WebCore/html/canvas/WebGLArray.idltrunk/WebCore/html/canvas/WebGLByteArray.cpptrunk/WebCore/html/canvas/WebGLByteArray.htrunk/WebCore/html/canvas/WebGLFloatArray.cpptrunk/WebCore/html/canvas/WebGLFloatArray.htrunk/WebCore/html/canvas/WebGLIntArray.cpptrunk/WebCore/html/canvas/WebGLIntArray.htrunk/WebCore/html/canvas/WebGLShortArray.cpptrunk/WebCore/html/canvas/WebGLShortArray.htrunk/WebCore/html/canvas/WebGLUnsignedByteArray.cpptrunk/WebCore/html/canvas/WebGLUnsignedByteArray.htrunk/WebCore/html/canvas/WebGLUnsignedIntArray.cpptrunk/WebCore/html/canvas/WebGLUnsignedIntArray.htrunk/WebCore/html/canvas/WebGLUnsignedShortArray.cpptrunk/WebCore/html/canvas/WebGLUnsignedShortArray.h1269050298Python Subversion client for CIA1.18WebKitLayoutTests56290eric@webkit.org2010-03-19 Adam Barth <abarth@webkit.org> Reviewed by Darin Adler. Freeze sandbox attributes on creation https://bugs.webkit.org/show_bug.cgi?id=34184 Test that allow-forms is frozen on document creation. * fast/frames/resources/sandboxed-iframe-form-dynamic-allowed.html: Added. * fast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.html: Added. * fast/frames/sandboxed-iframe-forms-dynamic-expected.txt: Added. * fast/frames/sandboxed-iframe-forms-dynamic.html: Added. 132ChangeLogfast/frames/resources/sandboxed-iframe-form-dynamic-allowed.htmlfast/frames/resources/sandboxed-iframe-form-dynamic-disallowed.htmlfast/frames/sandboxed-iframe-forms-dynamic-expected.txtfast/frames/sandboxed-iframe-forms-dynamic.html1269049154Python Subversion client for CIA1.18WebKit56288oliver@apple.com2010-03-19 Justin Schuh <jschuh@chromium.org> Reviewed by Oliver Hunt. Security: ReadAV@NULL for negative feMorphology filter radius https://bugs.webkit.org/show_bug.cgi?id=34566 Prevents building the filter if either radius is negative. Catches negative radii resulting from conversions. Test: svg/filters/feMorphology-invalid-radius.svg * svg/SVGFEMorphologyElement.cpp: (WebCore::SVGFEMorphologyElement::build): * svg/graphics/filters/SVGFEMorphology.cpp: (WebCore::FEMorphology::apply): 188trunk/LayoutTests/ChangeLogtrunk/LayoutTests/svg/filters/feMorphology-invalid-radius-expected.txttrunk/LayoutTests/svg/filters/feMorphology-invalid-radius.svgtrunk/WebCore/ChangeLogtrunk/WebCore/svg/SVGFEMorphologyElement.cpptrunk/WebCore/svg/graphics/filters/SVGFEMorphology.cpp1269045945Python Subversion client for CIA1.18WebKitWebKitTools56287dpranke@chromium.org2010-03-19 Dirk Pranke <dpranke@chromium.org> Reviewed by Dimitri Glazkov. Disable the downstream override expectations temporarily to allow us to test that we've upstreamed everything correctly. Also, stop looking at the downstream baselines at all (now you will only be able to update baselines upstream). In theory this should work, but if we need to we can always add the downstream dirs back in. https://bugs.webkit.org/show_bug.cgi?id=36396 * Scripts/webkitpy/layout_tests/port/chromium.py: * Scripts/webkitpy/layout_tests/port/chromium_linux.py: * Scripts/webkitpy/layout_tests/port/chromium_mac.py: * Scripts/webkitpy/layout_tests/port/chromium_win.py: 121ChangeLogScripts/webkitpy/layout_tests/port/chromium.pyScripts/webkitpy/layout_tests/port/chromium_linux.pyScripts/webkitpy/layout_tests/port/chromium_mac.pyScripts/webkitpy/layout_tests/port/chromium_win.py1269045681Python Subversion client for CIA1.18WebKit56286cmarrin@apple.com Fixed a crash with AnimationController getting deleted out from under itself. It's possible for the Frame that owns an AnimationController to get deleted in the EndTransitionEvent (or other animation events) to get deleted in the event handler. Normally this case is protected against by preventing the Frame from getting deleted until the end of the runloop. But native uses of the WebView can subvert this protection. So I added a protector to the animation event dispatcher to protect it in those cases. 157trunk/LayoutTests/ChangeLogtrunk/LayoutTests/transitions/resources/transition-end-event-destroy-iframe-inner.htmltrunk/LayoutTests/transitions/transition-end-event-destroy-iframe.htmltrunk/WebCore/ChangeLogtrunk/WebCore/page/animation/AnimationController.cpp1269044896Python Subversion client for CIA1.18WebKitWebCore56285eric@webkit.org2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org> Reviewed by Antti Koivisto. Multiselect Popup - PopupMenuClient extension https://bugs.webkit.org/show_bug.cgi?id=36178 PopupMenuClient class is the interface used by combobox popup implementations. It needs to be extended to handle <select multiple> needs. A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created. The use of this new class instead of adding methods to PopupMenuClient avoids changes in other non related implementations of PopupMenuClient. RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient and to have the new methods implemented. * platform/PopupMenuClient.h: * rendering/RenderMenuList.cpp: (WebCore::RenderMenuList::listBoxSelectItem): (WebCore::RenderMenuList::multiple): * rendering/RenderMenuList.h: 132ChangeLogplatform/PopupMenuClient.hrendering/RenderMenuList.cpprendering/RenderMenuList.h1269043716Python Subversion client for CIA1.18WebKit56284simon.fraser@apple.com2010-03-19 Simon Fraser <simon.fraser@apple.com> Reviewed by Dimitri Glazkov. https://bugs.webkit.org/show_bug.cgi?id=36387 REGRESSION: Can "uncheck" radio buttons by clicking on them My change in r56174 caused radio buttons and checkboxes to go down the same code path by virtue of allowsIndeterminate(), but this broke save/restore behavior on radio buttons. Fix by saving and restoring both the intermediate and checked state for radio buttons and checkboxes, as well as the "current radio button" state. Test: fast/forms/radio-checkbox-restore-indeterminate.html * html/HTMLInputElement.cpp: (WebCore::EventHandlingState::EventHandlingState): New struct to hold state between preDispatchEventHandler() and postDispatchEventHandler(). (WebCore::HTMLInputElement::preDispatchEventHandler): Store intermedate and checked state and the current radio button. (WebCore::HTMLInputElement::postDispatchEventHandler): Restore state as appropriate. * html/HTMLInputElement.h: Add a comment to clarify how 'intermediate' interacts with 'checked', according to the spec. 313trunk/LayoutTests/ChangeLogtrunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate-expected.txttrunk/LayoutTests/fast/forms/radio-checkbox-restore-indeterminate.htmltrunk/WebCore/ChangeLogtrunk/WebCore/html/HTMLInputElement.cpptrunk/WebCore/html/HTMLInputElement.h1269042127Python Subversion client for CIA1.18WebKitWebKitTools56283dpranke@chromium.org2010-03-19 Dirk Pranke <dpranke@chromium.org> Reviewed by Dimitri Glazkov. fix typo in chromium test expectations overrides routine https://bugs.webkit.org/show_bug.cgi?id=36397 * Scripts/webkitpy/layout_tests/port/chromium.py: 36ChangeLogScripts/webkitpy/layout_tests/port/chromium.py1269041891Python Subversion client for CIA1.18WebKitLayoutTests56282darin@chromium.org2010-03-19 Darin Fisher <darin@chromium.org> Temporarily suppress fast/loader/frame-src-change-added-to-history.html for Tiger to make the bot green. https://bugs.webkit.org/show_bug.cgi?id=36382 * platform/mac-tiger/Skipped: 32ChangeLogplatform/mac-tiger/Skipped1269040157